test fixes

Author: varmax2511

oci/containerengine_work_request_error_test.go

@@ -18,7 +18,8 @@ var (
 		"work_request_id": Representation{repType: Required, create: `${lookup(data.oci_containerengine_work_requests.test_work_requests.work_requests[0], "id")}`},
 	}
 
-	WorkRequestErrorResourceConfig = generateDataSourceFromRepresentationMap("oci_containerengine_work_requests", "test_work_requests", Required, Create, workRequestDataSourceRepresentation)
+	WorkRequestErrorResourceConfig = WorkRequestResourceConfig +
+		generateDataSourceFromRepresentationMap("oci_containerengine_work_requests", "test_work_requests", Required, Create, workRequestDataSourceRepresentation)
 )
 
 func TestContainerengineWorkRequestErrorResource_basic(t *testing.T) {

oci/containerengine_work_request_log_entry_test.go

@@ -18,7 +18,8 @@ var (
 		"work_request_id": Representation{repType: Required, create: `${lookup(data.oci_containerengine_work_requests.test_work_requests.work_requests[0], "id")}`},
 	}
 
-	WorkRequestLogEntryResourceConfig = generateDataSourceFromRepresentationMap("oci_containerengine_work_requests", "test_work_requests", Required, Create, workRequestDataSourceRepresentation)
+	WorkRequestLogEntryResourceConfig = WorkRequestResourceConfig +
+		generateDataSourceFromRepresentationMap("oci_containerengine_work_requests", "test_work_requests", Required, Create, workRequestDataSourceRepresentation)
 )
 
 func TestContainerengineWorkRequestLogEntryResource_basic(t *testing.T) {

oci/core_dedicated_vm_hosts_instance_test.go

@@ -19,8 +19,7 @@ var (
 		"availability_domain":  Representation{repType: Optional, create: `${data.oci_identity_availability_domains.test_availability_domains.availability_domains.0.name}`},
 	}
 
-	DedicatedVmHostsInstanceResourceConfig = generateResourceFromRepresentationMap("oci_core_dedicated_vm_host", "test_dedicated_vm_host", Required, Create, dedicatedVmHostRepresentation) +
-		AvailabilityDomainConfig
+	DedicatedVmHostsInstanceResourceConfig = InstanceResourceConfig
 )
 
 func TestCoreDedicatedVmHostsInstanceResource_basic(t *testing.T) {

oci/core_volume_backup_test.go

@@ -59,9 +59,7 @@ var (
 	volumeBackupId, volumeId                string
 	volumeBackupSourceDetailsRepresentation = map[string]interface{}{}
 
-	VolumeBackupResourceDependencies = generateResourceFromRepresentationMap("oci_core_volume", "test_volume", Required, Create, volumeRepresentation) +
-		AvailabilityDomainConfig +
-		DefinedTagsDependencies
+	VolumeBackupResourceDependencies = VolumeResourceConfig
 )
 
 func TestCoreVolumeBackupResource_basic(t *testing.T) {

oci/database_data_guard_association_test.go

@@ -55,7 +55,9 @@ var (
 		"nsg_ids":                Representation{repType: Optional, create: []string{`${oci_core_network_security_group.test_network_security_group.id}`}},
 	})
 
-	DataGuardAssociationResourceDependenciesBase = AvailabilityDomainConfig + NetworkSecurityGroupResourceConfig + `
+	DataGuardAssociationResourceDependenciesBase = AvailabilityDomainConfig + DefinedTagsDependencies + VcnResourceConfig +
+		generateResourceFromRepresentationMap("oci_core_network_security_group", "test_network_security_group", Optional, Update, networkSecurityGroupRepresentation) +
+		`
 #dataguard requires the some port to be open on the subnet
 resource "oci_core_subnet" "test_subnet" {
   availability_domain = "${data.oci_identity_availability_domains.test_availability_domains.availability_domains.0.name}"

oci/identity_availability_domain_test.go

@@ -82,7 +82,7 @@ func TestIdentityAvailabilityDomainResource_basic(t *testing.T) {
 
 						// no matching AD name
 						if res == nil || len(res) < 1 {
-							fmt.Errorf("No match found for case insensitive search")
+							err = fmt.Errorf("no match found for case insensitive search")
 						}
 						return err
 					},

oci/load_balancer_backend_set_test.go

@@ -70,9 +70,9 @@ var (
 		"verify_peer_certificate": Representation{repType: Optional, create: `false`},
 	}
 
-	BackendSetResourceDependencies = generateResourceFromRepresentationMap("oci_load_balancer_certificate", "test_certificate", Required, Create, certificateRepresentation) +
+	BackendSetResourceDependencies = generateResourceFromRepresentationMap("oci_load_balancer_certificate", "test_certificate", Optional, Create, certificateRepresentation) +
 		generateResourceFromRepresentationMap("oci_load_balancer_load_balancer", "test_load_balancer", Required, Create, loadBalancerRepresentation) +
-		LoadBalancerSubnetDependencies
+		LoadBalancerResourceDependencies
 )
 
 func TestLoadBalancerBackendSetResource_basic(t *testing.T) {

oci/load_balancer_listener_test.go

@@ -42,7 +42,7 @@ var (
 	}
 
 	ListenerResourceDependencies = generateResourceFromRepresentationMap("oci_load_balancer_backend_set", "test_backend_set", Required, Create, backendSetRepresentation) +
-		generateResourceFromRepresentationMap("oci_load_balancer_certificate", "test_certificate", Required, Create, certificateRepresentation) +
+		generateResourceFromRepresentationMap("oci_load_balancer_certificate", "test_certificate", Optional, Create, certificateRepresentation) +
 		generateResourceFromRepresentationMap("oci_load_balancer_load_balancer", "test_load_balancer", Required, Create, loadBalancerRepresentation) +
 		LoadBalancerSubnetDependencies +
 		generateResourceFromRepresentationMap("oci_load_balancer_path_route_set", "test_path_route_set", Required, Create, pathRouteSetRepresentation) +