Go vet fixes

werker build failed releasing 2.1.0:
https://app.wercker.com/Oracle/terraform-provider-baremetal/runs/build/5aa1d8badfd4d20001715c6d?step=5aa1d8c3715d150001542d53

Author: AlaaShaker

provider/core_instance_resource.go

@@ -624,7 +624,7 @@ func (s *InstanceResourceCrud) getPrimaryVnic() (*oci_core.Vnic, error) {
 
 	for _, attachment := range attachments {
 		if attachment.LifecycleState == oci_core.VnicAttachmentLifecycleStateAttached {
-			request := oci_core.GetVnicRequest{attachment.VnicId}
+			request := oci_core.GetVnicRequest{VnicId: attachment.VnicId}
 			response, _ := s.VirtualNetworkClient.GetVnic(context.Background(), request)
 			vnic := &response.Vnic
 

provider/load_balancer_backend_resource_test.go

@@ -187,7 +187,7 @@ func (s *ResourceLoadBalancerBackendTestSuite) TestAccResourceLoadBalancerBacken
 					func(ts *terraform.State) (err error) {
 						res2, err = fromInstanceState(ts, s.ResourceName, "name")
 						if res == res2 {
-							fmt.Errorf("new resource expected to be created but was not")
+							return fmt.Errorf("new resource expected to be created but was not")
 						}
 						return err
 					},

provider/load_balancer_backend_set_resource_test.go

@@ -143,7 +143,7 @@ func (s *ResourceLoadBalancerBackendSetTestSuite) TestAccResourceLoadBalancerBac
 					func(ts *terraform.State) (err error) {
 						res2, err = fromInstanceState(ts, s.ResourceName, "name")
 						if res != res2 {
-							fmt.Errorf("new resource created when it should not have been")
+							return fmt.Errorf("new resource created when it should not have been")
 						}
 						return err
 					},
@@ -190,7 +190,7 @@ func (s *ResourceLoadBalancerBackendSetTestSuite) TestAccResourceLoadBalancerBac
 					func(ts *terraform.State) (err error) {
 						res2, err = fromInstanceState(ts, s.ResourceName, "name")
 						if res != res2 {
-							fmt.Errorf("new resource created when it should not have been")
+							return fmt.Errorf("new resource created when it should not have been")
 						}
 						return err
 					},
@@ -245,7 +245,7 @@ func (s *ResourceLoadBalancerBackendSetTestSuite) TestAccResourceLoadBalancerBac
 					func(ts *terraform.State) (err error) {
 						res2, err = fromInstanceState(ts, s.ResourceName, "name")
 						if res != res2 {
-							fmt.Errorf("new resource created when it should not have been")
+							return fmt.Errorf("new resource created when it should not have been")
 						}
 						return err
 					},

provider/load_balancer_listener_resource_test.go

@@ -125,7 +125,7 @@ func (s *ResourceLoadBalancerListenerTestSuite) TestAccResourceLoadBalancerListe
 					func(ts *terraform.State) (err error) {
 						resId2, err = fromInstanceState(ts, s.ResourceName, "id")
 						if resId2 == resId {
-							fmt.Errorf("resource expected to be recreated but was not")
+							return fmt.Errorf("resource expected to be recreated but was not")
 						}
 						resId = resId2
 						return err
@@ -161,7 +161,7 @@ func (s *ResourceLoadBalancerListenerTestSuite) TestAccResourceLoadBalancerListe
 					func(ts *terraform.State) (err error) {
 						resId2, err = fromInstanceState(ts, s.ResourceName, "id")
 						if resId2 != resId {
-							fmt.Errorf("resource recreated when it should not have been")
+							return fmt.Errorf("resource recreated when it should not have been")
 						}
 						resId = resId2
 						return err

provider/load_balancer_load_balancer_resource_test.go

@@ -113,7 +113,7 @@ func (s *ResourceLoadBalancerLBTestSuite) TestAccResourceLoadBalancerLB_basicPri
 					func(ts *terraform.State) (err error) {
 						resId2, err = fromInstanceState(ts, s.ResourceName, "id")
 						if resId2 != resId {
-							fmt.Errorf("resource recreated when it should not have been")
+							return fmt.Errorf("resource recreated when it should not have been")
 						}
 						return err
 					},
@@ -140,7 +140,7 @@ func (s *ResourceLoadBalancerLBTestSuite) TestAccResourceLoadBalancerLB_basicPri
 					func(ts *terraform.State) (err error) {
 						resId2, err = fromInstanceState(ts, s.ResourceName, "id")
 						if resId2 == resId {
-							fmt.Errorf("resource was not recreated as expected")
+							return fmt.Errorf("resource was not recreated as expected")
 						}
 						return err
 					},