Skip to content

Commit 9da12d2

Browse files
karthikoracle1993jotruon
authored andcommitted
Bug Fix - Update kmskey and vault id separately.
1 parent c9cf145 commit 9da12d2

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

internal/integrationtest/database_autonomous_database_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,7 @@ func TestDatabaseAutonomousDatabaseResource_basic(t *testing.T) {
658658
//resource.TestCheckResourceAttrSet(datasourceName, "autonomous_databases.0.private_endpoint"),
659659
//resource.TestCheckResourceAttrSet(datasourceName, "autonomous_databases.0.private_endpoint_ip"),
660660
resource.TestCheckResourceAttrSet(datasourceName, "autonomous_databases.0.state"),
661-
resource.TestCheckResourceAttr(datasourceName, "autonomous_databases.0.supported_regions_to_clone_to.#", "1"),
661+
resource.TestCheckResourceAttr(datasourceName, "autonomous_databases.0.supported_regions_to_clone_to.#", "5"),
662662
resource.TestCheckResourceAttrSet(datasourceName, "autonomous_databases.0.time_created"),
663663
resource.TestCheckResourceAttrSet(datasourceName, "autonomous_databases.0.time_maintenance_begin"),
664664
resource.TestCheckResourceAttrSet(datasourceName, "autonomous_databases.0.time_maintenance_end"),
@@ -718,7 +718,7 @@ func TestDatabaseAutonomousDatabaseResource_basic(t *testing.T) {
718718
//resource.TestCheckResourceAttrSet(singularDatasourceName, "private_endpoint"),
719719
//resource.TestCheckResourceAttrSet(singularDatasourceName, "private_endpoint_ip"),
720720
resource.TestCheckResourceAttrSet(singularDatasourceName, "state"),
721-
resource.TestCheckResourceAttr(singularDatasourceName, "supported_regions_to_clone_to.#", "1"),
721+
resource.TestCheckResourceAttr(singularDatasourceName, "supported_regions_to_clone_to.#", "5"),
722722
resource.TestCheckResourceAttrSet(singularDatasourceName, "time_created"),
723723
resource.TestCheckResourceAttrSet(singularDatasourceName, "time_maintenance_begin"),
724724
resource.TestCheckResourceAttrSet(singularDatasourceName, "time_maintenance_end"),

internal/service/database/database_autonomous_database_resource.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,11 +1088,11 @@ func (s *DatabaseAutonomousDatabaseResourceCrud) Update() error {
10881088
}
10891089
}
10901090

1091-
if kmsKeyId, ok := s.D.GetOkExists("kms_key_id"); ok && s.D.HasChange("kms_key_id") {
1092-
if vaultId, ok := s.D.GetOkExists("vault_id"); ok && s.D.HasChange("vault_id") {
1091+
if kmsKeyId, ok := s.D.GetOkExists("kms_key_id"); ok {
1092+
if vaultId, ok := s.D.GetOkExists("vault_id"); ok {
10931093
oldRaw1, newRaw1 := s.D.GetChange("kms_key_id")
10941094
oldRaw2, newRaw2 := s.D.GetChange("vault_id")
1095-
if newRaw1 != "" && oldRaw1 != "" && newRaw2 != "" && oldRaw2 != "" {
1095+
if newRaw1 != "" && oldRaw1 != "" && newRaw2 != "" && oldRaw2 != "" && (s.D.HasChange("kms_key_id") || s.D.HasChange("vault_id")) {
10961096
err := s.ConfigureAutonomousDatabaseVaultKey(s.D.Id(), kmsKeyId.(string), vaultId.(string))
10971097
if err != nil {
10981098
return err

0 commit comments

Comments
 (0)