consolidating enum patterns

Author: rcohenma

oci/dns_zones_data_source.go

@@ -115,8 +115,7 @@ func (s *ZonesDataSourceCrud) Get() error {
 	}
 
 	if state, ok := s.D.GetOkExists("state"); ok {
-		tmp := state.(string)
-		request.LifecycleState = oci_dns.ListZonesLifecycleStateEnum(tmp)
+		request.LifecycleState = oci_dns.ListZonesLifecycleStateEnum(state.(string))
 	}
 
 	if timeCreatedGreaterThanOrEqualTo, ok := s.D.GetOkExists("time_created_greater_than_or_equal_to"); ok {

oci/identity_auth_tokens_data_source.go

@@ -111,7 +111,6 @@ func (s *AuthTokensDataSourceCrud) SetData() error {
 		resources = ApplyFilters(f.(*schema.Set), resources, AuthTokensDataSource().Schema["tokens"].Elem.(*schema.Resource).Schema)
 	}
 
-	// @CODEGEN 06/2018: auth_tokens => tokens
 	if err := s.D.Set("tokens", resources); err != nil {
 		return err
 	}

oci/identity_compartments_data_source.go

@@ -58,8 +58,7 @@ func (s *CompartmentsDataSourceCrud) Get() error {
 	request := oci_identity.ListCompartmentsRequest{}
 
 	if accessLevel, ok := s.D.GetOkExists("access_level"); ok {
-		tmp := accessLevel.(string)
-		request.AccessLevel = oci_identity.ListCompartmentsAccessLevelEnum(tmp)
+		request.AccessLevel = oci_identity.ListCompartmentsAccessLevelEnum(accessLevel.(string))
 	}
 
 	if compartmentId, ok := s.D.GetOkExists("compartment_id"); ok {