Skip to content

Commit a8aee47

Browse files
Ravi Tandonalexng-canuck
authored andcommitted
Enable FastConnect tests for PHX
1 parent 8b19f35 commit a8aee47

File tree

2 files changed

+30
-16
lines changed

2 files changed

+30
-16
lines changed

oci/core_cross_connect_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,20 @@ variable "cross_connect_display_name" { default = "displayName2" }
222222
variable "cross_connect_location_name" { default = "Fake Location, Phoenix, AZ" }
223223
variable "cross_connect_port_speed_shape_name" { default = "10 Gbps" }
224224
variable "cross_connect_state" { default = "AVAILABLE" }
225+
variable "cross_connect_is_active" { default = true }
225226
226227
` + compartmentIdVariableStr + CrossConnectResourceConfig,
227228
},
228229
// verify resource import
229230
{
230-
Config: config,
231+
Config: config + `
232+
variable "cross_connect_display_name" { default = "displayName2" }
233+
variable "cross_connect_location_name" { default = "Fake Location, Phoenix, AZ" }
234+
variable "cross_connect_port_speed_shape_name" { default = "10 Gbps" }
235+
variable "cross_connect_state" { default = "AVAILABLE" }
236+
variable "cross_connect_is_active" { default = true }
237+
238+
` + compartmentIdVariableStr + CrossConnectResourceConfig,
231239
ImportState: true,
232240
ImportStateVerify: true,
233241
ImportStateVerifyIgnore: []string{

oci/core_virtual_circuit_test.go

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import (
77
"fmt"
88
"testing"
99

10-
"strings"
11-
1210
"github.com/hashicorp/terraform/helper/resource"
1311
"github.com/hashicorp/terraform/terraform"
1412
"github.com/oracle/oci-go-sdk/common"
@@ -130,7 +128,7 @@ variable "virtual_circuit_cross_connect_mappings_vlan" { default = 200 }
130128
variable "virtual_circuit_customer_bgp_asn" { default = 10 }
131129
variable "virtual_circuit_display_name" { default = "displayName" }
132130
variable "virtual_circuit_public_prefixes_cidr_block" { default = "0.0.0.0/5" }
133-
variable "virtual_circuit_region" { default = "r1" }
131+
variable "virtual_circuit_region" { default = "us-phoenix-1" }
134132
variable "virtual_circuit_state" { default = "AVAILABLE" }
135133
`
136134

@@ -149,11 +147,6 @@ variable "virtual_circuit_type" { default = "PUBLIC" }
149147
)
150148

151149
func TestCoreVirtualCircuitResource_basic(t *testing.T) {
152-
region := getEnvSettingWithBlankDefault("region")
153-
if !strings.EqualFold("r1", region) {
154-
t.Skip("Virtual Circuit tests are not yet enabled in production regions")
155-
}
156-
157150
provider := testAccProvider
158151
config := testProviderConfig()
159152

@@ -263,7 +256,7 @@ func TestCoreVirtualCircuitResource_basic(t *testing.T) {
263256
resource.TestCheckResourceAttr(resourceName, "customer_bgp_asn", "10"),
264257
resource.TestCheckResourceAttr(resourceName, "display_name", "displayName"),
265258
resource.TestCheckResourceAttrSet(resourceName, "gateway_id"),
266-
resource.TestCheckResourceAttr(resourceName, "region", "r1"),
259+
resource.TestCheckResourceAttr(resourceName, "region", "us-phoenix-1"),
267260
resource.TestCheckResourceAttr(resourceName, "type", "PRIVATE"),
268261

269262
func(s *terraform.State) (err error) {
@@ -284,7 +277,7 @@ variable "virtual_circuit_cross_connect_mappings_vlan" { default = 300 }
284277
variable "virtual_circuit_customer_bgp_asn" { default = 11 }
285278
variable "virtual_circuit_display_name" { default = "displayName2" }
286279
variable "virtual_circuit_public_prefixes_cidr_block" { default = "0.0.0.0/5" }
287-
variable "virtual_circuit_region" { default = "r1" }
280+
variable "virtual_circuit_region" { default = "us-phoenix-1" }
288281
variable "virtual_circuit_state" { default = "AVAILABLE" }
289282
variable "virtual_circuit_type" { default = "PRIVATE" }
290283
@@ -300,7 +293,7 @@ variable "virtual_circuit_type" { default = "PRIVATE" }
300293
resource.TestCheckResourceAttr(resourceName, "customer_bgp_asn", "11"),
301294
resource.TestCheckResourceAttr(resourceName, "display_name", "displayName2"),
302295
resource.TestCheckResourceAttrSet(resourceName, "gateway_id"),
303-
resource.TestCheckResourceAttr(resourceName, "region", "r1"),
296+
resource.TestCheckResourceAttr(resourceName, "region", "us-phoenix-1"),
304297
resource.TestCheckResourceAttr(resourceName, "type", "PRIVATE"),
305298

306299
func(s *terraform.State) (err error) {
@@ -323,7 +316,7 @@ variable "virtual_circuit_cross_connect_mappings_vlan" { default = 300 }
323316
variable "virtual_circuit_customer_bgp_asn" { default = 11 }
324317
variable "virtual_circuit_display_name" { default = "displayName2" }
325318
variable "virtual_circuit_public_prefixes_cidr_block" { default = "0.0.0.0/5" }
326-
variable "virtual_circuit_region" { default = "r1" }
319+
variable "virtual_circuit_region" { default = "us-phoenix-1" }
327320
variable "virtual_circuit_state" { default = "PROVISIONED" }
328321
variable "virtual_circuit_type" { default = "PRIVATE" }
329322
@@ -371,7 +364,7 @@ variable "virtual_circuit_cross_connect_mappings_vlan" { default = 300 }
371364
variable "virtual_circuit_customer_bgp_asn" { default = 11 }
372365
variable "virtual_circuit_display_name" { default = "displayName2" }
373366
variable "virtual_circuit_public_prefixes_cidr_block" { default = "0.0.0.0/5" }
374-
variable "virtual_circuit_region" { default = "r1" }
367+
variable "virtual_circuit_region" { default = "us-phoenix-1" }
375368
variable "virtual_circuit_state" { default = "AVAILABLE" }
376369
variable "virtual_circuit_type" { default = "PRIVATE" }
377370
@@ -413,15 +406,28 @@ variable "virtual_circuit_cross_connect_mappings_vlan" { default = 300 }
413406
variable "virtual_circuit_customer_bgp_asn" { default = 11 }
414407
variable "virtual_circuit_display_name" { default = "displayName2" }
415408
variable "virtual_circuit_public_prefixes_cidr_block" { default = "0.0.0.0/5" }
416-
variable "virtual_circuit_region" { default = "r1" }
409+
variable "virtual_circuit_region" { default = "us-phoenix-1" }
417410
variable "virtual_circuit_state" { default = "AVAILABLE" }
418411
variable "virtual_circuit_type" { default = "PRIVATE" }
419412
420413
` + compartmentIdVariableStr + VirtualCircuitResourceConfig,
421414
},
422415
// verify resource import
423416
{
424-
Config: config,
417+
Config: config + `
418+
variable "virtual_circuit_bandwidth_shape_name" { default = "20 Gbps" }
419+
variable "virtual_circuit_cross_connect_mappings_bgp_md5auth_key" { default = "bgpMd5AuthKey2" }
420+
variable "virtual_circuit_cross_connect_mappings_customer_bgp_peering_ip" { default = "10.0.0.20/31" }
421+
variable "virtual_circuit_cross_connect_mappings_oracle_bgp_peering_ip" { default = "10.0.0.21/31" }
422+
variable "virtual_circuit_cross_connect_mappings_vlan" { default = 300 }
423+
variable "virtual_circuit_customer_bgp_asn" { default = 11 }
424+
variable "virtual_circuit_display_name" { default = "displayName2" }
425+
variable "virtual_circuit_public_prefixes_cidr_block" { default = "0.0.0.0/5" }
426+
variable "virtual_circuit_region" { default = "us-phoenix-1" }
427+
variable "virtual_circuit_state" { default = "AVAILABLE" }
428+
variable "virtual_circuit_type" { default = "PRIVATE" }
429+
430+
` + compartmentIdVariableStr + VirtualCircuitResourceConfig,
425431
ImportState: true,
426432
ImportStateVerify: true,
427433
ImportStateVerifyIgnore: []string{

0 commit comments

Comments
 (0)