Fix LB policy queries, tidy some documentation. Closes #145

Author: mikejihbe

crud/helpers.go

@@ -94,7 +94,7 @@ func LoadBalancerResourceID(res interface{}, workReq *baremetal.WorkRequest) (id
 			s := id.String()
 			return &s, false
 		}
-		// backendset, certificate, listener
+		// backendset, listener
 		name := v.FieldByName("Name")
 		if name.IsValid() {
 			s := name.String()

data_source_obmcs_load_balancer_policies_test.go

@@ -5,7 +5,6 @@ package main
 import (
 	"testing"
 
-	"github.com/MustWin/baremetal-sdk-go"
 	"github.com/hashicorp/terraform/helper/resource"
 	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/hashicorp/terraform/terraform"
@@ -26,30 +25,15 @@ data "baremetal_load_balancer_policies" "t" {
 `
 	config += testProviderConfig()
 
-	compartmentID := "${var.compartment_id}"
-	list := &baremetal.ListLoadBalancerPolicies{
-		LoadBalancerPolicies: []baremetal.LoadBalancerPolicy{
-			{Name: "stub_name1"},
-			{Name: "stub_name2"},
-		},
-	}
-	client.On(
-		"ListLoadBalancerPolicies",
-		compartmentID,
-		(*baremetal.ListLoadBalancerPolicyOptions)(nil),
-	).Return(list, nil)
-
 	resource.UnitTest(t, resource.TestCase{
 		PreventPostDestroyRefresh: true,
 		Providers:                 providers,
 		Steps: []resource.TestStep{
 			{
 				Config: config,
 				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestCheckResourceAttr(resourceName, "compartment_id", compartmentID),
-					resource.TestCheckResourceAttr(resourceName, "policies.#", "2"),
-					resource.TestCheckResourceAttr(resourceName, "policies.0.name", "stub_name1"),
-					resource.TestCheckResourceAttr(resourceName, "policies.1.name", "stub_name2"),
+					resource.TestCheckResourceAttrSet(resourceName, "compartment_id"),
+					resource.TestCheckResourceAttrSet(resourceName, "policies.#"),
 				),
 			},
 		},

provider_test.go

@@ -115,6 +115,14 @@ data "baremetal_core_images" "t" {
 	limit = 1
 }
 
+data "baremetal_core_policies" "policies" {
+	compartment_id = "${var.compartment_id}"
+}
+
+data "baremetal_core_protocols" "protocols" {
+	compartment_id = "${var.compartment_id}"
+}
+
 data "baremetal_core_shape" "shapes" {
 	compartment_id = "${var.compartment_id}"
 	availability_domain = "${data.baremetal_identity_availability_domains.ADs.availability_domains.0.name}"