* add datasource pagination

* improve example output

Author: ccushing

docs/examples/dns/records.tf

@@ -73,8 +73,7 @@ data "oci_dns_records" "rs" {
   # optional
   compartment_id = "${var.compartment_id}"
   domain = "${oci_dns_zone.zone1.name}"
-  rtype = "NS"
-  sort_by = "ttl" # domain|rtype|ttl
+  sort_by = "rtype" # domain|rtype|ttl
   sort_order = "DESC" # ASC|DESC
 }
 

docs/examples/dns/zone.tf

@@ -36,7 +36,7 @@ resource "oci_dns_zone" "zone2" {
 
 data "oci_dns_zones" "zs" {
   compartment_id = "${var.compartment_id}"
-  name_contains = "oci-test"
+  name_contains = "example"
   state = "ACTIVE"
   zone_type = "PRIMARY"
   sort_by = "name" # name|zoneType|timeCreated

provider/dns_record_resource.go

@@ -13,6 +13,7 @@ import (
 	"context"
 
 	"github.com/hashicorp/terraform/helper/schema"
+
 	"github.com/oracle/terraform-provider-oci/crud"
 
 	"fmt"

provider/dns_records_data_source.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/hashicorp/terraform/helper/schema"
 	oci_dns "github.com/oracle/oci-go-sdk/dns"
+
 	"github.com/oracle/terraform-provider-oci/crud"
 )
 
@@ -124,12 +125,24 @@ func (s *RecordsDataSourceCrud) Get() error {
 	}
 
 	request.RequestMetadata.RetryPolicy = getRetryPolicy(false, "dns")
+
 	response, err := s.Client.GetZoneRecords(context.Background(), request)
 	if err != nil {
 		return err
 	}
 
 	s.Res = &response
+	request.Page = s.Res.OpcNextPage
+
+	for request.Page != nil {
+		listResponse, err := s.Client.GetZoneRecords(context.Background(), request)
+		if err != nil {
+			return err
+		}
+
+		s.Res.Items = append(s.Res.Items, listResponse.Items...)
+		request.Page = listResponse.OpcNextPage
+	}
 	return nil
 }
 

provider/dns_zone_resource.go

@@ -9,6 +9,7 @@ import (
 	oci_dns "github.com/oracle/oci-go-sdk/dns"
 
 	"github.com/hashicorp/terraform/helper/validation"
+
 	"github.com/oracle/terraform-provider-oci/crud"
 )
 

provider/dns_zones_data_source.go

@@ -5,11 +5,13 @@ package provider
 import (
 	"context"
 
+	"time"
+
 	"github.com/hashicorp/terraform/helper/schema"
 	oci_common "github.com/oracle/oci-go-sdk/common"
 	oci_dns "github.com/oracle/oci-go-sdk/dns"
+
 	"github.com/oracle/terraform-provider-oci/crud"
-	"time"
 )
 
 func ZonesDataSource() *schema.Resource {
@@ -140,12 +142,24 @@ func (s *ZonesDataSourceCrud) Get() error {
 	}
 
 	request.RequestMetadata.RetryPolicy = getRetryPolicy(false, "dns")
+
 	response, err := s.Client.ListZones(context.Background(), request)
 	if err != nil {
 		return err
 	}
 
 	s.Res = &response
+	request.Page = s.Res.OpcNextPage
+
+	for request.Page != nil {
+		listResponse, err := s.Client.ListZones(context.Background(), request)
+		if err != nil {
+			return err
+		}
+
+		s.Res.Items = append(s.Res.Items, listResponse.Items...)
+		request.Page = listResponse.OpcNextPage
+	}
 	return nil
 }