deprecating delete_object_in_destination_bucket

Author: govindrao55

CHANGELOG.md

@@ -9,6 +9,9 @@
 - Support for logging in API Gateway Service
 - Support for Service Connector Hub
 
+### Deprecated
+- The `delete_object_in_destination_bucket` attribute in `oci_objectstorage_replication_policy` is now deprecated
+
 ## 3.91.0 (September 02, 2020)
 
 ### Added

examples/object_storage/bucket_with_replication/main.tf

@@ -114,10 +114,9 @@ output objects {
 }
 
 resource "oci_objectstorage_replication_policy" "bucket_rp" {
-  namespace                           = "${data.oci_objectstorage_namespace.ns.namespace}"
-  bucket                              = "${oci_objectstorage_bucket.bucket1.name}"
-  name                                = "rpOnBucket"
-  destination_region_name             = "${var.region}"
-  delete_object_in_destination_bucket = "ACCEPT"
-  destination_bucket_name             = "${oci_objectstorage_bucket.bucket2.name}"
+  namespace               = "${data.oci_objectstorage_namespace.ns.namespace}"
+  bucket                  = "${oci_objectstorage_bucket.bucket1.name}"
+  name                    = "rpOnBucket"
+  destination_region_name = "${var.region}"
+  destination_bucket_name = "${oci_objectstorage_bucket.bucket2.name}"
 }

oci/crud_helpers.go

@@ -49,14 +49,6 @@ const (
 	SUCCEEDED = "SUCCEEDED"
 )
 
-type deleteObjectInDestinationBucketStateEnum string
-
-// Set of constants representing the allowable values for ListCustomProtectionRulesLifecycleStateEnum
-const (
-	deleteObjectInDestinationBucketStateEnumAccept  deleteObjectInDestinationBucketStateEnum = "ACCEPT"
-	deleteObjectInDestinationBucketStateEnumDecline deleteObjectInDestinationBucketStateEnum = "DECLINE"
-)
-
 const (
 	OpcNextPageHeader = "Opc-Next-Page"
 )

oci/export_resource_helpers.go

@@ -362,9 +362,6 @@ func init() {
 	exportObjectStorageNamespaceHints.processDiscoveredResourcesFn = processObjectStorageNamespace
 	exportObjectStorageNamespaceHints.getHCLStringOverrideFn = getObjectStorageNamespaceHCLDatasource
 	exportObjectStorageNamespaceHints.alwaysExportable = true
-	exportObjectStorageReplicationPolicyHints.defaultValuesForMissingAttributes = map[string]interface{}{
-		"delete_object_in_destination_bucket": deleteObjectInDestinationBucketStateEnumDecline,
-	}
 	exportOnsNotificationTopicHints.getIdFn = getOnsNotificationTopicId
 
 	exportObjectStorageBucketHints.getIdFn = getObjectStorageBucketId

oci/objectstorage_replication_policy_resource.go

@@ -59,12 +59,12 @@ func ObjectStorageReplicationPolicyResource() *schema.Resource {
 			},
 			"delete_object_in_destination_bucket": {
 				Type:     schema.TypeString,
-				Required: true,
+				Optional: true,
 				ForceNew: true,
 				ValidateFunc: validation.StringInSlice([]string{
 					"ACCEPT",
-					"DECLINE",
 				}, true),
+				Deprecated: FieldDeprecated("delete_object_in_destination_bucket"),
 			},
 
 			// Optional
@@ -127,13 +127,6 @@ func (s *ObjectStorageReplicationPolicyResourceCrud) ID() string {
 }
 
 func (s *ObjectStorageReplicationPolicyResourceCrud) Create() error {
-	if state, ok := s.D.GetOkExists("delete_object_in_destination_bucket"); ok {
-		if deleteObjectInDestinationBucketStateEnum(state.(string)) != deleteObjectInDestinationBucketStateEnumAccept {
-			return fmt.Errorf(`If you have 'delete_object_in_destination_bucket' set to 'DECLINE',
-Objects in the destination bucket will not be deleted and therefore you can not create the replication policy. If you 
-are sure to deleted all the objects in the destination buckets, change 'delete_object_in_destination_bucket' set to 'ACCEPT'`)
-		}
-	}
 	request := oci_object_storage.CreateReplicationPolicyRequest{}
 
 	if bucket, ok := s.D.GetOkExists("bucket"); ok {

oci/objectstorage_replication_policy_test.go

@@ -36,12 +36,11 @@ var (
 	}
 
 	replicationPolicyRepresentation = map[string]interface{}{
-		"bucket":                              Representation{repType: Required, create: `${oci_objectstorage_bucket.test_bucket.name}`},
-		"destination_bucket_name":             Representation{repType: Required, create: `${oci_objectstorage_bucket.test_bucket_replication.name}`},
-		"destination_region_name":             Representation{repType: Required, create: `${var.region}`},
-		"name":                                Representation{repType: Required, create: `mypolicy`},
-		"delete_object_in_destination_bucket": Representation{repType: Required, create: `ACCEPT`},
-		"namespace":                           Representation{repType: Required, create: `${oci_objectstorage_bucket.test_bucket.namespace}`},
+		"bucket":                  Representation{repType: Required, create: `${oci_objectstorage_bucket.test_bucket.name}`},
+		"destination_bucket_name": Representation{repType: Required, create: `${oci_objectstorage_bucket.test_bucket_replication.name}`},
+		"destination_region_name": Representation{repType: Required, create: `${var.region}`},
+		"name":                    Representation{repType: Required, create: `mypolicy`},
+		"namespace":               Representation{repType: Required, create: `${oci_objectstorage_bucket.test_bucket.namespace}`},
 	}
 
 	ReplicationPolicyResourceDependencies = generateDataSourceFromRepresentationMap("oci_identity_regions", "test_regions", Required, Create, regionDataSourceRepresentation) +
@@ -143,7 +142,7 @@ func TestObjectStorageReplicationPolicyResource_basic(t *testing.T) {
 				Config:                  config,
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"delete_object_in_destination_bucket"},
+				ImportStateVerifyIgnore: []string{},
 				ResourceName:            resourceName,
 			},
 		},

website/docs/r/objectstorage_replication_policy.html.markdown

@@ -22,7 +22,6 @@ resource "oci_objectstorage_replication_policy" "test_replication_policy" {
 	destination_bucket_name = "${oci_objectstorage_bucket.test_bucket.name}"
 	destination_region_name = "${oci_identity_region.test_region.name}"
 	name = "${var.replication_policy_name}"
-	delete_object_in_destination_bucket = "${delete_object_in_destination_bucket}"
 	namespace = "${var.replication_policy_namespace}"
 }
 ```
@@ -35,7 +34,6 @@ The following arguments are supported:
 * `destination_bucket_name` - (Required) The bucket to replicate to in the destination region. Replication policy creation does not automatically create a destination bucket. Create the destination bucket before creating the policy. 
 * `destination_region_name` - (Required) The destination region to replicate to, for example "us-ashburn-1".
 * `name` - (Required) The name of the policy.
-* `delete_object_in_destination_bucket` - (Required) The flag that indicates user understand they will delete the objects in destination bucket, it will be "ACCEPT" or "DECLINE"
 * `namespace` - (Required) The Object Storage namespace used for the request.