Bug fix for Create route table when route rule contains route_type.

Author: nitimis

examples/networking/route_table/route_table.tf

@@ -57,3 +57,30 @@ resource "oci_core_route_table" "example_route_table" {
   }
 }
 
+resource "oci_core_vcn" "example_vcn_2" {
+  cidr_block     = "10.1.0.0/16"
+  compartment_id = var.compartment_ocid
+  display_name   = "exampleVCN"
+  dns_label      = "tfexamplevcn"
+}
+
+resource "oci_core_internet_gateway" "example_ig_2" {
+  compartment_id = var.compartment_ocid
+  display_name   = "exampleIG"
+  vcn_id         = oci_core_vcn.example_vcn_2.id
+}
+
+resource "oci_core_route_table" "example_route_table_static" {
+  compartment_id = var.compartment_ocid
+  vcn_id         = oci_core_vcn.example_vcn_2.id
+  display_name   = "exampleRouteTable"
+
+  route_rules {
+    description       = var.route_table_route_rules_description
+    destination       = "10.0.0.0/0"
+    destination_type  = "CIDR_BLOCK"
+    network_entity_id = oci_core_internet_gateway.example_ig_2.id
+    route_type = "STATIC"
+  }
+}
+

internal/integrationtest/core_route_table_resource_test.go

@@ -339,6 +339,7 @@ func TestResourceCoreRouteTable_defaultResource(t *testing.T) {
 						route_rules {
 							cidr_block = "0.0.0.0/0"
 							network_entity_id = "${oci_core_internet_gateway.internet-gateway1.id}"
+							route_type = "STATIC"
 						}
 					}` + defaultRouteTable,
 				Check: acctest.ComposeAggregateTestCheckFuncWrapper(
@@ -354,6 +355,12 @@ func TestResourceCoreRouteTable_defaultResource(t *testing.T) {
 						[]string{
 							"network_entity_id",
 						}),
+					acctest.CheckResourceSetContainsElementWithProperties(resourceName, "route_rules", map[string]string{
+						"route_type": "STATIC",
+					},
+						[]string{
+							"network_entity_id",
+						}),
 					resource.TestCheckResourceAttrSet(defaultResourceName, "manage_default_resource_id"),
 					resource.TestCheckResourceAttrSet(defaultResourceName, "compartment_id"),
 					resource.TestCheckResourceAttr(defaultResourceName, "state", string(core.RouteTableLifecycleStateAvailable)),
@@ -414,6 +421,12 @@ func TestResourceCoreRouteTable_defaultResource(t *testing.T) {
 						[]string{
 							"network_entity_id",
 						}),
+					acctest.CheckResourceSetContainsElementWithProperties(resourceName, "route_rules", map[string]string{
+						"route_type": "STATIC",
+					},
+						[]string{
+							"network_entity_id",
+						}),
 					resource.TestCheckResourceAttr(resourceName, "state", string(core.RouteTableLifecycleStateAvailable)),
 					resource.TestCheckResourceAttrSet(defaultResourceName, "manage_default_resource_id"),
 					resource.TestCheckResourceAttr(defaultResourceName, "compartment_id", compartmentIdU),
@@ -431,6 +444,12 @@ func TestResourceCoreRouteTable_defaultResource(t *testing.T) {
 						[]string{
 							"network_entity_id",
 						}),
+					acctest.CheckResourceSetContainsElementWithProperties(resourceName, "route_rules", map[string]string{
+						"route_type": "STATIC",
+					},
+						[]string{
+							"network_entity_id",
+						}),
 					resource.TestCheckResourceAttr(defaultResourceName, "state", string(core.RouteTableLifecycleStateAvailable)),
 				),
 			},

internal/service/core/core_route_table_resource.go

@@ -444,6 +444,9 @@ func RouteRuleToMap(obj oci_core.RouteRule) map[string]interface{} {
 		result["network_entity_id"] = string(*obj.NetworkEntityId)
 	}
 
+	if obj.RouteType != "" {
+		result["route_type"] = string(obj.RouteType)
+	}
 	return result
 }
 
@@ -480,10 +483,14 @@ func routeRulesHashCodeForSets(v interface{}) int {
 		buf.WriteString(fmt.Sprintf("%v-", networkEntityId))
 	}
 
-	if routeType, ok := m["route_type"]; ok && routeType != "" {
-		buf.WriteString(fmt.Sprintf("%v-", routeType))
+	routeType := ""
+	if val, ok := m["route_type"]; ok && val != "" {
+		routeType = val.(string)
 	}
-
+	if routeType == "" {
+		routeType = "STATIC" // normalize default
+	}
+	buf.WriteString(fmt.Sprintf("%v-", routeType))
 	return utils.GetStringHashcode(buf.String())
 
 }