Make size of volume updatable

Author: kilokahn

docs/core/volumes.md

@@ -66,6 +66,7 @@ The following arguments support updates:
 * `defined_tags` - Defined tags for this resource. Each key is predefined and scoped to a namespace. For more information, see [Resource Tags](https://docs.us-phoenix-1.oraclecloud.com/Content/General/Concepts/resourcetags.htm).  Example: `{"Operations.CostCenter": "42"}` 
 * `display_name` - A user-friendly name. Does not have to be unique, and it's changeable. Avoid entering confidential information. 
 * `freeform_tags` - Free-form tags for this resource. Each tag is a simple key-value pair with no predefined name, type, or namespace. For more information, see [Resource Tags](https://docs.us-phoenix-1.oraclecloud.com/Content/General/Concepts/resourcetags.htm).  Example: `{"Department": "Finance"}` 
+* `size_in_gbs` - The size of the volume in GBs.
 
 
 ** IMPORTANT **

provider/core_volume_resource.go

@@ -67,7 +67,6 @@ func VolumeResource() *schema.Resource {
 				Type:             schema.TypeString,
 				Optional:         true,
 				Computed:         true,
-				ForceNew:         true,
 				ValidateFunc:     validateInt64TypeString,
 				DiffSuppressFunc: int64StringDiffSuppressFunction,
 			},
@@ -209,6 +208,18 @@ func (s *VolumeResourceCrud) DeletedTarget() []string {
 	}
 }
 
+func (s *VolumeResourceCrud) UpdatedPending() []string {
+	return []string{
+		string(oci_core.VolumeLifecycleStateProvisioning),
+	}
+}
+
+func (s *VolumeResourceCrud) UpdatedTarget() []string {
+	return []string{
+		string(oci_core.VolumeLifecycleStateAvailable),
+	}
+}
+
 func (s *VolumeResourceCrud) Create() error {
 	request := oci_core.CreateVolumeRequest{}
 
@@ -331,6 +342,15 @@ func (s *VolumeResourceCrud) Update() error {
 		request.FreeformTags = objectMapToStringMap(freeformTags.(map[string]interface{}))
 	}
 
+	if sizeInGBs, ok := s.D.GetOkExists("size_in_gbs"); ok {
+		tmp := sizeInGBs.(string)
+		tmpInt64, err := strconv.ParseInt(tmp, 10, 64)
+		if err != nil {
+			return fmt.Errorf("unable to convert sizeInGBs string: %s to an int64 and encountered error: %v", tmp, err)
+		}
+		request.SizeInGBs = &tmpInt64
+	}
+
 	tmp := s.D.Id()
 	request.VolumeId = &tmp
 

provider/core_volume_test.go

@@ -149,7 +149,7 @@ func TestCoreVolumeResource_basic(t *testing.T) {
 variable "volume_defined_tags_value" { default = "updatedValue" }
 variable "volume_display_name" { default = "displayName2" }
 variable "volume_freeform_tags" { default = {"Department"= "Accounting"} }
-variable "volume_size_in_gbs" { default = 51 }
+variable "volume_size_in_gbs" { default = 52 }
 variable "volume_source_details_type" { default = "volume" }
 variable "volume_state" { default = "AVAILABLE" }
 
@@ -162,8 +162,8 @@ variable "volume_state" { default = "AVAILABLE" }
 					resource.TestCheckResourceAttr(resourceName, "display_name", "displayName2"),
 					resource.TestCheckResourceAttr(resourceName, "freeform_tags.%", "1"),
 					resource.TestCheckResourceAttrSet(resourceName, "id"),
-					resource.TestCheckResourceAttr(resourceName, "size_in_gbs", "51"),
-					resource.TestCheckResourceAttr(resourceName, "size_in_mbs", "52224"),
+					resource.TestCheckResourceAttr(resourceName, "size_in_gbs", "52"),
+					resource.TestCheckResourceAttr(resourceName, "size_in_mbs", "53248"),
 					resource.TestCheckResourceAttr(resourceName, "source_details.#", "1"),
 					resource.TestCheckResourceAttr(resourceName, "source_details.0.type", "volume"),
 					resource.TestCheckResourceAttrSet(resourceName, "state"),
@@ -186,7 +186,7 @@ variable "volume_state" { default = "AVAILABLE" }
 variable "volume_defined_tags_value" { default = "updatedValue" }
 variable "volume_display_name" { default = "displayName2" }
 variable "volume_freeform_tags" { default = {"Department"= "Accounting"} }
-variable "volume_size_in_gbs" { default = 51 }
+variable "volume_size_in_gbs" { default = 52 }
 variable "volume_source_details_type" { default = "volume" }
 variable "volume_state" { default = "AVAILABLE" }
 
@@ -221,8 +221,8 @@ data "oci_core_volumes" "test_volumes" {
 					resource.TestCheckResourceAttr(datasourceName, "volumes.0.display_name", "displayName2"),
 					resource.TestCheckResourceAttr(datasourceName, "volumes.0.freeform_tags.%", "1"),
 					resource.TestCheckResourceAttrSet(datasourceName, "volumes.0.id"),
-					resource.TestCheckResourceAttr(datasourceName, "volumes.0.size_in_gbs", "51"),
-					resource.TestCheckResourceAttr(datasourceName, "volumes.0.size_in_mbs", "52224"),
+					resource.TestCheckResourceAttr(datasourceName, "volumes.0.size_in_gbs", "52"),
+					resource.TestCheckResourceAttr(datasourceName, "volumes.0.size_in_mbs", "53248"),
 					resource.TestCheckResourceAttrSet(datasourceName, "volumes.0.state"),
 					resource.TestCheckResourceAttrSet(datasourceName, "volumes.0.time_created"),
 				),

website/docs/r/core_volume.html.markdown

@@ -58,7 +58,7 @@ The following arguments are supported:
 * `defined_tags` - (Optional) (Updatable) Defined tags for this resource. Each key is predefined and scoped to a namespace. For more information, see [Resource Tags](https://docs.us-phoenix-1.oraclecloud.com/Content/General/Concepts/resourcetags.htm).  Example: `{"Operations.CostCenter": "42"}` 
 * `display_name` - (Optional) (Updatable) A user-friendly name. Does not have to be unique, and it's changeable. Avoid entering confidential information. 
 * `freeform_tags` - (Optional) (Updatable) Free-form tags for this resource. Each tag is a simple key-value pair with no predefined name, type, or namespace. For more information, see [Resource Tags](https://docs.us-phoenix-1.oraclecloud.com/Content/General/Concepts/resourcetags.htm).  Example: `{"Department": "Finance"}` 
-* `size_in_gbs` - (Optional) The size of the volume in GBs.
+* `size_in_gbs` - (Optional) (Updatable) The size of the volume in GBs.
 * `size_in_mbs` - (Optional) The size of the volume in MBs. The value must be a multiple of 1024. This field is deprecated. Use `size_in_gbs` instead. 
 * `source_details` - (Optional) Specifies the volume source details for a new Block volume. The volume source is either another Block volume in the same Availability Domain or a Block volume backup. This is an optional field. If not specified or set to null, the new Block volume will be empty. When specified, the new Block volume will contain data from the source volume or backup. 
 	* `id` - (Required) The OCID of the volume or volume backup.