Bug Fix - enabled preserve_data_volumes in oci_core_instance delete API and host_type in opsi_host_insights_data_source list api

Author: ravinitp

internal/service/core/core_instance_resource.go

@@ -1267,10 +1267,10 @@ func (s *CoreInstanceResourceCrud) Delete() error {
 		request.PreserveBootVolume = &tmp
 	}
 
-	// if preserveDataVolumes, ok := s.D.GetOkExists("preserve_data_volumes"); ok {
-	// 	tmp := preserveDataVolumes.(bool)
-	// 	request.PreserveDataVolumes = &tmp
-	// }
+	if preserveDataVolumes, ok := s.D.GetOkExists("preserve_data_volumes"); ok {
+		tmp := preserveDataVolumes.(bool)
+		request.PreserveBootVolume = &tmp
+	}
 
 	request.RequestMetadata.RetryPolicy = tfresource.GetRetryPolicy(s.DisableNotFoundRetries, "core")
 

internal/service/opsi/opsi_host_insights_data_source.go

@@ -5,7 +5,6 @@ package opsi
 
 import (
 	"context"
-
 	"github.com/oracle/terraform-provider-oci/internal/client"
 	"github.com/oracle/terraform-provider-oci/internal/tfresource"
 
@@ -110,14 +109,15 @@ func (s *OpsiHostInsightsDataSourceCrud) Get() error {
 
 	if hostType, ok := s.D.GetOkExists("host_type"); ok {
 		interfaces := hostType.([]interface{})
-		tmp := make([]oci_opsi.ListHostInsightsPlatformTypeEnum, len(interfaces))
+		tmp := make([]oci_opsi.ListHostInsightsHostTypeEnum, len(interfaces))
 		for i := range interfaces {
 			if interfaces[i] != nil {
-				tmp[i] = interfaces[i].(oci_opsi.ListHostInsightsPlatformTypeEnum)
+				hostType := interfaces[i].(string)
+				tmp[i] = oci_opsi.ListHostInsightsHostTypeEnum(hostType)
 			}
 		}
 		if len(tmp) != 0 || s.D.HasChange("host_type") {
-			// request.HostType = tmp
+			request.HostType = tmp
 		}
 	}