Skip to content

Commit df3370c

Browse files
Terraform Team AutomationNagaRajuPasunuri
authored andcommitted
Added - Support for Mount File System in Data Science Jobs and Notebooks
1 parent 76f1534 commit df3370c

20 files changed

+1188
-13
lines changed

examples/datascience/job/job.tf

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,17 @@ resource "oci_datascience_project" "job" {
2727
compartment_id = var.compartment_ocid
2828
}
2929

30+
resource "oci_core_subnet" "tf_subnet" {
31+
cidr_block = "10.0.1.0/24"
32+
compartment_id = var.compartment_ocid
33+
vcn_id = oci_core_vcn.tf_vcn.id
34+
}
35+
36+
resource "oci_core_vcn" "tf_vcn" {
37+
cidr_block = "10.0.0.0/16"
38+
compartment_id = var.compartment_ocid
39+
}
40+
3041
resource "oci_datascience_job" "job" {
3142
compartment_id = var.compartment_ocid
3243
project_id = oci_datascience_project.job.id
@@ -41,9 +52,10 @@ resource "oci_datascience_job" "job" {
4152
}
4253

4354
job_infrastructure_configuration_details {
44-
job_infrastructure_type = "ME_STANDALONE"
45-
shape_name = "VM.Standard2.2"
55+
job_infrastructure_type = "STANDALONE"
56+
shape_name = "VM.Standard3.Flex"
4657
block_storage_size_in_gbs = 100
58+
subnet_id = oci_core_subnet.tf_subnet.id
4759

4860
# Optional
4961
job_shape_config_details {
@@ -75,7 +87,7 @@ data "oci_datascience_jobs" "by_compartment" {
7587
resource "oci_datascience_job_run" "sync" {
7688
compartment_id = var.compartment_ocid
7789
project_id = oci_datascience_project.job.id
78-
job_id = oci_datascience_project.job.id
90+
job_id = oci_datascience_job.job.id
7991
asynchronous = false
8092
}
8193

@@ -84,7 +96,7 @@ resource "oci_datascience_job_run" "sync" {
8496
resource "oci_datascience_job_run" "async" {
8597
compartment_id = var.compartment_ocid
8698
project_id = oci_datascience_project.job.id
87-
job_id = oci_datascience_project.job.id
99+
job_id = oci_datascience_job.job.id
88100
asynchronous = true
89101
}
90102

internal/integrationtest/datascience_job_test.go

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ var (
7474
}
7575
DatascienceJobJobInfrastructureConfigurationDetailsRepresentation = map[string]interface{}{
7676
"block_storage_size_in_gbs": acctest.Representation{RepType: acctest.Required, Create: `50`, Update: `100`},
77-
"job_infrastructure_type": acctest.Representation{RepType: acctest.Required, Create: `ME_STANDALONE`},
78-
"shape_name": acctest.Representation{RepType: acctest.Required, Create: `VM.Standard2.2`},
79-
"job_shape_config_details": acctest.RepresentationGroup{RepType: acctest.Optional, Group: jobJobInfrastructureConfigurationDetailsJobShapeConfigDetailsRepresentation},
77+
"job_infrastructure_type": acctest.Representation{RepType: acctest.Required, Create: `STANDALONE`},
78+
"shape_name": acctest.Representation{RepType: acctest.Required, Create: `VM.Standard2.1`},
79+
"subnet_id": acctest.Representation{RepType: acctest.Required, Create: `${oci_core_subnet.test_subnet.id}`},
8080
}
8181

8282
ignoreMlJobDefinedTagsChangesRepresentation = map[string]interface{}{
@@ -94,12 +94,10 @@ var (
9494
"artifact_content_disposition": acctest.Representation{RepType: acctest.Required, Create: `attachment; filename=job-artifact.py`},
9595
"lifecycle": acctest.RepresentationGroup{RepType: acctest.Required, Group: ignoreMlJobDefinedTagsChangesRepresentation},
9696
}
97-
jobJobInfrastructureConfigurationDetailsJobShapeConfigDetailsRepresentation = map[string]interface{}{
98-
"memory_in_gbs": acctest.Representation{RepType: acctest.Optional, Create: `1.0`, Update: `1.1`},
99-
"ocpus": acctest.Representation{RepType: acctest.Optional, Create: `1.0`, Update: `2.0`},
100-
}
10197

102-
DatascienceJobResourceDependencies = acctest.GenerateDataSourceFromRepresentationMap("oci_core_shapes", "test_shapes", acctest.Required, acctest.Create, CoreCoreShapeDataSourceRepresentation) +
98+
DatascienceJobResourceDependencies = acctest.GenerateResourceFromRepresentationMap("oci_core_subnet", "test_subnet", acctest.Required, acctest.Create, CoreSubnetRepresentation) +
99+
acctest.GenerateResourceFromRepresentationMap("oci_core_vcn", "test_vcn", acctest.Required, acctest.Create, CoreVcnRepresentation) +
100+
acctest.GenerateDataSourceFromRepresentationMap("oci_core_shapes", "test_shapes", acctest.Required, acctest.Create, CoreCoreShapeDataSourceRepresentation) +
103101
acctest.GenerateResourceFromRepresentationMap("oci_datascience_project", "test_project", acctest.Required, acctest.Create, DatascienceProjectRepresentation) +
104102
DefinedTagsDependencies
105103
)
@@ -264,7 +262,6 @@ func TestDatascienceJobResource_basic(t *testing.T) {
264262
resource.TestCheckResourceAttr(datasourceName, "display_name", "displayName2"),
265263
resource.TestCheckResourceAttrSet(datasourceName, "project_id"),
266264
resource.TestCheckResourceAttr(datasourceName, "state", "ACTIVE"),
267-
268265
resource.TestCheckResourceAttr(datasourceName, "jobs.#", "1"),
269266
resource.TestCheckResourceAttr(datasourceName, "jobs.0.compartment_id", compartmentId),
270267
resource.TestCheckResourceAttr(datasourceName, "jobs.0.display_name", "displayName2"),

internal/integrationtest/datascience_notebook_session_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ var (
129129
acctest.GenerateResourceFromRepresentationMap("oci_core_subnet", "test_subnet", acctest.Required, acctest.Create, CoreSubnetRepresentation) +
130130
acctest.GenerateResourceFromRepresentationMap("oci_core_vcn", "test_vcn", acctest.Required, acctest.Create, CoreVcnRepresentation) +
131131
acctest.GenerateResourceFromRepresentationMap("oci_datascience_project", "test_project", acctest.Required, acctest.Create, DatascienceProjectRepresentation) +
132+
AvailabilityDomainConfig +
132133
DefinedTagsDependencies
133134
)
134135

0 commit comments

Comments
 (0)