Fix sweeper wait condition

Author: parrneet

oci/containerengine_cluster_test.go

@@ -310,7 +310,7 @@ func getClusterIds(compartment string) ([]string, error) {
 func clusterSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if clusterResponse, ok := response.Response.(oci_containerengine.GetClusterResponse); ok {
-		return clusterResponse.LifecycleState == oci_containerengine.ClusterLifecycleStateDeleted
+		return clusterResponse.LifecycleState != oci_containerengine.ClusterLifecycleStateDeleted
 	}
 	return false
 }

oci/core_boot_volume_backup_test.go

@@ -313,7 +313,7 @@ func getBootVolumeBackupIds(compartment string) ([]string, error) {
 func bootVolumeBackupSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if bootVolumeBackupResponse, ok := response.Response.(oci_core.GetBootVolumeBackupResponse); ok {
-		return bootVolumeBackupResponse.LifecycleState == oci_core.BootVolumeBackupLifecycleStateTerminated
+		return bootVolumeBackupResponse.LifecycleState != oci_core.BootVolumeBackupLifecycleStateTerminated
 	}
 	return false
 }

oci/core_boot_volume_test.go

@@ -372,7 +372,7 @@ func getBootVolumeIds(compartment string) ([]string, error) {
 func bootVolumeSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if bootVolumeResponse, ok := response.Response.(oci_core.GetBootVolumeResponse); ok {
-		return bootVolumeResponse.LifecycleState == oci_core.BootVolumeLifecycleStateTerminated
+		return bootVolumeResponse.LifecycleState != oci_core.BootVolumeLifecycleStateTerminated
 	}
 	return false
 }

oci/core_cross_connect_group_test.go

@@ -276,7 +276,7 @@ func getCrossConnectGroupIds(compartment string) ([]string, error) {
 func crossConnectGroupSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if crossConnectGroupResponse, ok := response.Response.(oci_core.GetCrossConnectGroupResponse); ok {
-		return crossConnectGroupResponse.LifecycleState == oci_core.CrossConnectGroupLifecycleStateTerminated
+		return crossConnectGroupResponse.LifecycleState != oci_core.CrossConnectGroupLifecycleStateTerminated
 	}
 	return false
 }

oci/core_cross_connect_test.go

@@ -309,7 +309,7 @@ func getCrossConnectIds(compartment string) ([]string, error) {
 func crossConnectSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if crossConnectResponse, ok := response.Response.(oci_core.GetCrossConnectResponse); ok {
-		return crossConnectResponse.LifecycleState == oci_core.CrossConnectLifecycleStateTerminated
+		return crossConnectResponse.LifecycleState != oci_core.CrossConnectLifecycleStateTerminated
 	}
 	return false
 }

oci/core_dhcp_options_test.go

@@ -294,7 +294,7 @@ func getDhcpOptionsIds(compartment string) ([]string, error) {
 func dhcpOptionsSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if dhcpOptionsResponse, ok := response.Response.(oci_core.GetDhcpOptionsResponse); ok {
-		return dhcpOptionsResponse.LifecycleState == oci_core.DhcpOptionsLifecycleStateTerminated
+		return dhcpOptionsResponse.LifecycleState != oci_core.DhcpOptionsLifecycleStateTerminated
 	}
 	return false
 }

oci/core_drg_attachment_test.go

@@ -261,7 +261,7 @@ func getDrgAttachmentIds(compartment string) ([]string, error) {
 func drgAttachmentSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if drgAttachmentResponse, ok := response.Response.(oci_core.GetDrgAttachmentResponse); ok {
-		return drgAttachmentResponse.LifecycleState == oci_core.DrgAttachmentLifecycleStateDetached
+		return drgAttachmentResponse.LifecycleState != oci_core.DrgAttachmentLifecycleStateDetached
 	}
 	return false
 }

oci/core_drg_test.go

@@ -252,7 +252,7 @@ func getDrgIds(compartment string) ([]string, error) {
 func drgSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if drgResponse, ok := response.Response.(oci_core.GetDrgResponse); ok {
-		return drgResponse.LifecycleState == oci_core.DrgLifecycleStateTerminated
+		return drgResponse.LifecycleState != oci_core.DrgLifecycleStateTerminated
 	}
 	return false
 }

oci/core_image_test.go

@@ -289,7 +289,7 @@ func getImageIds(compartment string) ([]string, error) {
 func imageSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if imageResponse, ok := response.Response.(oci_core.GetImageResponse); ok {
-		return imageResponse.LifecycleState == oci_core.ImageLifecycleStateDeleted
+		return imageResponse.LifecycleState != oci_core.ImageLifecycleStateDeleted
 	}
 	return false
 }

oci/core_instance_console_connection_test.go

@@ -225,7 +225,7 @@ func getInstanceConsoleConnectionIds(compartment string) ([]string, error) {
 func instanceConsoleConnectionSweepWaitCondition(response common.OCIOperationResponse) bool {
 	// Only stop if the resource is available beyond 3 mins. As there could be an issue for the sweeper to delete the resource and manual intervention required.
 	if instanceConsoleConnectionResponse, ok := response.Response.(oci_core.GetInstanceConsoleConnectionResponse); ok {
-		return instanceConsoleConnectionResponse.LifecycleState == oci_core.InstanceConsoleConnectionLifecycleStateDeleted
+		return instanceConsoleConnectionResponse.LifecycleState != oci_core.InstanceConsoleConnectionLifecycleStateDeleted
 	}
 	return false
 }