Making passphrase and private_key sensitive in LB Certificate and exposing WorkRequest FAILED ErrorDetails for load_balancer resources

Author: rcohenma

crud/helpers.go

@@ -156,6 +156,9 @@ func LoadBalancerResourceGet(client *oci_load_balancer.LoadBalancerClient, d *sc
 			if wr.LifecycleState == oci_load_balancer.WorkRequestLifecycleStateSucceeded {
 				return "", false, nil
 			}
+			if wr.LifecycleState == oci_load_balancer.WorkRequestLifecycleStateFailed {
+				return "", false, fmt.Errorf("WorkRequest FAILED: %+v", wr.ErrorDetails)
+			}
 		}
 		return "", true, nil
 	}
@@ -187,7 +190,7 @@ func LoadBalancerWaitForWorkRequest(client *oci_load_balancer.LoadBalancerClient
 		return e
 	}
 	if wr.LifecycleState == oci_load_balancer.WorkRequestLifecycleStateFailed {
-		return errors.New("Resource creation failed, state FAILED")
+		return fmt.Errorf("WorkRequest FAILED: %+v", wr.ErrorDetails)
 	}
 	return nil
 }

provider/load_balancer_certificate_resource.go

@@ -40,16 +40,18 @@ func CertificateResource() *schema.Resource {
 				ForceNew: true,
 			},
 			"passphrase": {
-				Type:     schema.TypeString,
-				Optional: true,
-				ForceNew: true,
-				Default:  "",
+				Type:      schema.TypeString,
+				Optional:  true,
+				ForceNew:  true,
+				Sensitive: true,
+				Default:   "",
 			},
 			"private_key": {
-				Type:     schema.TypeString,
-				Optional: true,
-				Computed: true,
-				ForceNew: true,
+				Type:      schema.TypeString,
+				Optional:  true,
+				Computed:  true,
+				ForceNew:  true,
+				Sensitive: true,
 			},
 			"public_certificate": {
 				Type:     schema.TypeString,