change resource manager stack tests to use pre-created stack

Author: afedorch

oci/resourcemanager_stack_helper.go

@@ -0,0 +1,80 @@
+package oci
+
+import (
+	"archive/zip"
+	"bytes"
+	"context"
+	"encoding/base64"
+	"fmt"
+
+	"github.com/oracle/oci-go-sdk/common"
+	"github.com/oracle/oci-go-sdk/resourcemanager"
+)
+
+func createResourceManagerStack(resourceManagerClient resourcemanager.ResourceManagerClient, stackDisplayName string, compartment string) (string, error) {
+
+	buf := new(bytes.Buffer)
+	zipWriter := zip.NewWriter(buf)
+
+	f, err := zipWriter.Create("test.tf")
+	if err != nil {
+		return "", fmt.Errorf("[DEBUG] cannot create file for zip configuration: %v", err)
+	}
+	_, err = f.Write([]byte("provider oci{}"))
+	if err != nil {
+		return "", fmt.Errorf("[DEBUG] cannot write tf configuration to zip archive: %v", err)
+	}
+	err = zipWriter.Close()
+	if err != nil {
+		return "", fmt.Errorf("[DEBUG] cannot close zip writer: %v", err)
+	}
+
+	encoded := base64.StdEncoding.EncodeToString(buf.Bytes())
+
+	// stack representation to assert in tests
+	stackDescription := stackDisplayName + " Description"
+
+	createStackResponse, err := resourceManagerClient.CreateStack(context.Background(), resourcemanager.CreateStackRequest{
+		CreateStackDetails: resourcemanager.CreateStackDetails{
+			CompartmentId: &compartment,
+			ConfigSource: resourcemanager.CreateZipUploadConfigSourceDetails{
+				ZipFileBase64Encoded: &encoded,
+			},
+			FreeformTags: map[string]string{"bar-key": "value"},
+			DefinedTags:  map[string]map[string]interface{}{"example-tag-namespace-all": {"example-tag": "value"}},
+			Description:  &stackDescription,
+			DisplayName:  &stackDisplayName,
+			Variables:    map[string]string{"var1": "value1", "var2": "value2", "var3": "value3"},
+		},
+		RequestMetadata: common.RequestMetadata{
+			RetryPolicy: getRetryPolicy(false, "resourcemanager"),
+		},
+	})
+
+	if err != nil {
+		return "", fmt.Errorf("[DEBUG] cannot create ResourceManager stack: %v", err)
+	}
+
+	return *createStackResponse.Id, nil
+
+}
+
+func destroyResourceManagerStack(resourceManagerClient resourcemanager.ResourceManagerClient, resourceManagerStackId string) error {
+
+	if resourceManagerStackId == "" {
+		return fmt.Errorf("[DEBUG] ResourceManager StackId is not specified to delete the stack")
+	}
+
+	_, err := resourceManagerClient.DeleteStack(context.Background(), resourcemanager.DeleteStackRequest{
+		StackId: &resourceManagerStackId,
+		RequestMetadata: common.RequestMetadata{
+			RetryPolicy: getRetryPolicy(true, "resourcemanager"),
+		},
+	})
+
+	if err != nil {
+		return fmt.Errorf("[DEBUG] failed to delete resource stack: %s with the error: %v", resourceManagerStackId, err)
+	}
+
+	return nil
+}

oci/resourcemanager_stack_test.go

@@ -21,7 +21,7 @@ import (
 
 var (
 	stackSingularDataSourceRepresentation = map[string]interface{}{
-		"stack_id": Representation{repType: Required, create: `${data.oci_resourcemanager_stacks.test_stacks.stacks[0].id}`},
+		"stack_id": Representation{repType: Required, create: `${var.resource_manager_stack_id}`},
 	}
 
 	stackDataSourceRepresentation = map[string]interface{}{
@@ -45,21 +45,34 @@ func TestResourcemanagerStackResource_basic(t *testing.T) {
 	provider := testAccProvider
 	config := testProviderConfig()
 
+	client := GetTestClients(&schema.ResourceData{}).resourceManagerClient
+
 	compartmentId := getEnvSettingWithBlankDefault("compartment_ocid")
 	compartmentIdVariableStr := fmt.Sprintf("variable \"compartment_id\" { default = \"%s\" }\n", compartmentId)
 
+	resourceManagerStackId, err := createResourceManagerStack(*client, "TestResourcemanagerStackResource_basic", compartmentId)
+	if err != nil {
+		t.Errorf("cannot create resource manager stack for the test run: %v", err)
+	}
+
 	datasourceName := "data.oci_resourcemanager_stacks.test_stacks"
 	singularDatasourceName := "data.oci_resourcemanager_stack.test_stack"
 
 	resource.Test(t, resource.TestCase{
 		PreCheck: func() { testAccPreCheck(t) },
+		CheckDestroy: func(s *terraform.State) error {
+			return destroyResourceManagerStack(*client, resourceManagerStackId)
+		},
+		PreventPostDestroyRefresh: true,
 		Providers: map[string]terraform.ResourceProvider{
 			"oci": provider,
 		},
 		Steps: []resource.TestStep{
 			// verify datasource
 			{
-				Config: config +
+				Config: config + `
+					variable "resource_manager_stack_id" { default = "` + resourceManagerStackId + `" }
+					` +
 					generateDataSourceFromRepresentationMap("oci_resourcemanager_stacks", "test_stacks", Required, Create, stackDataSourceRepresentation) +
 					compartmentIdVariableStr + StackResourceConfig,
 				Check: resource.ComposeAggregateTestCheckFunc(
@@ -80,7 +93,9 @@ func TestResourcemanagerStackResource_basic(t *testing.T) {
 			},
 			// verify singular datasource
 			{
-				Config: config +
+				Config: config + `
+					variable "resource_manager_stack_id" { default = "` + resourceManagerStackId + `" }
+					` +
 					generateDataSourceFromRepresentationMap("oci_resourcemanager_stacks", "test_stacks", Required, Create, stackDataSourceRepresentation) +
 					generateDataSourceFromRepresentationMap("oci_resourcemanager_stack", "test_stack", Required, Create, stackSingularDataSourceRepresentation) +
 					compartmentIdVariableStr + StackResourceConfig,

oci/resourcemanager_stack_tf_state_test.go

@@ -4,9 +4,12 @@ package oci
 
 import (
 	"fmt"
+	"os"
 	"strings"
 	"testing"
 
+	"github.com/hashicorp/terraform/helper/schema"
+
 	"github.com/hashicorp/terraform/helper/resource"
 	"github.com/hashicorp/terraform/terraform"
 
@@ -15,7 +18,7 @@ import (
 
 var (
 	stackTfStateSingularDataSourceRepresentation = map[string]interface{}{
-		"stack_id":   Representation{repType: Required, create: `${data.oci_resourcemanager_stacks.test_stacks.stacks[0].id}`},
+		"stack_id":   Representation{repType: Required, create: `${var.resource_manager_stack_id}`},
 		"local_path": Representation{repType: Required, create: `test.tfstate`},
 	}
 
@@ -33,20 +36,34 @@ func TestResourcemanagerStackTfStateResource_basic(t *testing.T) {
 	provider := testAccProvider
 	config := testProviderConfig()
 
+	client := GetTestClients(&schema.ResourceData{}).resourceManagerClient
+
 	compartmentId := getEnvSettingWithBlankDefault("compartment_ocid")
 	compartmentIdVariableStr := fmt.Sprintf("variable \"compartment_id\" { default = \"%s\" }\n", compartmentId)
 
+	resourceManagerStackId, err := createResourceManagerStack(*client, "TestResourcemanagerStackTfStateResource_basic", compartmentId)
+	if err != nil {
+		t.Errorf("cannot create resource manager stack for the test run: %v", err)
+	}
+
 	singularDatasourceName := "data.oci_resourcemanager_stack_tf_state.test_stack_tf_state"
 
 	resource.Test(t, resource.TestCase{
 		PreCheck: func() { testAccPreCheck(t) },
+		CheckDestroy: func(s *terraform.State) error {
+			os.Remove("test.tfstate")
+			return destroyResourceManagerStack(*client, resourceManagerStackId)
+		},
+		PreventPostDestroyRefresh: true,
 		Providers: map[string]terraform.ResourceProvider{
 			"oci": provider,
 		},
 		Steps: []resource.TestStep{
 			// verify singular datasource
 			{
-				Config: config +
+				Config: config + `
+					variable "resource_manager_stack_id" { default = "` + resourceManagerStackId + `" }
+					` +
 					generateDataSourceFromRepresentationMap("oci_resourcemanager_stack_tf_state", "test_stack_tf_state", Required, Create, stackTfStateSingularDataSourceRepresentation) +
 					compartmentIdVariableStr + StackTfStateResourceConfig,
 				Check: resource.ComposeAggregateTestCheckFunc(