Allow compartments to destroy and be 'recreated' cleanly. It's weird that compartments can't be destroyed, so we do a little dance to avoid errors caused on deletion and re-creation

Author: mikejihbe

identity/compartment_resource.go

@@ -46,5 +46,8 @@ func updateCompartment(d *schema.ResourceData, m interface{}) (e error) {
 }
 
 func deleteCompartment(d *schema.ResourceData, m interface{}) (e error) {
+	sync := &CompartmentResourceCrud{}
+	sync.D = d
+	return crud.DeleteResource(sync)
 	return fmt.Errorf("compartment resource: compartment %v cannot be deleted", d.Id())
 }

identity/compartment_resource_crud.go

@@ -5,6 +5,7 @@ package identity
 import (
 	"github.com/MustWin/baremetal-sdk-go"
 	"github.com/MustWin/terraform-Oracle-BareMetal-Provider/crud"
+	"strings"
 )
 
 type CompartmentResourceCrud struct {
@@ -33,6 +34,21 @@ func (s *CompartmentResourceCrud) Create() (e error) {
 	name := s.D.Get("name").(string)
 	description := s.D.Get("description").(string)
 	s.Res, e = s.Client.CreateCompartment(name, description, nil)
+	// Compartments can't be destroyed, so we shouldn't complain about them being created.
+	if e != nil && strings.Contains(e.Error(), "already exists") {
+		e = nil
+		list, err := s.Client.ListCompartments(nil) // TODO: This won't paginate...
+		if err != nil {
+			e = err
+			return
+		}
+		for _, compartment := range list.Compartments {
+			if compartment.Name == name {
+				s.Res = &compartment
+				break
+			}
+		}
+	}
 	return
 }
 
@@ -50,6 +66,12 @@ func (s *CompartmentResourceCrud) Update() (e error) {
 	return
 }
 
+func (s *CompartmentResourceCrud) Delete() (e error) {
+	// Compartments cannot be deleted. Just pretend it worked.
+	e = nil
+	return
+}
+
 func (s *CompartmentResourceCrud) SetData() {
 	s.D.Set("name", s.Res.Name)
 	s.D.Set("description", s.Res.Description)