Add timeouts to the instance acceptance test to show they work

Author: mikejihbe

Makefile

@@ -13,10 +13,10 @@ fmt:
 	gofmt -w $(GOFMT_FILES)
 
 test_acceptance_debug:
-	TF_LOG=DEBUG DEBUG=true TF_ORACLE_ENV=test TF_ACC=1 go test -v
+	TF_LOG=DEBUG DEBUG=true TF_ORACLE_ENV=test TF_ACC=1 go test -v -timeout 120m
 
 test_acceptance:
-	TF_ORACLE_ENV=test TF_ACC=1 go test -v
+	TF_ORACLE_ENV=test TF_ACC=1 go test -v -timeout 120m
 
 build:
 	go build -o terraform-provider-baremetal

provider_test.go

@@ -125,12 +125,16 @@ resource "baremetal_core_instance" "t" {
 	availability_domain = "${data.baremetal_identity_availability_domains.ADs.availability_domains.0.name}"
 	compartment_id = "${var.compartment_id}"
 	display_name = "instance_name"
-      image = "${data.baremetal_core_images.t.images.0.id}"
-      shape = "${data.baremetal_core_shape.shapes.shapes.0.name}"
-      subnet_id = "${baremetal_core_subnet.WebSubnetAD1.id}"
-      metadata {
-        ssh_authorized_keys = "${var.ssh_public_key}"
-      }
+      	image = "${data.baremetal_core_images.t.images.0.id}"
+      	shape = "${data.baremetal_core_shape.shapes.shapes.0.name}"
+      	subnet_id = "${baremetal_core_subnet.WebSubnetAD1.id}"
+      	metadata {
+        	ssh_authorized_keys = "${var.ssh_public_key}"
+      	}
+
+      	timeouts {
+      		create = "60m"
+      	}
 }
 `
 

resource_obmcs_core_instance_test.go

@@ -46,7 +46,7 @@ func (s *ResourceCoreInstanceTestSuite) SetupTest() {
 	s.Config = instanceConfig + `
 	data "baremetal_core_instances" "s" {
       		compartment_id = "${var.compartment_id}"
-      		availability_domain = availability_domain = "${data.baremetal_identity_availability_domains.ADs.availability_domains.0.name}"
+      		availability_domain = "${data.baremetal_identity_availability_domains.ADs.availability_domains.0.name}"
     	}`
 
 	s.Config += testProviderConfig()
@@ -69,8 +69,8 @@ func (s *ResourceCoreInstanceTestSuite) TestCreateResourceCoreInstance() {
 					resource.TestCheckResourceAttrSet(s.ResourceName, "id"),
 					resource.TestCheckResourceAttr(s.ResourceName, "state", baremetal.ResourceRunning),
 					resource.TestCheckResourceAttrSet(s.ResourceName, "time_created"),
-					resource.TestCheckResourceAttr(s.ResourceName, "public_ip", "0.0.0.0"),
-					resource.TestCheckResourceAttr(s.ResourceName, "private_ip", "0.0.0.0"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "public_ip"),
+					resource.TestCheckResourceAttrSet(s.ResourceName, "private_ip"),
 					resource.TestCheckResourceAttrSet("data.baremetal_core_instances.s", "instances.#"),
 				),
 			},