[GR-38057] Do not always split blocks/Procs

* It is unnecessary in most cases, and the heuristic split works for the rest of the cases.
* What we typically want to split is what is calling the block, that
  already works with @ReportPolymorphism on CallBlockNode.

Author: eregon

src/main/java/org/truffleruby/language/yield/CallBlockNode.java

@@ -111,9 +111,7 @@ private Object[] packArguments(DeclarationContext declarationContext, RubyProc b
     protected DirectCallNode createBlockCallNode(RootCallTarget callTarget) {
         final DirectCallNode callNode = Truffle.getRuntime().createDirectCallNode(callTarget);
 
-        final boolean clone = RubyRootNode.of(callTarget).shouldAlwaysClone() ||
-                getContext().getOptions().YIELD_ALWAYS_CLONE;
-        if (clone && callNode.isCallTargetCloningAllowed()) {
+        if (RubyRootNode.of(callTarget).shouldAlwaysClone() && callNode.isCallTargetCloningAllowed()) {
             callNode.cloneCallTarget();
         }
 

src/main/java/org/truffleruby/options/Options.java

@@ -186,8 +186,6 @@ public class Options {
     public final boolean NEVER_SPLIT_HONOR;
     /** --inline-needs-caller-frame=INLINE_DEFAULT */
     public final boolean INLINE_NEEDS_CALLER_FRAME;
-    /** --yield-always-clone=CLONE_DEFAULT */
-    public final boolean YIELD_ALWAYS_CLONE;
     /** --yield-always-inline=INLINE_DEFAULT */
     public final boolean YIELD_ALWAYS_INLINE;
     /** --method-missing-always-clone=CLONE_DEFAULT */
@@ -291,7 +289,6 @@ public Options(Env env, OptionValues options, LanguageOptions languageOptions) {
         ALWAYS_SPLIT_HONOR = options.hasBeenSet(OptionsCatalog.ALWAYS_SPLIT_HONOR_KEY) ? options.get(OptionsCatalog.ALWAYS_SPLIT_HONOR_KEY) : CLONE_DEFAULT;
         NEVER_SPLIT_HONOR = options.get(OptionsCatalog.NEVER_SPLIT_HONOR_KEY);
         INLINE_NEEDS_CALLER_FRAME = options.hasBeenSet(OptionsCatalog.INLINE_NEEDS_CALLER_FRAME_KEY) ? options.get(OptionsCatalog.INLINE_NEEDS_CALLER_FRAME_KEY) : INLINE_DEFAULT;
-        YIELD_ALWAYS_CLONE = options.hasBeenSet(OptionsCatalog.YIELD_ALWAYS_CLONE_KEY) ? options.get(OptionsCatalog.YIELD_ALWAYS_CLONE_KEY) : CLONE_DEFAULT;
         YIELD_ALWAYS_INLINE = options.hasBeenSet(OptionsCatalog.YIELD_ALWAYS_INLINE_KEY) ? options.get(OptionsCatalog.YIELD_ALWAYS_INLINE_KEY) : INLINE_DEFAULT;
         METHODMISSING_ALWAYS_CLONE = options.hasBeenSet(OptionsCatalog.METHODMISSING_ALWAYS_CLONE_KEY) ? options.get(OptionsCatalog.METHODMISSING_ALWAYS_CLONE_KEY) : CLONE_DEFAULT;
         METHODMISSING_ALWAYS_INLINE = options.hasBeenSet(OptionsCatalog.METHODMISSING_ALWAYS_INLINE_KEY) ? options.get(OptionsCatalog.METHODMISSING_ALWAYS_INLINE_KEY) : INLINE_DEFAULT;
@@ -468,8 +465,6 @@ public Object fromDescriptor(OptionDescriptor descriptor) {
                 return NEVER_SPLIT_HONOR;
             case "ruby.inline-needs-caller-frame":
                 return INLINE_NEEDS_CALLER_FRAME;
-            case "ruby.yield-always-clone":
-                return YIELD_ALWAYS_CLONE;
             case "ruby.yield-always-inline":
                 return YIELD_ALWAYS_INLINE;
             case "ruby.method-missing-always-clone":

src/options.yml

@@ -229,7 +229,6 @@ INTERNAL: # Options for debugging the TruffleRuby implementation
     ALWAYS_SPLIT_HONOR: [always-split-honor, boolean, CLONE_DEFAULT, 'Honor Truffle::Graal.always_split annotations']
     NEVER_SPLIT_HONOR: [never-split-honor, boolean, true, 'Honor Truffle::Graal.never_split annotations']
     INLINE_NEEDS_CALLER_FRAME: [inline-needs-caller-frame, boolean, INLINE_DEFAULT, Inline methods that need their caller frame]
-    YIELD_ALWAYS_CLONE: [yield-always-clone, boolean, CLONE_DEFAULT, Always clone yields]
     YIELD_ALWAYS_INLINE: [yield-always-inline, boolean, INLINE_DEFAULT, Always inline yields]
     METHODMISSING_ALWAYS_CLONE: [method-missing-always-clone, boolean, CLONE_DEFAULT, 'Always clone #method_missing']
     METHODMISSING_ALWAYS_INLINE: [method-missing-always-inline, boolean, INLINE_DEFAULT, 'Always inline #method_missing']

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -146,7 +146,6 @@ public class OptionsCatalog {
     public static final OptionKey<Boolean> ALWAYS_SPLIT_HONOR_KEY = new OptionKey<>(CLONE_DEFAULT_KEY.getDefaultValue());
     public static final OptionKey<Boolean> NEVER_SPLIT_HONOR_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> INLINE_NEEDS_CALLER_FRAME_KEY = new OptionKey<>(INLINE_DEFAULT_KEY.getDefaultValue());
-    public static final OptionKey<Boolean> YIELD_ALWAYS_CLONE_KEY = new OptionKey<>(CLONE_DEFAULT_KEY.getDefaultValue());
     public static final OptionKey<Boolean> YIELD_ALWAYS_INLINE_KEY = new OptionKey<>(INLINE_DEFAULT_KEY.getDefaultValue());
     public static final OptionKey<Boolean> METHODMISSING_ALWAYS_CLONE_KEY = new OptionKey<>(CLONE_DEFAULT_KEY.getDefaultValue());
     public static final OptionKey<Boolean> METHODMISSING_ALWAYS_INLINE_KEY = new OptionKey<>(INLINE_DEFAULT_KEY.getDefaultValue());
@@ -1172,14 +1171,6 @@ public class OptionsCatalog {
             .usageSyntax("")
             .build();
 
-    public static final OptionDescriptor YIELD_ALWAYS_CLONE = OptionDescriptor
-            .newBuilder(YIELD_ALWAYS_CLONE_KEY, "ruby.yield-always-clone")
-            .help("Always clone yields")
-            .category(OptionCategory.INTERNAL)
-            .stability(OptionStability.EXPERIMENTAL)
-            .usageSyntax("")
-            .build();
-
     public static final OptionDescriptor YIELD_ALWAYS_INLINE = OptionDescriptor
             .newBuilder(YIELD_ALWAYS_INLINE_KEY, "ruby.yield-always-inline")
             .help("Always inline yields")
@@ -1562,8 +1553,6 @@ public static OptionDescriptor fromName(String name) {
                 return NEVER_SPLIT_HONOR;
             case "ruby.inline-needs-caller-frame":
                 return INLINE_NEEDS_CALLER_FRAME;
-            case "ruby.yield-always-clone":
-                return YIELD_ALWAYS_CLONE;
             case "ruby.yield-always-inline":
                 return YIELD_ALWAYS_INLINE;
             case "ruby.method-missing-always-clone":
@@ -1729,7 +1718,6 @@ public static OptionDescriptor[] allDescriptors() {
             ALWAYS_SPLIT_HONOR,
             NEVER_SPLIT_HONOR,
             INLINE_NEEDS_CALLER_FRAME,
-            YIELD_ALWAYS_CLONE,
             YIELD_ALWAYS_INLINE,
             METHODMISSING_ALWAYS_CLONE,
             METHODMISSING_ALWAYS_INLINE,