Skip to content

Commit 04fac42

Browse files
eregoneregon
committed
Make it easy to exclude the Zlib.crc_table spec
* It relies on an "undocumented function" from zlib.h and fails on mismatched build-time and run-time zlib versions.
1 parent 0f493e2 commit 04fac42

File tree

2 files changed

+75
-69
lines changed

2 files changed

+75
-69
lines changed

‎ci.jsonnet

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,7 @@ local part_definitions = {
341341
test_specs_mri: {
342342
environment+: {
343343
"CHECK_LEAKS": "true",
344+
"RUBY_SPEC_TEST_ZLIB_CRC_TABLE": "false", # CRuby was built on OL6 and is used on OL7
344345
},
345346
run+: jt(["-u", mri_path(mri_version), "mspec", "spec/ruby"]) +
346347
jt(["-u", mri_path("2.7.2"), "mspec", "spec/ruby"]),

‎spec/ruby/library/zlib/crc_table_spec.rb

Lines changed: 74 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -2,74 +2,79 @@
22
require "zlib"
33

44
describe "Zlib.crc_table" do
5-
6-
it "returns the same value as zlib's get_crc_table()" do
7-
Zlib.crc_table.should == [
8-
0, 1996959894, 3993919788, 2567524794,
9-
124634137, 1886057615, 3915621685, 2657392035,
10-
249268274, 2044508324, 3772115230, 2547177864,
11-
162941995, 2125561021, 3887607047, 2428444049,
12-
498536548, 1789927666, 4089016648, 2227061214,
13-
450548861, 1843258603, 4107580753, 2211677639,
14-
325883990, 1684777152, 4251122042, 2321926636,
15-
335633487, 1661365465, 4195302755, 2366115317,
16-
997073096, 1281953886, 3579855332, 2724688242,
17-
1006888145, 1258607687, 3524101629, 2768942443,
18-
901097722, 1119000684, 3686517206, 2898065728,
19-
853044451, 1172266101, 3705015759, 2882616665,
20-
651767980, 1373503546, 3369554304, 3218104598,
21-
565507253, 1454621731, 3485111705, 3099436303,
22-
671266974, 1594198024, 3322730930, 2970347812,
23-
795835527, 1483230225, 3244367275, 3060149565,
24-
1994146192, 31158534, 2563907772, 4023717930,
25-
1907459465, 112637215, 2680153253, 3904427059,
26-
2013776290, 251722036, 2517215374, 3775830040,
27-
2137656763, 141376813, 2439277719, 3865271297,
28-
1802195444, 476864866, 2238001368, 4066508878,
29-
1812370925, 453092731, 2181625025, 4111451223,
30-
1706088902, 314042704, 2344532202, 4240017532,
31-
1658658271, 366619977, 2362670323, 4224994405,
32-
1303535960, 984961486, 2747007092, 3569037538,
33-
1256170817, 1037604311, 2765210733, 3554079995,
34-
1131014506, 879679996, 2909243462, 3663771856,
35-
1141124467, 855842277, 2852801631, 3708648649,
36-
1342533948, 654459306, 3188396048, 3373015174,
37-
1466479909, 544179635, 3110523913, 3462522015,
38-
1591671054, 702138776, 2966460450, 3352799412,
39-
1504918807, 783551873, 3082640443, 3233442989,
40-
3988292384, 2596254646, 62317068, 1957810842,
41-
3939845945, 2647816111, 81470997, 1943803523,
42-
3814918930, 2489596804, 225274430, 2053790376,
43-
3826175755, 2466906013, 167816743, 2097651377,
44-
4027552580, 2265490386, 503444072, 1762050814,
45-
4150417245, 2154129355, 426522225, 1852507879,
46-
4275313526, 2312317920, 282753626, 1742555852,
47-
4189708143, 2394877945, 397917763, 1622183637,
48-
3604390888, 2714866558, 953729732, 1340076626,
49-
3518719985, 2797360999, 1068828381, 1219638859,
50-
3624741850, 2936675148, 906185462, 1090812512,
51-
3747672003, 2825379669, 829329135, 1181335161,
52-
3412177804, 3160834842, 628085408, 1382605366,
53-
3423369109, 3138078467, 570562233, 1426400815,
54-
3317316542, 2998733608, 733239954, 1555261956,
55-
3268935591, 3050360625, 752459403, 1541320221,
56-
2607071920, 3965973030, 1969922972, 40735498,
57-
2617837225, 3943577151, 1913087877, 83908371,
58-
2512341634, 3803740692, 2075208622, 213261112,
59-
2463272603, 3855990285, 2094854071, 198958881,
60-
2262029012, 4057260610, 1759359992, 534414190,
61-
2176718541, 4139329115, 1873836001, 414664567,
62-
2282248934, 4279200368, 1711684554, 285281116,
63-
2405801727, 4167216745, 1634467795, 376229701,
64-
2685067896, 3608007406, 1308918612, 956543938,
65-
2808555105, 3495958263, 1231636301, 1047427035,
66-
2932959818, 3654703836, 1088359270, 936918000,
67-
2847714899, 3736837829, 1202900863, 817233897,
68-
3183342108, 3401237130, 1404277552, 615818150,
69-
3134207493, 3453421203, 1423857449, 601450431,
70-
3009837614, 3294710456, 1567103746, 711928724,
71-
3020668471, 3272380065, 1510334235, 755167117,
72-
]
5+
# This spec fails when zlib.h and libz.so are not from the same version.
6+
# In older zlib (< 1.2.7 it seems), get_crc_table() is stored as u64[],
7+
# but in newer zlib, get_crc_table() is stored as u32[].
8+
# Technically, there is ABI breakage between those zlib versions,
9+
# but get_crc_table() is an "undocumented function" according to zlib.h.
10+
guard -> { ENV["RUBY_SPEC_TEST_ZLIB_CRC_TABLE"] != "false" } do
11+
it "returns the same value as zlib's get_crc_table()" do
12+
Zlib.crc_table.should == [
13+
0, 1996959894, 3993919788, 2567524794,
14+
124634137, 1886057615, 3915621685, 2657392035,
15+
249268274, 2044508324, 3772115230, 2547177864,
16+
162941995, 2125561021, 3887607047, 2428444049,
17+
498536548, 1789927666, 4089016648, 2227061214,
18+
450548861, 1843258603, 4107580753, 2211677639,
19+
325883990, 1684777152, 4251122042, 2321926636,
20+
335633487, 1661365465, 4195302755, 2366115317,
21+
997073096, 1281953886, 3579855332, 2724688242,
22+
1006888145, 1258607687, 3524101629, 2768942443,
23+
901097722, 1119000684, 3686517206, 2898065728,
24+
853044451, 1172266101, 3705015759, 2882616665,
25+
651767980, 1373503546, 3369554304, 3218104598,
26+
565507253, 1454621731, 3485111705, 3099436303,
27+
671266974, 1594198024, 3322730930, 2970347812,
28+
795835527, 1483230225, 3244367275, 3060149565,
29+
1994146192, 31158534, 2563907772, 4023717930,
30+
1907459465, 112637215, 2680153253, 3904427059,
31+
2013776290, 251722036, 2517215374, 3775830040,
32+
2137656763, 141376813, 2439277719, 3865271297,
33+
1802195444, 476864866, 2238001368, 4066508878,
34+
1812370925, 453092731, 2181625025, 4111451223,
35+
1706088902, 314042704, 2344532202, 4240017532,
36+
1658658271, 366619977, 2362670323, 4224994405,
37+
1303535960, 984961486, 2747007092, 3569037538,
38+
1256170817, 1037604311, 2765210733, 3554079995,
39+
1131014506, 879679996, 2909243462, 3663771856,
40+
1141124467, 855842277, 2852801631, 3708648649,
41+
1342533948, 654459306, 3188396048, 3373015174,
42+
1466479909, 544179635, 3110523913, 3462522015,
43+
1591671054, 702138776, 2966460450, 3352799412,
44+
1504918807, 783551873, 3082640443, 3233442989,
45+
3988292384, 2596254646, 62317068, 1957810842,
46+
3939845945, 2647816111, 81470997, 1943803523,
47+
3814918930, 2489596804, 225274430, 2053790376,
48+
3826175755, 2466906013, 167816743, 2097651377,
49+
4027552580, 2265490386, 503444072, 1762050814,
50+
4150417245, 2154129355, 426522225, 1852507879,
51+
4275313526, 2312317920, 282753626, 1742555852,
52+
4189708143, 2394877945, 397917763, 1622183637,
53+
3604390888, 2714866558, 953729732, 1340076626,
54+
3518719985, 2797360999, 1068828381, 1219638859,
55+
3624741850, 2936675148, 906185462, 1090812512,
56+
3747672003, 2825379669, 829329135, 1181335161,
57+
3412177804, 3160834842, 628085408, 1382605366,
58+
3423369109, 3138078467, 570562233, 1426400815,
59+
3317316542, 2998733608, 733239954, 1555261956,
60+
3268935591, 3050360625, 752459403, 1541320221,
61+
2607071920, 3965973030, 1969922972, 40735498,
62+
2617837225, 3943577151, 1913087877, 83908371,
63+
2512341634, 3803740692, 2075208622, 213261112,
64+
2463272603, 3855990285, 2094854071, 198958881,
65+
2262029012, 4057260610, 1759359992, 534414190,
66+
2176718541, 4139329115, 1873836001, 414664567,
67+
2282248934, 4279200368, 1711684554, 285281116,
68+
2405801727, 4167216745, 1634467795, 376229701,
69+
2685067896, 3608007406, 1308918612, 956543938,
70+
2808555105, 3495958263, 1231636301, 1047427035,
71+
2932959818, 3654703836, 1088359270, 936918000,
72+
2847714899, 3736837829, 1202900863, 817233897,
73+
3183342108, 3401237130, 1404277552, 615818150,
74+
3134207493, 3453421203, 1423857449, 601450431,
75+
3009837614, 3294710456, 1567103746, 711928724,
76+
3020668471, 3272380065, 1510334235, 755167117,
77+
]
78+
end
7379
end
74-
7580
end

0 commit comments

Comments
 (0)