NotNode is converted to DSL node

Author: horakivo

src/main/java/org/truffleruby/language/control/NotNode.java

@@ -9,32 +9,31 @@
  */
 package org.truffleruby.language.control;
 
+import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Specialization;
 import org.truffleruby.core.cast.BooleanCastNode;
-import org.truffleruby.core.cast.BooleanCastNodeGen;
 import org.truffleruby.language.RubyContextSourceNode;
 import org.truffleruby.language.RubyNode;
 
 import com.oracle.truffle.api.frame.VirtualFrame;
 
-public class NotNode extends RubyContextSourceNode {
+public abstract class NotNode extends RubyContextSourceNode {
 
-    @Child private BooleanCastNode child;
+    @Child private RubyNode child;
 
     public NotNode(RubyNode child) {
-        this.child = BooleanCastNodeGen.create(child);
+        this.child = child;
     }
 
-    @Override
-    public Object execute(VirtualFrame frame) {
-        return !child.execute(frame);
-    }
-
-    private RubyNode getChildBeforeCasting() {
-        return child.getValueNode();
+    @Specialization
+    protected Object doNot(VirtualFrame frame,
+            @Cached BooleanCastNode booleanCastNode) {
+        final var valueAsBoolean = booleanCastNode.execute(child.execute(frame));
+        return !valueAsBoolean;
     }
 
     public RubyNode cloneUninitialized() {
-        var copy = new NotNode(getChildBeforeCasting().cloneUninitialized());
+        var copy = NotNodeGen.create(child.cloneUninitialized());
         return copy.copyFlags(this);
     }
 

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -81,7 +81,7 @@
 import org.truffleruby.language.control.LocalReturnNode;
 import org.truffleruby.language.control.NextNode;
 import org.truffleruby.language.control.NoMatchingPatternNodeGen;
-import org.truffleruby.language.control.NotNode;
+import org.truffleruby.language.control.NotNodeGen;
 import org.truffleruby.language.control.OnceNode;
 import org.truffleruby.language.control.OrLazyValueDefinedNodeGen;
 import org.truffleruby.language.control.OrNodeGen;
@@ -2309,7 +2309,7 @@ public RubyNode visitOpAsgnNode(OpAsgnParseNode node) {
 
         if (node.isLazy()) {
             body = new IfNode(
-                    new NotNode(new IsNilNode(receiverValue.get(sourceSection).accept(this))),
+                    NotNodeGen.create(new IsNilNode(receiverValue.get(sourceSection).accept(this))),
                     body);
             body.unsafeSetSourceSection(sourceSection);
         }
@@ -2891,7 +2891,7 @@ private RubyNode translateWhileNode(WhileParseNode node, boolean conditionInvers
 
         RubyNode condition = node.getConditionNode().accept(this);
         if (conditionInversed) {
-            condition = new NotNode(condition);
+            condition = NotNodeGen.create(condition);
         }
 
         RubyNode body;

src/main/java/org/truffleruby/parser/MethodTranslator.java

@@ -13,6 +13,7 @@
 import java.util.function.Supplier;
 
 import org.truffleruby.RubyLanguage;
+import org.truffleruby.language.control.NotNodeGen;
 import org.truffleruby.language.locals.FindDeclarationVariableNodes.FrameSlotAndDepth;
 import org.truffleruby.language.methods.CachedLazyCallTargetSupplier;
 import org.truffleruby.core.IsNilNode;
@@ -36,7 +37,6 @@
 import org.truffleruby.language.control.DynamicReturnNode;
 import org.truffleruby.language.control.IfElseNode;
 import org.truffleruby.language.control.InvalidReturnNode;
-import org.truffleruby.language.control.NotNode;
 import org.truffleruby.language.control.ReturnID;
 import org.truffleruby.language.locals.LocalVariableType;
 import org.truffleruby.language.locals.ReadLocalVariableNode;
@@ -222,7 +222,7 @@ private RubyNode preludeProc(
                     sourceSection,
                     Arrays.asList(
                             writeArrayNode,
-                            new NotNode(
+                            NotNodeGen.create(
                                     new IsNilNode(
                                             new ReadLocalVariableNode(LocalVariableType.FRAME_LOCAL, arraySlot)))));
 

src/main/java/org/truffleruby/parser/PatternMatchingTranslator.java

@@ -19,7 +19,7 @@
 import org.truffleruby.language.SourceIndexLength;
 import org.truffleruby.language.control.AndNode;
 import org.truffleruby.language.control.ExecuteAndReturnTrueNode;
-import org.truffleruby.language.control.NotNode;
+import org.truffleruby.language.control.NotNodeGen;
 import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.literal.NilLiteralNode;
 import org.truffleruby.language.literal.TruffleInternalModuleLiteralNode;
@@ -95,7 +95,7 @@ public RubyNode translatePatternNode(ParseNode patternNode, RubyNode expressionV
                     pattern = translatePatternNode(ifNode.getThenBody(), expressionValue);
                 } else {
                     pattern = translatePatternNode(ifNode.getElseBody(), expressionValue);
-                    condition = new NotNode(condition);
+                    condition = NotNodeGen.create(condition);
                 }
 
                 return new AndNode(pattern, condition);