Skip to content

Commit 0ed17e2

Browse files
committed
strip --keep-section=.llvmbc is not supported on macOS
* $ graalvm/languages/llvm/native/bin/strip --keep-section=.llvmbc stripped.bundle graalvm/lib/llvm/bin/llvm-strip: error: option not supported by llvm-objcopy for MachO * Fixes #2697
1 parent 19f09bc commit 0ed17e2

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Bug fixes:
1010
* Fix `StringIO` to set position correctly after reading multi-byte characters (#2207, @aardvark179).
1111
* Update `Process` methods to use `module_function` (@bjfish).
1212
* Fix `File::Stat`'s `#executable?` and `#executable_real?` predicates that unconditionally returned `true` for a superuser (#2690, @andrykonchin).
13+
* The `strip` option `--keep-section=.llvmbc` is not supported on macOS (#2697, @eregon).
1314

1415
Compatibility:
1516

lib/cext/ABI_version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
7
1+
8

lib/truffle/rbconfig.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ module RbConfig
6868
ranlib = Truffle::Boot.toolchain_executable(:RANLIB)
6969
strip = Truffle::Boot.toolchain_executable(:STRIP)
7070

71+
strip = "#{strip} --keep-section=.llvmbc" unless Truffle::Platform.darwin?
72+
7173
# Determine the various flags for native compilation
7274
optflags = ''
7375
debugflags = ''
@@ -188,7 +190,7 @@ module RbConfig
188190
'rubyarchhdrdir' => rubyhdrdir.dup,
189191
'rubyhdrdir' => rubyhdrdir,
190192
'SOEXT' => Truffle::Platform::SOEXT.dup,
191-
'STRIP' => "#{strip} --keep-section=.llvmbc",
193+
'STRIP' => strip,
192194
'sysconfdir' => "#{prefix}/etc", # doesn't exist, as in MRI
193195
'target_cpu' => host_cpu,
194196
'target_os' => host_os,

0 commit comments

Comments
 (0)