Cleanups

Author: eregon

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -188,15 +188,13 @@
 import org.truffleruby.parser.ast.EvStrParseNode;
 import org.truffleruby.parser.ast.FCallParseNode;
 import org.truffleruby.parser.ast.FalseParseNode;
-import org.truffleruby.parser.ast.FindPatternParseNode;
 import org.truffleruby.parser.ast.FixnumParseNode;
 import org.truffleruby.parser.ast.FlipParseNode;
 import org.truffleruby.parser.ast.FloatParseNode;
 import org.truffleruby.parser.ast.ForParseNode;
 import org.truffleruby.parser.ast.GlobalAsgnParseNode;
 import org.truffleruby.parser.ast.GlobalVarParseNode;
 import org.truffleruby.parser.ast.HashParseNode;
-import org.truffleruby.parser.ast.HashPatternParseNode;
 import org.truffleruby.parser.ast.IArgumentNode;
 import org.truffleruby.parser.ast.IfParseNode;
 import org.truffleruby.parser.ast.InParseNode;
@@ -843,11 +841,9 @@ public RubyNode visitCaseInNode(CaseInParseNode node) {
                 currentNode, node.getCases(), environment, this);
 
         // Evaluate the case expression and store it in a local
-
-        final RubyNode caseExprValue = node.getCaseNode().accept(this);
         final int tempSlot = environment.declareLocalTemp("case in value");
         final ReadLocalNode readTemp = environment.readNode(tempSlot, sourceSection);
-        final RubyNode assignTemp = readTemp.makeWriteNode(caseExprValue);
+        final RubyNode assignTemp = readTemp.makeWriteNode(node.getCaseNode().accept(this));
 
         /* Build an if expression from the ins and else. Work backwards because the first if contains all the others in
          * its else clause. */
@@ -856,7 +852,7 @@ public RubyNode visitCaseInNode(CaseInParseNode node) {
         if (node.getElseNode() == null) {
             elseNode = NoMatchingPatternNodeGen.create(readTemp);
         } else {
-            elseNode = translateNodeOrNil(sourceSection, node.getElseNode());
+            elseNode = node.getElseNode().accept(this);
         }
 
         for (int n = node.getCases().size() - 1; n >= 0; n--) {
@@ -1492,11 +1488,6 @@ public RubyNode visitFalseNode(FalseParseNode node) {
         return addNewlineIfNeeded(node, ret);
     }
 
-    @Override
-    public RubyNode visitFindPatternNode(FindPatternParseNode node) {
-        throw CompilerDirectives.shouldNotReachHere("TODO");
-    }
-
     @Override
     public RubyNode visitFixnumNode(FixnumParseNode node) {
         final SourceIndexLength sourceSection = node.getPosition();
@@ -1812,11 +1803,6 @@ public RubyNode visitHashNode(HashParseNode node) {
         return addNewlineIfNeeded(node, ret);
     }
 
-    @Override
-    public RubyNode visitHashPatternNode(HashPatternParseNode node) {
-        throw CompilerDirectives.shouldNotReachHere("TODO");
-    }
-
     @Override
     public RubyNode visitIfNode(IfParseNode node) {
         final SourceIndexLength sourceSection = node.getPosition();

src/main/java/org/truffleruby/parser/LoadArgumentsTranslator.java

@@ -608,5 +608,4 @@ protected RubyNode loadArray(SourceIndexLength sourceSection) {
         return node;
     }
 
-
 }

src/main/java/org/truffleruby/parser/ParameterCollector.java

@@ -144,5 +144,4 @@ public Object visitKeywordRestArgNode(KeywordRestArgParseNode node) {
     public Object visitNoKeywordsArgNode(NoKeywordsArgParseNode node) {
         return null;
     }
-
 }

src/main/java/org/truffleruby/parser/ast/ArrayPatternParseNode.java

@@ -57,7 +57,7 @@ public ArrayPatternParseNode(
 
     @Override
     public <T> T accept(NodeVisitor<T> visitor) {
-        return visitor.visitArrayPatternNode(this); // add this
+        return visitor.visitArrayPatternNode(this);
     }
 
     @Override
@@ -67,7 +67,7 @@ public List<ParseNode> childNodes() {
 
     @Override
     public NodeType getNodeType() {
-        return NodeType.ARRAYPATTERNNODE; // add this
+        return NodeType.ARRAYPATTERNNODE;
     }
 
     public void setConstant(ParseNode constant) {