StringEqualInternalNode is DSL inlinable node

Author: horakivo

src/main/java/org/truffleruby/core/inlined/InlinedEqualNode.java

@@ -81,7 +81,7 @@ protected static boolean stringEqual(VirtualFrame frame, Object a, Object b,
         var tstringB = libB.getTString(b);
         var encB = libB.getEncoding(b);
         var compatibleEncoding = negotiateCompatibleStringEncodingNode.execute(node, tstringA, encA, tstringB, encB);
-        return stringEqualInternalNode.executeInternal(tstringA, tstringB, compatibleEncoding);
+        return stringEqualInternalNode.executeInternal(node, tstringA, tstringB, compatibleEncoding);
     }
 
     @Specialization

src/main/java/org/truffleruby/core/string/StringHelperNodes.java

@@ -108,7 +108,7 @@ protected boolean equal(AbstractTruffleString a, RubyEncoding encA, TruffleStrin
                 @Cached EncodingNodes.NegotiateCompatibleStringEncodingNode negotiateCompatibleStringEncodingNode,
                 @Cached StringEqualInternalNode stringEqualInternalNode) {
             var compatibleEncoding = negotiateCompatibleStringEncodingNode.execute(this, a, encA, b, encB);
-            return stringEqualInternalNode.executeInternal(a, b, compatibleEncoding);
+            return stringEqualInternalNode.executeInternal(this, a, b, compatibleEncoding);
         }
     }
 
@@ -128,9 +128,10 @@ public abstract boolean execute(Node node, AbstractTruffleString tstring, RubyEn
                 TruffleString cachedString, RubyEncoding cachedEncoding);
 
         @Specialization(guards = "encA == encB")
-        protected static boolean same(AbstractTruffleString a, RubyEncoding encA, TruffleString b, RubyEncoding encB,
+        protected static boolean same(
+                Node node, AbstractTruffleString a, RubyEncoding encA, TruffleString b, RubyEncoding encB,
                 @Cached StringEqualInternalNode stringEqualInternalNode) {
-            return stringEqualInternalNode.executeInternal(a, b, encA);
+            return stringEqualInternalNode.executeInternal(node, a, b, encA);
         }
 
         @Specialization(guards = "encA != encB")
@@ -140,25 +141,29 @@ protected static boolean diff(AbstractTruffleString a, RubyEncoding encA, Truffl
     }
 
     @GenerateUncached
+    @GenerateCached(false)
+    @GenerateInline
     public abstract static class StringEqualInternalNode extends RubyBaseNode {
         // compatibleEncoding is RubyEncoding or null
-        public abstract boolean executeInternal(AbstractTruffleString a, AbstractTruffleString b,
+        public abstract boolean executeInternal(Node node, AbstractTruffleString a, AbstractTruffleString b,
                 RubyEncoding compatibleEncoding);
 
         @Specialization(guards = "a.isEmpty() || b.isEmpty()")
-        protected boolean empty(AbstractTruffleString a, AbstractTruffleString b, RubyEncoding compatibleEncoding) {
+        protected static boolean empty(
+                AbstractTruffleString a, AbstractTruffleString b, RubyEncoding compatibleEncoding) {
             assert compatibleEncoding != null;
             return a.isEmpty() && b.isEmpty();
         }
 
         @Specialization(guards = { "compatibleEncoding != null", "!a.isEmpty()", "!b.isEmpty()" })
-        protected boolean equalBytes(AbstractTruffleString a, AbstractTruffleString b, RubyEncoding compatibleEncoding,
+        protected static boolean equalBytes(
+                AbstractTruffleString a, AbstractTruffleString b, RubyEncoding compatibleEncoding,
                 @Cached TruffleString.EqualNode equalNode) {
             return equalNode.execute(a, b, compatibleEncoding.tencoding);
         }
 
         @Specialization(guards = "compatibleEncoding == null")
-        protected boolean notComparable(
+        protected static boolean notComparable(
                 AbstractTruffleString a, AbstractTruffleString b, RubyEncoding compatibleEncoding) {
             return false;
         }

src/main/java/org/truffleruby/core/string/StringNodes.java

@@ -311,7 +311,7 @@ protected static boolean equalString(Object a, Object b,
             var encB = libB.getEncoding(b);
             var compatibleEncoding = negotiateCompatibleStringEncodingNode.execute(node, tstringA, encA, tstringB,
                     encB);
-            return stringEqualInternalNode.executeInternal(tstringA, tstringB, compatibleEncoding);
+            return stringEqualInternalNode.executeInternal(node, tstringA, tstringB, compatibleEncoding);
         }
 
         @Specialization(guards = "isNotRubyString(b)")