[GR-18163] Update Dir.foreach to accept an encoding parameter

PullRequest: truffleruby/3235

Author: bjfish

CHANGELOG.md

@@ -44,6 +44,7 @@ Compatibility:
 * Update `String#split` to raise `TypeError` when false is given (#2606, @bjfish).
 * Update `String#lstrip!` to remove leading null characters (#2607, @bjfish).
 * Update `File.utime` to return the number of file names in the arguments (#2616, @bjfish).
+* Update `Dir.foreach` to accept an `encoding` parameter (#2627, @bjfish).
 
 Performance:
 

spec/ruby/core/dir/foreach_spec.rb

@@ -42,6 +42,13 @@
   it "accepts an encoding keyword for the encoding of the entries" do
     dirs = Dir.foreach("#{DirSpecs.mock_dir}/deeply/nested", encoding: "utf-8").to_a.sort
     dirs.each {|dir| dir.encoding.should == Encoding::UTF_8}
+
+    dirs = Dir.foreach("#{DirSpecs.mock_dir}/deeply/nested", encoding: Encoding::UTF_16LE).to_a.sort
+    dirs.each {|dir| dir.encoding.should == Encoding::UTF_16LE}
+
+    Dir.foreach("#{DirSpecs.mock_dir}/deeply/nested", encoding: Encoding::UTF_16LE) do |f|
+      f.encoding.should == Encoding::UTF_16LE
+    end
   end
 
   ruby_version_is ""..."2.7" do

spec/tags/core/dir/foreach_tags.txt

@@ -265,10 +265,10 @@ def glob(pattern, flags=0, base: nil, sort: true, &block)
       end
     end
 
-    def foreach(path)
-      return to_enum(:foreach, path) unless block_given?
+    def foreach(path, **options)
+      return to_enum(:foreach, path, **options) unless block_given?
 
-      open(path) do |dir|
+      open(path, **options) do |dir|
         while s = dir.read
           yield s
         end