OrAssignConstantNode is converted to DSL node

Author: horakivo

src/main/java/org/truffleruby/language/constants/OrAssignConstantNode.java

@@ -9,11 +9,11 @@
  */
 package org.truffleruby.language.constants;
 
-import com.oracle.truffle.api.CompilerDirectives;
+import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.profiles.ConditionProfile;
+import com.oracle.truffle.api.profiles.InlinedConditionProfile;
 import org.truffleruby.core.cast.BooleanCastNode;
-import org.truffleruby.core.cast.BooleanCastNodeGen;
 import org.truffleruby.core.module.RubyModule;
 import org.truffleruby.language.RubyConstant;
 import org.truffleruby.language.RubyContextSourceNode;
@@ -26,25 +26,25 @@
  * We need a separate class for this because we need to check if the constant is defined. Doing so will evaluate the
  * module part, which will be evaluated again when assigning the constant. If evaluating the module part has any
  * side-effect, this is incorrect and differs from MRI semantics. */
-public class OrAssignConstantNode extends RubyContextSourceNode {
+public abstract class OrAssignConstantNode extends RubyContextSourceNode {
 
     @Child protected ReadConstantNode readConstant;
     @Child protected WriteConstantNode writeConstant;
-    @Child private BooleanCastNode cast;
 
-    private final ConditionProfile triviallyUndefined = ConditionProfile.create();
-    private final ConditionProfile defined = ConditionProfile.create();
     private final RunTwiceBranchProfile writeTwiceProfile = new RunTwiceBranchProfile();
 
     public OrAssignConstantNode(ReadConstantNode readConstant, WriteConstantNode writeConstant) {
         this.readConstant = readConstant;
         this.writeConstant = writeConstant;
     }
 
-    @Override
-    public Object execute(VirtualFrame frame) {
-
-        if (triviallyUndefined.profile(readConstant.isModuleTriviallyUndefined(frame, getLanguage(), getContext()))) {
+    @Specialization
+    protected Object doOrAssignConstant(VirtualFrame frame,
+            @Cached BooleanCastNode booleanCastNode,
+            @Cached InlinedConditionProfile defined,
+            @Cached InlinedConditionProfile triviallyUndefined) {
+        if (triviallyUndefined.profile(this,
+                readConstant.isModuleTriviallyUndefined(frame, getLanguage(), getContext()))) {
             // It might not be defined because of autoloaded constants (maybe other reasons?),
             // simply attempt writing (which will trigger autoloads if required).
             // Since we didn't evaluate the module part yet, no side-effects can occur.
@@ -62,31 +62,23 @@ public Object execute(VirtualFrame frame) {
         // Next we check if the constant itself is defined, and if it is, we get its value.
         final RubyConstant constant = readConstant.getConstantIfDefined(module);
 
-        final boolean isDefined = defined.profile(constant != null);
+        final boolean isDefined = defined.profile(this, constant != null);
 
         final Object value = isDefined
                 ? readConstant.getConstant(module, constant)
                 : null;
 
         // Write if the constant is undefined or if its value is falsy.
-        if (!isDefined || !castToBoolean(value)) {
+        if (!isDefined || !booleanCastNode.execute(this, value)) {
             writeTwiceProfile.enter();
             return writeConstant.execute(frame, module);
         } else {
             return value;
         }
     }
 
-    private boolean castToBoolean(final Object value) {
-        if (cast == null) {
-            CompilerDirectives.transferToInterpreterAndInvalidate();
-            cast = insert(BooleanCastNodeGen.create(null));
-        }
-        return cast.execute(value);
-    }
-
     public RubyNode cloneUninitialized() {
-        var copy = new OrAssignConstantNode(
+        var copy = OrAssignConstantNodeGen.create(
                 (ReadConstantNode) readConstant.cloneUninitialized(),
                 (WriteConstantNode) writeConstant.cloneUninitialized());
         return copy.copyFlags(this);

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -64,7 +64,7 @@
 import org.truffleruby.language.SourceIndexLength;
 import org.truffleruby.language.arguments.ArgumentsDescriptor;
 import org.truffleruby.language.arguments.EmptyArgumentsDescriptor;
-import org.truffleruby.language.constants.OrAssignConstantNode;
+import org.truffleruby.language.constants.OrAssignConstantNodeGen;
 import org.truffleruby.language.constants.ReadConstantNode;
 import org.truffleruby.language.constants.ReadConstantWithDynamicScopeNode;
 import org.truffleruby.language.constants.ReadConstantWithLexicalScopeNode;
@@ -2232,7 +2232,7 @@ public RubyNode visitOpAsgnConstDeclNode(OpAsgnConstDeclParseNode node) {
             }
 
             case "||": {
-                return new OrAssignConstantNode(lhs, (WriteConstantNode) rhs);
+                return OrAssignConstantNodeGen.create(lhs, (WriteConstantNode) rhs);
             }
 
             default: {