Skip to content

Commit 263eae5

Browse files
committed
Use @SuppressWarnings("serial") and don't define serialVersionUID
* This fixes many warnings on JDK19 like: DeferredRaiseException.java:20: warning: [serial] non-transient instance field of a serializable class declared with a non-serializable type public final ExceptionGetter exceptionGetter;
1 parent 9b0cf19 commit 263eae5

33 files changed

+33
-143
lines changed

src/launcher/java/org/truffleruby/launcher/CommandLineException.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,9 @@
2727
***** END LICENSE BLOCK *****/
2828
package org.truffleruby.launcher;
2929

30+
@SuppressWarnings("serial")
3031
public class CommandLineException extends Exception {
3132

32-
private static final long serialVersionUID = -8585821821150293755L;
33-
3433
private final boolean usageError;
3534

3635
public CommandLineException(String message) {

src/main/.checkstyle_checks.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,10 @@
251251
<property name="format" value='@Cached.+AbstractTruffleString'/>
252252
<property name="message" value='Do not cache on AbstractTruffleString (which can be mutable), cache on TruffleString and use RubyStringLibrary#asTruffleStringUncached()'/>
253253
</module>
254+
<module name="RegexpSinglelineJava">
255+
<property name="format" value='serialVersionUID'/>
256+
<property name="message" value='Use @SuppressWarnings("serial") instead.'/>
257+
</module>
254258
<module name="IllegalType">
255259
<!-- Use PrintStream instead of PrintWriter, PrintWriter does not consistently flush, even when writing \n.-->
256260
<property name="illegalClassNames" value="TruffleObject,DynamicObject,PrintWriter"/>

src/main/java/org/truffleruby/core/exception/GetBacktraceException.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@
1212
import com.oracle.truffle.api.exception.AbstractTruffleException;
1313
import com.oracle.truffle.api.nodes.Node;
1414

15+
@SuppressWarnings("serial")
1516
public class GetBacktraceException extends AbstractTruffleException {
1617

17-
private static final long serialVersionUID = 2633487517169337464L;
18-
1918
public static final int UNLIMITED = AbstractTruffleException.UNLIMITED_STACK_TRACE;
2019

2120
public GetBacktraceException(Node location, int limit) {

src/main/java/org/truffleruby/core/fiber/FiberManager.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -479,9 +479,8 @@ private FiberSafepointMessage(RubyFiber sendingFiber, SafepointAction action) {
479479

480480
/** Used to cleanup and terminate Fibers when the parent Thread dies. */
481481
// TODO: should not be an AbstractTruffleException and not run ensure, like in CRuby
482+
@SuppressWarnings("serial")
482483
private static final class FiberShutdownException extends TerminationException {
483-
private static final long serialVersionUID = 1522270454305076317L;
484-
485484
public FiberShutdownException(Node location) {
486485
super("terminate Fiber", location);
487486
}

src/main/java/org/truffleruby/core/format/exceptions/CantCompressNegativeException.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
*/
1010
package org.truffleruby.core.format.exceptions;
1111

12+
@SuppressWarnings("serial")
1213
public class CantCompressNegativeException extends FormatException {
13-
14-
private static final long serialVersionUID = 3584862629702748827L;
15-
1614
}

src/main/java/org/truffleruby/core/format/exceptions/CantConvertException.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@
99
*/
1010
package org.truffleruby.core.format.exceptions;
1111

12+
@SuppressWarnings("serial")
1213
public class CantConvertException extends FormatException {
1314

14-
private static final long serialVersionUID = -1748812990145250644L;
15-
1615
public CantConvertException(String message) {
1716
super(message);
1817
}

src/main/java/org/truffleruby/core/format/exceptions/FormatException.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,9 @@
1111

1212
import com.oracle.truffle.api.nodes.ControlFlowException;
1313

14+
@SuppressWarnings("serial")
1415
public class FormatException extends ControlFlowException {
1516

16-
private static final long serialVersionUID = -6570764260422083237L;
17-
1817
private final String message;
1918

2019
public FormatException() {

src/main/java/org/truffleruby/core/format/exceptions/InvalidFormatException.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@
99
*/
1010
package org.truffleruby.core.format.exceptions;
1111

12+
@SuppressWarnings("serial")
1213
public class InvalidFormatException extends FormatException {
1314

14-
private static final long serialVersionUID = -6689191131430505495L;
15-
1615
public InvalidFormatException(String message) {
1716
super(message);
1817
}

src/main/java/org/truffleruby/core/format/exceptions/NoImplicitConversionException.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@
99
*/
1010
package org.truffleruby.core.format.exceptions;
1111

12+
@SuppressWarnings("serial")
1213
public class NoImplicitConversionException extends FormatException {
1314

14-
private static final long serialVersionUID = -2509958825294561087L;
15-
1615
private final Object object;
1716
private final String target;
1817

src/main/java/org/truffleruby/core/format/exceptions/OutsideOfStringException.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
*/
1010
package org.truffleruby.core.format.exceptions;
1111

12+
@SuppressWarnings("serial")
1213
public class OutsideOfStringException extends FormatException {
13-
14-
private static final long serialVersionUID = -4122128522293680018L;
15-
1614
}

0 commit comments

Comments
 (0)