Fix EncodingError message when an invalid Symbol is met at parse time

Author: andrykonchin

CHANGELOG.md

@@ -69,6 +69,7 @@ Compatibility:
 * Support writing to `RData.dfree` for native extensions (#2830, #2732, #2165, @eregon).
 * Fix `IO#write` and support multiple arguments with different encodings (#2829, @andrykonchin).
 * Fix `Array` methods `reject`, `reject!`, `inject`, `map`, `select`, `each_index` and handle a case when array is modified by a passed block like CRuby does (#2822, andrykonchin, @eregon).
+* Fix `EncodingError` exception message when Symbol has invalid encoding (#2850, @andrykonchin).
 
 Performance:
 

spec/ruby/language/symbol_spec.rb

@@ -96,11 +96,11 @@
     %I{a b #{"c"}}.should == [:a, :b, :c]
   end
 
-  it "with invalid bytes raises an EncodingError at parse time" do
+  it "raises an EncodingError at parse time when Symbol with invalid bytes" do
     ScratchPad.record []
     -> {
       eval 'ScratchPad << 1; :"\xC3"'
-    }.should raise_error(EncodingError, /invalid/)
+    }.should raise_error(EncodingError, 'invalid symbol in encoding UTF-8 :"\xC3"')
     ScratchPad.recorded.should == []
   end
 end

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -1110,14 +1110,6 @@ public RubyException regexpError(String message, Node currentNode) {
 
     // Encoding conversion errors.
 
-    @TruffleBoundary
-    public RubyException encodingError(String message, Node currentNode) {
-        RubyClass exceptionClass = context.getCoreLibrary().encodingErrorClass;
-        RubyString errorMessage = StringOperations.createUTF8String(context, language, message);
-
-        return ExceptionOperations.createRubyException(context, exceptionClass, errorMessage, currentNode, null);
-    }
-
     @TruffleBoundary
     public RubyException encodingError(Object string, RubyEncoding encoding, Node currentNode) {
         RubyClass exceptionClass = context.getCoreLibrary().encodingErrorClass;

src/main/java/org/truffleruby/parser/parser/ParserSupport.java

@@ -1259,7 +1259,10 @@ private void checkSymbolCodeRange(SymbolParseNode symbolParseNode) {
         if (!symbolParseNode.getTString().isValidUncached(symbolParseNode.getRubyEncoding().tencoding)) {
             throw new RaiseException(
                     RubyLanguage.getCurrentContext(),
-                    getConfiguration().getContext().getCoreExceptions().encodingError("invalid encoding symbol", null));
+                    getConfiguration().getContext().getCoreExceptions().encodingError(
+                            symbolParseNode.getTString(),
+                            symbolParseNode.getRubyEncoding(),
+                            null));
         }
     }