Rename CheckIfPatternsMatchedNode to NoMatchingPatternError and simplify

Author: eregon

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -381,9 +381,9 @@ public RubyException noMemoryError(Node currentNode, OutOfMemoryError javaThrowa
     // NoMatchingPatternError
 
     @TruffleBoundary
-    public RubyException noMatchingPatternError(String message, Node currentNode) {
+    public RubyException noMatchingPatternError(Object errorMessage, Node currentNode) {
+        assert RubyStringLibrary.getUncached().isRubyString(errorMessage);
         RubyClass exceptionClass = context.getCoreLibrary().noMatchingPatternErrorClass;
-        RubyString errorMessage = StringOperations.createUTF8String(context, language, message);
         return ExceptionOperations.createRubyException(context, exceptionClass, errorMessage, currentNode, null);
     }
 

src/main/java/org/truffleruby/language/control/CheckIfPatternsMatchedNode.java

@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2022, 2023 Oracle and/or its affiliates. All rights reserved. This
+ * code is released under a tri EPL/GPL/LGPL license. You can use it,
+ * redistribute it and/or modify it under the terms of the:
+ *
+ * Eclipse Public License version 2.0, or
+ * GNU General Public License version 2, or
+ * GNU Lesser General Public License version 2.1.
+ */
+package org.truffleruby.language.control;
+
+import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.NodeChild;
+import com.oracle.truffle.api.dsl.Specialization;
+import org.truffleruby.language.RubyContextSourceNode;
+
+import org.truffleruby.language.RubyNode;
+import org.truffleruby.language.dispatch.DispatchNode;
+
+@NodeChild(value = "expressionNode", type = RubyNode.class)
+public abstract class NoMatchingPatternNode extends RubyContextSourceNode {
+
+    protected abstract RubyNode getExpressionNode();
+
+    @Specialization
+    protected Object noMatchingPattern(Object expression,
+            @Cached DispatchNode inspectNode) {
+        Object inspected = inspectNode.call(coreLibrary().truffleTypeModule, "rb_inspect", expression);
+        throw new RaiseException(getContext(), coreExceptions().noMatchingPatternError(inspected, this));
+    }
+
+    @Override
+    public RubyNode cloneUninitialized() {
+        return NoMatchingPatternNodeGen.create(getExpressionNode().cloneUninitialized()).copyFlags(this);
+    }
+}

src/main/java/org/truffleruby/language/control/NoMatchingPatternNode.java

@@ -72,7 +72,6 @@
 import org.truffleruby.language.control.AndNode;
 import org.truffleruby.language.control.BreakID;
 import org.truffleruby.language.control.BreakNode;
-import org.truffleruby.language.control.CheckIfPatternsMatchedNode;
 import org.truffleruby.language.control.DeferredRaiseException;
 import org.truffleruby.language.control.DynamicReturnNode;
 import org.truffleruby.language.control.FrameOnStackNode;
@@ -81,6 +80,7 @@
 import org.truffleruby.language.control.InvalidReturnNode;
 import org.truffleruby.language.control.LocalReturnNode;
 import org.truffleruby.language.control.NextNode;
+import org.truffleruby.language.control.NoMatchingPatternNodeGen;
 import org.truffleruby.language.control.NotNode;
 import org.truffleruby.language.control.OnceNode;
 import org.truffleruby.language.control.OrLazyValueDefinedNode;
@@ -853,16 +853,7 @@ public RubyNode visitCaseInNode(CaseInParseNode node) {
 
         RubyNode elseNode;
         if (node.getElseNode() == null) {
-            RubyCallNodeParameters inspectCallParameters = new RubyCallNodeParameters(
-                    NodeUtil.cloneNode(readTemp),
-                    "inspect",
-                    null,
-                    EmptyArgumentsDescriptor.INSTANCE,
-                    RubyNode.EMPTY_ARRAY,
-                    false,
-                    true);
-            RubyNode inspected = language.coreMethodAssumptions.createCallNode(inspectCallParameters);
-            elseNode = new CheckIfPatternsMatchedNode(inspected);
+            elseNode = NoMatchingPatternNodeGen.create(readTemp);
         } else {
             elseNode = translateNodeOrNil(sourceSection, node.getElseNode());
         }