Use an uncached HashStoreLibrary for assertions

Author: chrisseaton

src/main/java/org/truffleruby/core/hash/library/HashStoreLibrary.java

@@ -47,9 +47,14 @@ public static HashStoreLibrary createDispatched() {
         return FACTORY.createDispatched(HashGuards.hashStrategyLimit());
     }
 
+    public static HashStoreLibrary createUncached(RubyHash hash) {
+        final Object store = hash.store;
+        return FACTORY.getUncached(store);
+    }
+
     public static boolean verify(RubyHash hash) {
         final Object store = hash.store;
-        return FACTORY.getUncached(store).verify(store, hash);
+        return createUncached(hash).verify(store, hash);
     }
 
     /** Looks up the key in the hash and returns the associated value, or the result of calling {@code defaultNode} if

src/main/java/org/truffleruby/language/arguments/ReadUserKeywordsHashNode.java

@@ -19,8 +19,6 @@
 
 public final class ReadUserKeywordsHashNode extends RubyBaseNode {
 
-    @Child protected HashStoreLibrary hashStoreLibrary;
-
     private final ConditionProfile keywordArgumentsProfile = ConditionProfile.create();
 
     public RubyHash execute(VirtualFrame frame) {
@@ -37,15 +35,13 @@ public RubyHash execute(VirtualFrame frame) {
 
     /** Verify that all keywords the descriptor claims should be in the hash, are in fact in the hash. **/
     private boolean assertHashMatchesDescriptor(RubyHash hash, KeywordArgumentsDescriptor descriptor) {
-        if (hashStoreLibrary == null) {
-            hashStoreLibrary = insert(HashStoreLibrary.createDispatched());
-        }
+        final HashStoreLibrary hashStoreLibrary = HashStoreLibrary.createUncached(hash);
 
         for (String keyword : descriptor.getKeywords()) {
             final RubySymbol symbol = getSymbol(keyword);
             final Object value = hashStoreLibrary.lookupOrDefault(hash.store, null, hash, symbol, (f, h, k) -> null);
             assert value != null : "descriptor claims " + keyword +
-                    " was a passed keyword argument but it's not in the hash";
+                    " was a passed as a keyword argument but it's not in the hash";
         }
         return true;
     }