Skip to content

Commit 451d54a

Browse files
committed
Use a frozen string for ENV['TZ']
1 parent c4b40ed commit 451d54a

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

src/main/java/org/truffleruby/core/string/CoreStrings.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public class CoreStrings {
2929
public final CoreString STACK_LEVEL_TOO_DEEP;
3030
public final CoreString TIME_INTERVAL_MUST_BE_POS;
3131
public final CoreString TOO_FEW_ARGUMENTS;
32-
public final CoreString TZ;
3332
public final CoreString UNKNOWN;
3433
public final CoreString UTC;
3534
public final CoreString WRONG_ARGS_ZERO_PLUS_ONE;
@@ -52,7 +51,6 @@ public CoreStrings(RubyLanguage language) {
5251
STACK_LEVEL_TOO_DEEP = new CoreString(language, "stack level too deep");
5352
TIME_INTERVAL_MUST_BE_POS = new CoreString(language, "time interval must be positive");
5453
TOO_FEW_ARGUMENTS = new CoreString(language, "too few arguments");
55-
TZ = new CoreString(language, "TZ");
5654
UNKNOWN = new CoreString(language, "(unknown)");
5755
UTC = new CoreString(language, "UTC");
5856
WRONG_ARGS_ZERO_PLUS_ONE = new CoreString(language, "wrong number of arguments (0 for 1+)");

src/main/java/org/truffleruby/core/string/FrozenStrings.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public class FrozenStrings {
3535
public static final ImmutableRubyString SELF = createFrozenStaticBinaryString("self");
3636
public static final ImmutableRubyString SUPER = createFrozenStaticBinaryString("super");
3737
public static final ImmutableRubyString TRUE = createFrozenStaticBinaryString("true");
38+
public static final ImmutableRubyString TZ = createFrozenStaticBinaryString("TZ");
3839

3940
private static ImmutableRubyString createFrozenStaticBinaryString(String string) {
4041
// defined?(...) returns frozen strings with a binary encoding

src/main/java/org/truffleruby/core/time/GetTimeZoneNode.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import java.util.regex.Pattern;
3535

3636
import com.oracle.truffle.api.CompilerDirectives;
37+
import org.truffleruby.core.string.FrozenStrings;
3738
import org.truffleruby.language.RubyBaseNode;
3839
import org.truffleruby.language.control.RaiseException;
3940
import org.truffleruby.language.dispatch.DispatchNode;
@@ -68,8 +69,7 @@ protected TimeZoneAndName getTimeZone(
6869

6970
protected Object getTZ() {
7071
if (getContext().getEnv().isNativeAccessAllowed()) {
71-
return lookupEnvNode.call(coreLibrary().getENV(), "[]",
72-
getLanguage().coreStrings.TZ.createInstance(getContext()));
72+
return lookupEnvNode.call(coreLibrary().getENV(), "[]", FrozenStrings.TZ);
7373
} else {
7474
return nil;
7575
}

0 commit comments

Comments
 (0)