[GR-18163] Add test for using a stripped C extension and fix strip options on macOS (#2697)

PullRequest: truffleruby/3445

Author: eregon

CHANGELOG.md

@@ -11,6 +11,7 @@ Bug fixes:
 * Fix `StringIO` to set position correctly after reading multi-byte characters (#2207, @aardvark179).
 * Update `Process` methods to use `module_function` (@bjfish).
 * Fix `File::Stat`'s `#executable?` and `#executable_real?` predicates that unconditionally returned `true` for a superuser (#2690, @andrykonchin).
+* The `strip` option `--keep-section=.llvmbc` is not supported on macOS (#2697, @eregon).
 
 Compatibility:
 

ci.jsonnet

@@ -382,8 +382,8 @@ local part_definitions = {
     test_cexts: {
       is_after+:: ["$.use.common"],
       # Only what is not already tested in other gates (e.g., C API and C ext specs are part of test_specs)
-      run+: jt(["test", "mri", "--all-sulong"]) +
-            jt(["test", "cexts"]) +
+      run+: jt(["test", "cexts"]) +
+            jt(["test", "mri", "--all-sulong"]) +
             jt(["test", "bundle"]),
     },
 

lib/cext/ABI_version.txt

@@ -1 +1 @@
-7
+8

lib/truffle/rbconfig.rb

@@ -68,6 +68,8 @@ module RbConfig
   ranlib = Truffle::Boot.toolchain_executable(:RANLIB)
   strip = Truffle::Boot.toolchain_executable(:STRIP)
 
+  strip = "#{strip} --keep-section=.llvmbc" unless Truffle::Platform.darwin?
+
   # Determine the various flags for native compilation
   optflags = ''
   debugflags = ''
@@ -188,7 +190,7 @@ module RbConfig
     'rubyarchhdrdir'    => rubyhdrdir.dup,
     'rubyhdrdir'        => rubyhdrdir,
     'SOEXT'             => Truffle::Platform::SOEXT.dup,
-    'STRIP'             => "#{strip} --keep-section=.llvmbc",
+    'STRIP'             => strip,
     'sysconfdir'        => "#{prefix}/etc", # doesn't exist, as in MRI
     'target_cpu'        => host_cpu,
     'target_os'         => host_os,

test/mri/excludes/FTPTest.rb

@@ -1,3 +1,4 @@
 exclude :test_getbinaryfile_command_injection, "needs investigation"
 exclude :test_getbinaryfile_command_injection, "needs investigation"
 exclude :test_putbinaryfile_command_injection, "hangs"
+exclude :test_list_read_timeout_exceeded, "transient"

test/truffle/cexts/stripped/bin/stripped

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+
+require 'stripped/stripped'
+puts Stripped.stripped

test/truffle/cexts/stripped/expected.txt

@@ -0,0 +1 @@
+Stripped!

test/truffle/cexts/stripped/ext/stripped/extconf.rb

@@ -0,0 +1,12 @@
+require 'mkmf'
+create_makefile('stripped')
+
+contents = File.read('Makefile')
+contents = "hijack: all strip-ext\n\n" + contents + <<EOF
+strip-ext: $(DLLIB)
+	$(ECHO) Stripping $(DLLIB)
+	#{RbConfig::CONFIG['STRIP']} $(DLLIB)
+
+.PHONY: strip-ext
+EOF
+File.write('Makefile', contents)

test/truffle/cexts/stripped/ext/stripped/stripped.c

@@ -0,0 +1,11 @@
+#include <stdio.h>
+#include <ruby.h>
+
+static VALUE stripped_stripped(VALUE self) {
+  return rb_str_new_cstr("Stripped!");
+}
+
+void Init_stripped() {
+  VALUE mod = rb_define_module("Stripped");
+  rb_define_singleton_method(mod, "stripped", stripped_stripped, 0);
+}