Skip to content

Commit 5ad03a6

Browse files
committed
Fix ABI check on GitHub Actions
* The default is fetching a single commit which contains the whole history, which causes the check to believe ABI_version.txt / ABI_check.txt were updated when they were actually not changed in the PR. * See #2871 (comment)
1 parent 1996e7b commit 5ad03a6

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
steps:
1313
- name: Clone TruffleRuby
1414
uses: actions/checkout@v2
15+
with:
16+
fetch-depth: 0 # Necessary for jt check_abi
1517
- name: Setup system Ruby
1618
uses: ruby/setup-ruby@v1
1719
- name: Setup jt

tool/jt.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3053,7 +3053,7 @@ def lint(*args)
30533053
ABI_CHECK_FILE = 'lib/cext/ABI_check.txt'
30543054

30553055
def check_abi(fail: true)
3056-
puts bold 'ABI check'
3056+
puts bold '$ jt check_abi'
30573057
# Check since the last commit at which ABI_CHECK_FILE or ABI_VERSION_FILE were modified
30583058
base_commit = `git log -n 1 --format=%H #{ABI_VERSION_FILE} #{ABI_CHECK_FILE}`.chomp
30593059

0 commit comments

Comments
 (0)