[GR-18163] Add spec and fix exception for Fiddle::Handle.new with a missing library (#2714)

PullRequest: truffleruby/3477

Author: eregon

CHANGELOG.md

@@ -34,6 +34,7 @@ Compatibility:
 * Fix `rb_class2name` to call `inspect` on anonymous classes like in CRuby (#2701, @aardvark179).
 * Implement `rb_ivar_foreach` to iterate over instance and class variables like in CRuby (#2701, @aardvark179).
 * Fix the absolute path of the main script after chdir (#2709, @eregon).
+* Fix exception for `Fiddle::Handle.new` with a missing library (#2714, @eregon).
 
 Performance:
 

lib/truffle/truffle/fiddle_backend.rb

@@ -253,15 +253,16 @@ def self.[](*args)
     RTLD_GLOBAL  = Truffle::Config['platform.dlopen.RTLD_GLOBAL']
 
     def initialize(library = nil, flags = RTLD_LAZY | RTLD_GLOBAL)
-      raise DLError, 'unsupported dlopen flags' if flags != RTLD_LAZY | RTLD_GLOBAL
+      raise DLError, 'unsupported dlopen flags' if flags != (RTLD_LAZY | RTLD_GLOBAL)
+
       if library == Truffle::FiddleBackend::RTLD_NEXT
         @handle = :rtld_next
       else
         library = nil if library == Truffle::FiddleBackend::RTLD_DEFAULT
         begin
           @handle = Primitive.interop_eval_nfi(library ? "load '#{library}'" : 'default')
-        rescue RuntimeError
-          raise DLError, "#{library}: cannot open shared object file: No such file or directory"
+        rescue Polyglot::ForeignException => e
+          raise DLError, "#{e.message}"
         end
       end
     end

spec/ruby/library/fiddle/handle/initialize_spec.rb

@@ -0,0 +1,10 @@
+require_relative '../../../spec_helper'
+require 'fiddle'
+
+describe "Fiddle::Handle#initialize" do
+  it "raises Fiddle::DLError if the library cannot be found" do
+    -> {
+      Fiddle::Handle.new("doesnotexist.doesnotexist")
+    }.should raise_error(Fiddle::DLError)
+  end
+end

spec/ruby/spec_helper.rb

@@ -27,7 +27,8 @@ def report_on_exception=(value)
   end
 end
 
-ruby_version_is ""..."2.7" do
+# Compare with SpecVersion directly here so it works even with --unguarded
+if VersionGuard::FULL_RUBY_VERSION < SpecVersion.new('2.7')
   abort "This version of ruby/spec requires Ruby 2.7+"
 end