[GR-45620] Use custom RuboCop policies

PullRequest: truffleruby/3754

Author: andrykonchin

.rubocop.yml

@@ -1,3 +1,9 @@
+require:
+  - ./tool/rubocop-truffleruby/cop/replace_with_primitive_nil.rb
+  - ./tool/rubocop-truffleruby/cop/replace_with_primitive_object_class.rb
+  - ./tool/rubocop-truffleruby/cop/replace_with_primitive_object_equal.rb
+  - ./tool/rubocop-truffleruby/cop/replace_with_primitive_object_kind_of.rb
+
 AllCops:
   TargetRubyVersion: 3.1
   DisabledByDefault: true
@@ -389,4 +395,28 @@ Layout/SpaceInsideBlockBraces:
 # Supports --auto-correct
 Layout/SpaceAroundEqualsInParameterDefault:
   Description: Checks that the equals signs in parameter default assignments have or don't have surrounding space depending on configuration.
-  Enabled: true
+  Enabled: true
+
+# Supports --auto-correct
+TruffleRuby/ReplaceWithPrimitiveNil:
+  Enabled: true
+  Include: # inspect *only* this directory
+    - src/main/ruby/**/*.rb
+
+# Supports --auto-correct
+TruffleRuby/ReplaceWithPrimitiveObjectClass:
+  Enabled: true
+  Include: # inspect *only* this directory
+    - src/main/ruby/**/*.rb
+
+# Supports --auto-correct
+TruffleRuby/ReplaceWithPrimitiveObjectEqual:
+  Enabled: true
+  Include: # inspect *only* this directory
+    - src/main/ruby/**/*.rb
+
+# Supports --auto-correct
+TruffleRuby/ReplaceWithPrimitiveObjectKindOf:
+  Enabled: true
+  Include: # inspect *only* this directory
+    - src/main/ruby/**/*.rb

src/main/ruby/truffleruby/core/argf.rb

@@ -59,7 +59,7 @@ class ARGFClass
     # @see  #advance!
     #
     def initialize(argv = ARGV, *others)
-      @argv = argv.equal?(ARGV) ? ARGV : [argv, *others]
+      @argv = Primitive.object_equal(argv, ARGV) ? ARGV : [argv, *others]
       @lineno = 0
       # Setting $. sets ARGF.last_lineno, but does not set
       # ARGF.lineno, Almost every operation that sets lineno also sets

src/main/ruby/truffleruby/core/array.rb

@@ -84,7 +84,7 @@ def -(other)
 
   def <=>(other)
     other = Truffle::Type.rb_check_convert_type other, Array, :to_ary
-    return 0 if equal? other
+    return 0 if Primitive.object_equal(self, other)
     return nil if Primitive.nil? other
 
     total = other.size
@@ -125,7 +125,7 @@ def ==(other)
       return result
     end
 
-    return true if equal?(other)
+    return true if Primitive.object_equal(self, other)
     unless Primitive.object_kind_of?(other, Array)
       return false unless other.respond_to? :to_ary
       return other == self
@@ -323,7 +323,7 @@ def cycle(n = nil)
 
     return nil if empty?
 
-    if nil.equal? n
+    if Primitive.nil?(n)
       until empty?
         each { |x| yield x }
       end
@@ -380,7 +380,7 @@ def eql?(other)
       return result
     end
 
-    return true if equal? other
+    return true if Primitive.object_equal(self, other)
     return false unless Primitive.object_kind_of?(other, Array)
     return false if size != other.size
 
@@ -507,7 +507,7 @@ def flatten!(level = -1)
     level = Primitive.rb_num2int level
     return nil if level == 0
 
-    out = self.class.allocate # new_reserved size
+    out = Primitive.object_class(self).allocate # new_reserved size
     if Primitive.array_flatten_helper(self, out, level)
       Primitive.steal_array_storage(self, out)
       return self
@@ -1285,7 +1285,7 @@ def to_h
     each_with_index do |elem, i|
       elem = yield(elem) if block_given?
       unless elem.respond_to?(:to_ary)
-        raise TypeError, "wrong element type #{elem.class} at #{i} (expected array)"
+        raise TypeError, "wrong element type #{Primitive.object_class(elem)} at #{i} (expected array)"
       end
 
       ary = elem.to_ary
@@ -1350,7 +1350,7 @@ def values_at(*args)
 
   # Synchronize with Enumerator#zip and Enumerable#zip
   def zip(*others)
-    if !block_given? and others.size == 1 and Array === others[0]
+    if !block_given? and others.size == 1 and Primitive.object_kind_of?(others[0], Array)
       return Primitive.array_zip self, others[0]
     end
 
@@ -1364,7 +1364,7 @@ def zip(*others)
       elsif Primitive.object_respond_to?(other, :each, false)
         other.to_enum(:each)
       else
-        raise TypeError, "wrong argument type #{other.class} (must respond to :each)"
+        raise TypeError, "wrong argument type #{Primitive.object_class(other)} (must respond to :each)"
       end
     end
 

src/main/ruby/truffleruby/core/comparable.rb

@@ -28,7 +28,7 @@
 
 module Comparable
   def ==(other)
-    return true if equal?(other)
+    return true if Primitive.object_equal(self, other)
 
     return false if Truffle::ThreadOperations.detect_pair_recursion(self, other) do
       unless comp = (self <=> other)
@@ -82,7 +82,7 @@ def between?(min, max)
   def clamp(min, max = undefined)
     if Primitive.undefined?(max)
       range = min
-      raise TypeError, "wrong argument type #{range.class} (expected Range)" unless Primitive.object_kind_of?(range, Range)
+      raise TypeError, "wrong argument type #{Primitive.object_class(range)} (expected Range)" unless Primitive.object_kind_of?(range, Range)
       raise ArgumentError, 'cannot clamp with an exclusive range' if range.exclude_end?
       min, max = range.begin, range.end
     end

src/main/ruby/truffleruby/core/complex.rb

@@ -199,8 +199,8 @@ def ==(other)
 
   def eql?(other)
     Primitive.object_kind_of?(other, Complex) and
-    imag.class == other.imag.class and
-    real.class == other.real.class and
+    Primitive.object_class(imag) == Primitive.object_class(other.imag) and
+    Primitive.object_class(real) == Primitive.object_class(other.real) and
     self == other
   end
 
@@ -210,7 +210,7 @@ def coerce(other)
     elsif Primitive.object_kind_of?(other, Complex)
       [other, self]
     else
-      raise TypeError, "#{other.class} can't be coerced into Complex"
+      raise TypeError, "#{Primitive.object_class(other)} can't be coerced into Complex"
     end
   end
 
@@ -268,7 +268,7 @@ def rationalize(eps = nil)
   def to_s
     result = real.to_s
 
-    if imag < 0 || imag.equal?(-0.0)
+    if imag < 0 || Primitive.object_equal(imag, -0.0)
       result << '-'
     else
       result << '+'
@@ -305,7 +305,7 @@ def inspect
   end
 
   def fdiv(other)
-    raise TypeError, "#{other.class} can't be coerced into Complex" unless Primitive.object_kind_of?(other, Numeric)
+    raise TypeError, "#{Primitive.object_class(other)} can't be coerced into Complex" unless Primitive.object_kind_of?(other, Numeric)
 
     # FIXME
     self / other

src/main/ruby/truffleruby/core/dir.rb

@@ -141,7 +141,7 @@ def each_child
   end
 
   def inspect
-    "#<#{self.class}:#{@path}>"
+    "#<#{Primitive.object_class(self)}:#{@path}>"
   end
 
   class << self

src/main/ruby/truffleruby/core/dir_glob.rb

@@ -458,7 +458,7 @@ def self.single_compile(glob, flags = 0)
     end
 
     def self.run(node, all_matches, glob_base_dir, flags = 0)
-      if ConstantEntry === node
+      if Primitive.object_kind_of?(node, ConstantEntry)
         node.process_directory all_matches, nil, nil, glob_base_dir
       else
         matches = []

src/main/ruby/truffleruby/core/enumerable.rb

@@ -319,7 +319,7 @@ def to_h(*arg)
     each_with_index(*arg) do |elem, i|
       elem = yield(elem) if block_given?
       unless elem.respond_to?(:to_ary)
-        raise TypeError, "wrong element type #{elem.class} at #{i} (expected array)"
+        raise TypeError, "wrong element type #{Primitive.object_class(elem)} at #{i} (expected array)"
       end
 
       ary = elem.to_ary
@@ -342,7 +342,7 @@ def zip(*enums)
       elsif Primitive.object_respond_to?(enum, :each, false)
         enum.to_enum(:each)
       else
-        raise TypeError, "wrong argument type #{enum.class} (must respond to :each)"
+        raise TypeError, "wrong argument type #{Primitive.object_class(enum)} (must respond to :each)"
       end
     end
 
@@ -376,7 +376,7 @@ def zip(*enums)
   def each_with_index(*args, &block)
     return to_enum(:each_with_index, *args) { enumerator_size } unless block_given?
 
-    if Array === self
+    if Primitive.object_kind_of?(self, Array)
       Primitive.array_each_with_index(self, block)
     else
       idx = 0
@@ -798,7 +798,7 @@ def min_max(relative)
       else
         comp = block_given? ? yield(o, chosen) : o <=> chosen
         unless comp
-          raise ArgumentError, "comparison of #{o.class} with #{chosen} failed"
+          raise ArgumentError, "comparison of #{Primitive.object_class(o)} with #{chosen} failed"
         end
 
         if (Comparable.compare_int(comp) <=> 0) == relative

src/main/ruby/truffleruby/core/enumerator.rb

@@ -70,11 +70,11 @@ class Enumerator
   end
 
   def inspect
-    return "#<#{self.class}: uninitialized>" if @object.nil? && @iter.nil?
+    return "#<#{Primitive.object_class(self)}: uninitialized>" if Primitive.nil?(@object) && Primitive.nil?(@iter)
 
     args = @kwargs.empty? ? @args : [*@args, @kwargs]
     args = args.empty? ? '' : "(#{args.map(&:inspect).join(', ')})"
-    "#<#{self.class}: #{@object.inspect}:#{@iter}#{args}>"
+    "#<#{Primitive.object_class(self)}: #{@object.inspect}:#{@iter}#{args}>"
   end
 
   def each(*args, **kwargs, &block)
@@ -222,7 +222,7 @@ def self.produce(initial = nil)
     # Taken from https://github.com/zverok/enumerator_generate
     raise ArgumentError, 'No block given' unless block_given?
     Enumerator.new(Float::INFINITY) do |y|
-      val = initial == nil ? yield() : initial
+      val = Primitive.nil?(initial) ? yield() : initial
 
       loop do
         y << val
@@ -538,7 +538,7 @@ def zip(*lists)
         elsif Primitive.object_respond_to?(list, :each, false)
           list.to_enum :each
         else
-          raise TypeError, "wrong argument type #{list.class} (must respond to :each)"
+          raise TypeError, "wrong argument type #{Primitive.object_class(list)} (must respond to :each)"
         end
       end
 
@@ -795,8 +795,8 @@ def rewind
   end
 
   def inspect
-    return "#<#{self.class.name}: ...>" if Truffle::ThreadOperations.detect_recursion(self) do
-      return "#<#{self.class.name}: #{@enums || "uninitialized"}>"
+    return "#<#{Primitive.object_class(self).name}: ...>" if Truffle::ThreadOperations.detect_recursion(self) do
+      return "#<#{Primitive.object_class(self).name}: #{@enums || "uninitialized"}>"
     end
   end
 end

src/main/ruby/truffleruby/core/env.rb

@@ -243,7 +243,7 @@ def rehash
   end
 
   def replace(other)
-    return self if equal?(other)
+    return self if Primitive.object_equal(self, other)
     other = Truffle::Type.rb_convert_type(other, Hash, :to_hash)
     keys_to_delete = keys
     other.each do |k, v|
@@ -281,7 +281,7 @@ def to_h
     each_pair do |*elem|
       elem = yield(elem)
       unless elem.respond_to?(:to_ary)
-        raise TypeError, "wrong element type #{elem.class} (expected array)"
+        raise TypeError, "wrong element type #{Primitive.object_class(elem)} (expected array)"
       end
 
       ary = elem.to_ary
@@ -295,7 +295,7 @@ def to_h
   end
 
   def update(other)
-    return self if equal?(other)
+    return self if Primitive.object_equal(self, other)
     other = Truffle::Type.rb_convert_type(other, Hash, :to_hash)
     if block_given?
       other.each do |k, v|