Autocorrect and replace comparisons with true/false by Primitive.true? and Primitive.false?

Author: andrykonchin

lib/truffle/socket/truffle.rb

@@ -333,7 +333,7 @@ def self.convert_reverse_lookup(socket = nil, reverse_lookup = nil)
       elsif reverse_lookup == :numeric
         reverse_lookup = false
 
-      elsif reverse_lookup != true and reverse_lookup != false
+      elsif !Primitive.true?(reverse_lookup) and !Primitive.false?(reverse_lookup)
         raise ArgumentError,
           "invalid reverse_lookup flag: #{reverse_lookup.inspect}"
       end

lib/truffle/truffle/cext.rb

@@ -633,7 +633,7 @@ def rb_filesystem_encoding
 
   def rb_to_encoding_index(enc)
     enc = Truffle::Type.coerce_to_encoding(enc)
-    return -1 if enc == false
+    return -1 if Primitive.false?(enc)
     rb_enc_to_index(enc)
   end
 
@@ -1186,7 +1186,7 @@ def rb_class_new(superclass)
 
   def rb_define_class_under(mod, name, superclass)
     # nil is TypeError (checked below), false is ArgumentError
-    if Primitive.equal?(false, superclass)
+    if Primitive.false?(superclass)
       raise ArgumentError, "no super class for `#{name}'"
     end
 

src/main/ruby/truffleruby/core/dir.rb

@@ -266,7 +266,7 @@ def glob(pattern, flags = 0, base: nil, sort: true, &block)
 
       matches = []
       index = 0
-      flags |= File::FNM_GLOB_NOSORT if Primitive.equal?(sort, false)
+      flags |= File::FNM_GLOB_NOSORT if Primitive.false?(sort)
 
       normalized_base = if Primitive.nil? base
                           nil

src/main/ruby/truffleruby/core/io.rb

@@ -1461,7 +1461,7 @@ def fcntl(command, arg = 0)
 
     if !arg
       arg = 0
-    elsif arg == true
+    elsif Primitive.true?(arg)
       arg = 1
     elsif Primitive.is_a?(arg, String)
       raise NotImplementedError, 'cannot handle String'
@@ -1491,7 +1491,7 @@ def ioctl(command, arg = 0)
 
     if !arg
       real_arg = 0
-    elsif arg == true
+    elsif Primitive.true?(arg)
       real_arg = 1
     elsif Primitive.is_a?(arg, String)
       # This could be faster.

src/main/ruby/truffleruby/core/kernel.rb

@@ -54,7 +54,7 @@ def Complex(real, imag = undefined, exception: true)
   module_function :Complex
 
   def Float(obj, exception: true)
-    raise_exception = !Primitive.equal?(exception, false)
+    raise_exception = !Primitive.false?(exception)
     obj = Truffle::Interop.unbox_if_needed(obj)
 
     case obj
@@ -104,7 +104,7 @@ def Integer(obj, base = 0, exception: true)
     obj = Truffle::Interop.unbox_if_needed(obj)
     converted_base = Truffle::Type.rb_check_to_integer(base, :to_int)
     base = Primitive.nil?(converted_base) ? 0 : converted_base
-    raise_exception = !Primitive.equal?(exception, false)
+    raise_exception = !Primitive.false?(exception)
 
     if Primitive.is_a?(obj, String)
       Primitive.string_to_inum(obj, base, true, raise_exception)

src/main/ruby/truffleruby/core/numeric.rb

@@ -30,7 +30,7 @@ class Numeric
   include Comparable
 
   def clone(freeze: nil)
-    if Primitive.equal?(freeze, false)
+    if Primitive.false?(freeze)
       raise ArgumentError, "can't unfreeze #{Primitive.class(self).name}"
     end
     self

src/main/ruby/truffleruby/core/pre.rb

@@ -58,7 +58,7 @@ def include(mod)
       result = Primitive.unbound_method_ruby2_keywords(method)
       if Primitive.nil?(result)
         warn "Skipping set of ruby2_keywords flag for #{name} (method accepts keywords or method does not accept argument splat)", uplevel: 1
-      elsif result == false
+      elsif Primitive.false?(result)
         warn "Skipping set of ruby2_keywords flag for #{name} (unknown reason)", uplevel: 1
       end
     end
@@ -71,7 +71,7 @@ def ruby2_keywords
     result = Primitive.proc_ruby2_keywords(self)
     if Primitive.nil?(result)
       warn 'Skipping set of ruby2_keywords flag for proc (proc accepts keywords or proc does not accept argument splat)', uplevel: 1
-    elsif result == false
+    elsif Primitive.false?(result)
       warn 'Skipping set of ruby2_keywords flag for proc (unknown reason)', uplevel: 1
     end
     self

src/main/ruby/truffleruby/core/range.rb

@@ -112,7 +112,7 @@ def bsearch(&block)
     return nil if max < min || max == min && self.exclude_end? #-inf.prev_float == -inf!
     if max == min
       result = yield max
-      return result == true || result == 0 ? max : nil
+      return Primitive.true?(result) || result == 0 ? max : nil
     end
 
     # max == -Float::INFINITY will already be covered by the comparisons above.
@@ -136,7 +136,7 @@ def bsearch(&block)
     if min == -Float::INFINITY
       result = yield min
       # Find-minimum mode: It's not going to get any smaller than negative infinity.
-      return min if result == true || result == 0
+      return min if Primitive.true?(result) || result == 0
       return nil if Primitive.is_a?(result, Numeric) && result < 0
       min = normalized_begin = -Float::MAX # guaranteed to be <= max
     end
@@ -175,12 +175,12 @@ def bsearch(&block)
       # max is untested only if it's the end of the range.
       # It can only change the result of the search if we haven't found an admissible value yet (+ infinity edge case).
       result = yield max
-      return max if result == true || result == 0
+      return max if Primitive.true?(result) || result == 0
     elsif mid == max && min == normalized_begin
       # min is untested only if it's the begin of the range.
       result = yield min
       # Favor smallest value in case we're in find-minimum mode.
-      return min if result == true || result == 0
+      return min if Primitive.true?(result) || result == 0
     end
 
     last_admissible

src/main/ruby/truffleruby/core/truffle/complex_operations.rb

@@ -11,7 +11,7 @@
 module Truffle
   module ComplexOperations
     def self.convert_not_real_arguments(real, imag, exception)
-      raise_exception = !Primitive.equal?(exception, false)
+      raise_exception = !Primitive.false?(exception)
       if Primitive.nil?(real) || Primitive.nil?(imag)
         return nil unless raise_exception
         raise TypeError, "can't convert nil into Complex"

src/main/ruby/truffleruby/core/truffle/exception_operations.rb

@@ -130,8 +130,8 @@ def self.full_message(exception, highlight, order)
       highlight = if Primitive.nil?(highlight)
                     Exception.to_tty?
                   else
-                    raise ArgumentError, "expected true of false as highlight: #{highlight}" unless Primitive.equal?(highlight, true) || Primitive.equal?(highlight, false)
-                    !Primitive.equal?(highlight, false)
+                    raise ArgumentError, "expected true of false as highlight: #{highlight}" unless Primitive.true?(highlight) || Primitive.false?(highlight)
+                    !Primitive.false?(highlight)
                   end
 
       raise ArgumentError, "expected :top or :bottom as order: #{order}" unless Primitive.equal?(order, :top) || Primitive.equal?(order, :bottom)