$LOAD_PATH.resolve_feature_path does not raise LoadError when feature isn't found

Author: andrykonchin

CHANGELOG.md

@@ -84,6 +84,7 @@ Compatibility:
 * `Fiber.current` and `Fiber#transfer` are available without `require 'fiber'` like in CRuby 3.1 (#2733, @eregon).
 * Add `freeze` keyword argument to `Marshal.load` (#2733, @andrykonchin).
 * Add `Integer.try_convert` (#2733, @moste00, @eregon).
+* Update `$LOAD_PATH.resolve_feature_path` to return `nil` instead of raising `LoadError` when feature isn't found (#2733, @andrykonchin).
 
 Performance:
 

spec/tags/language/predefined_tags.txt

@@ -6,4 +6,3 @@ slow:The predefined global constant ARGV contains Strings encoded in locale Enco
 slow:Global variable $0 is the path given as the main script and the same as __FILE__
 slow:Global variable $? is thread-local
 slow:Global variable $0 actually sets the program name
-fails:$LOAD_PATH.resolve_feature_path return nil if feature cannot be found

src/main/ruby/truffleruby/core/truffle/kernel_operations.rb

@@ -55,12 +55,10 @@ def self.define_read_only_global(name, getter)
 
     def $LOAD_PATH.resolve_feature_path(file_name)
       path = Truffle::Type.coerce_to_path(file_name)
-      _status, path, ext = Truffle::FeatureLoader.find_feature_or_file(path, false)
-      if Primitive.nil?(ext)
-        raise Truffle::KernelOperations.load_error(file_name)
-      else
-        [ext, path]
-      end
+      status, path, ext = Truffle::FeatureLoader.find_feature_or_file(path, false)
+
+      return nil if status == :not_found
+      [ext, path]
     end
 
     # The runtime needs to access these values, so we want them to be set in the variable storage.

test/mri/excludes/TestRequire.rb

@@ -17,4 +17,3 @@
 exclude :test_require_nonascii_path_shift_jis, "needs investigation"
 exclude :test_relative_symlink_realpath, "bug17885 [ruby-core:104010]."
 exclude :test_load_into_module, "<[:b]> expected but was"
-exclude :test_resolve_feature_path_with_missing_feature, "LoadError: cannot load such file -- superkalifragilisticoespialidoso"