SingleByteOptimizableNode supports DSL inlining

Author: horakivo

src/main/java/org/truffleruby/core/regexp/MatchDataNodes.java

@@ -504,7 +504,7 @@ protected Object begin(RubyMatchData matchData, int index,
             var encoding = strings.getEncoding(matchData.source);
 
             if (multiByteCharacterProfile.profile(this,
-                    !singleByteOptimizableNode.execute(matchDataSource, encoding))) {
+                    !singleByteOptimizableNode.execute(this, matchDataSource, encoding))) {
                 return getCharOffsets(matchData, matchDataSource, encoding).beg[index];
             }
 
@@ -590,7 +590,7 @@ protected Object end(RubyMatchData matchData, int index,
             var encoding = strings.getEncoding(matchData.source);
 
             if (multiByteCharacterProfile.profile(this,
-                    !singleByteOptimizableNode.execute(matchDataSource, encoding))) {
+                    !singleByteOptimizableNode.execute(this, matchDataSource, encoding))) {
                 return getCharOffsets(matchData, matchDataSource, encoding).end[index];
             }
 

src/main/java/org/truffleruby/core/string/StringGuards.java

@@ -11,6 +11,7 @@
 package org.truffleruby.core.string;
 
 import com.oracle.truffle.api.CompilerAsserts;
+import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.strings.AbstractTruffleString;
 import com.oracle.truffle.api.strings.TruffleString;
 import org.jcodings.Config;
@@ -51,9 +52,9 @@ public static boolean isBrokenCodeRange(AbstractTruffleString string, TruffleStr
         return codeRangeNode.execute(string, encoding) == BROKEN;
     }
 
-    public static boolean isSingleByteOptimizable(AbstractTruffleString tString, RubyEncoding encoding,
+    public static boolean isSingleByteOptimizable(Node node, AbstractTruffleString tString, RubyEncoding encoding,
             SingleByteOptimizableNode singleByteOptimizableNode) {
-        return singleByteOptimizableNode.execute(tString, encoding);
+        return singleByteOptimizableNode.execute(node, tString, encoding);
     }
 
     public static boolean isAsciiCompatible(RubyEncoding encoding) {
@@ -70,15 +71,15 @@ private static boolean isAsciiCompatMapping(int caseMappingOptions) {
     }
 
     /** The mapping is ASCII-only or effectively ASCII-only based on the string properties. */
-    private static boolean isAsciiCodePointsMapping(AbstractTruffleString tstring, RubyEncoding encoding,
+    private static boolean isAsciiCodePointsMapping(Node node, AbstractTruffleString tstring, RubyEncoding encoding,
             int caseMappingOptions, SingleByteOptimizableNode singleByteOptimizableNode) {
-        return isSingleByteOptimizable(tstring, encoding, singleByteOptimizableNode)
+        return isSingleByteOptimizable(node, tstring, encoding, singleByteOptimizableNode)
                 ? isAsciiCompatMapping(caseMappingOptions)
                 : caseMappingOptions == Config.CASE_ASCII_ONLY && isAsciiCompatible(encoding);
     }
 
-    public static boolean isComplexCaseMapping(AbstractTruffleString tstring, RubyEncoding encoding,
+    public static boolean isComplexCaseMapping(Node node, AbstractTruffleString tstring, RubyEncoding encoding,
             int caseMappingOptions, SingleByteOptimizableNode singleByteOptimizableNode) {
-        return !isAsciiCodePointsMapping(tstring, encoding, caseMappingOptions, singleByteOptimizableNode);
+        return !isAsciiCodePointsMapping(node, tstring, encoding, caseMappingOptions, singleByteOptimizableNode);
     }
 }

src/main/java/org/truffleruby/core/string/StringHelperNodes.java

@@ -63,20 +63,17 @@ static Object trTransHelper(Node node, EncodingNodes.CheckEncodingNode checkEnco
         return self;
     }
 
+    @GenerateCached(false)
+    @GenerateInline
     public abstract static class SingleByteOptimizableNode extends RubyBaseNode {
 
-        @NeverDefault
-        public static SingleByteOptimizableNode create() {
-            return StringHelperNodesFactory.SingleByteOptimizableNodeGen.create();
-        }
-
-        public abstract boolean execute(AbstractTruffleString string, RubyEncoding encoding);
+        public abstract boolean execute(Node node, AbstractTruffleString string, RubyEncoding encoding);
 
         @Specialization
-        protected boolean isSingleByteOptimizable(AbstractTruffleString string, RubyEncoding encoding,
+        protected static boolean isSingleByteOptimizable(Node node, AbstractTruffleString string, RubyEncoding encoding,
                 @Cached InlinedConditionProfile asciiOnlyProfile,
-                @Cached TruffleString.GetByteCodeRangeNode getByteCodeRangeNode) {
-            if (asciiOnlyProfile.profile(this, StringGuards.is7Bit(string, encoding, getByteCodeRangeNode))) {
+                @Cached(inline = false) TruffleString.GetByteCodeRangeNode getByteCodeRangeNode) {
+            if (asciiOnlyProfile.profile(node, StringGuards.is7Bit(string, encoding, getByteCodeRangeNode))) {
                 return true;
             } else {
                 return encoding.isSingleByte;