[GR-44053] HostException#getExceptionStackTrace works now, remove workarounds

PullRequest: truffleruby/3715

Author: eregon

spec/truffle/interop/polyglot/foreign_exception_spec.rb

@@ -29,12 +29,29 @@
   it "supports #full_message" do
     -> {
       raise @foreign
-    }.should raise_error(Polyglot::ForeignException) {
-      full_message = @foreign.full_message(highlight: false, order: :top).lines
+    }.should raise_error(Polyglot::ForeignException) { |e|
+      full_message = e.full_message(highlight: false, order: :top).lines
       full_message[0].should == "#{__FILE__}:#{__LINE__-3}:in `Kernel#raise': exception message (Polyglot::ForeignException)\n"
     }
   end
 
+  guard -> { !TruffleRuby.native? } do
+    it "supports #full_message for a host exception" do
+      integer = Java.type("java.lang.Integer")
+      -> {
+        integer.parseInt("abc")
+      }.should raise_error(Polyglot::ForeignException) { |e|
+        full_message = e.full_message(highlight: false, order: :top).gsub(/:\d+:/, ':LINE:')
+        full_message.should.start_with?(<<~EXCEPTION)
+        NumberFormatException.java:LINE:in `forInputString': For input string: "abc" (Polyglot::ForeignException: java.lang.NumberFormatException)
+        \tfrom Integer.java:LINE:in `parseInt'
+        \tfrom Integer.java:LINE:in `parseInt'
+        \tfrom #{__FILE__ }:LINE:in `block (4 levels) in <top (required)>'
+        EXCEPTION
+      }
+    end
+  end
+
   it "supports rescue Polyglot::ForeignException" do
     begin
       raise @foreign

spec/truffle/interop/polyglot/inner_context_spec.rb

@@ -60,7 +60,7 @@
 
     -> { context.eval('ruby', '42') }.should raise_error(RuntimeError, 'This Polyglot::InnerContext is closed')
 
-    # obj.object_id # throws a host exception, but those currently cannot be caught due to the workaround for GR-22071
+    # obj.object_id # throws a IllegalStateException which cannot be caught: GR-45031
   end
 
   it "raises ArgumentError for an unknown language" do

src/launcher/java/org/truffleruby/launcher/RubyLauncher.java

@@ -309,12 +309,8 @@ private int runContext(Context.Builder builder, CommandLineOptions config) {
             Metrics.printTime("after-run");
             return exitCode;
         } catch (PolyglotException e) {
-            if (e.isHostException()) { // GR-22071
-                getError().println("truffleruby: a host exception reached the top level:");
-            } else {
-                getError().println(
-                        "truffleruby: an exception escaped out of the interpreter - this is an implementation bug");
-            }
+            getError().println(
+                    "truffleruby: an exception escaped out of the interpreter - this is an implementation bug");
             e.printStackTrace();
             return 1;
         }

src/main/java/org/truffleruby/language/backtrace/BacktraceFormatter.java

@@ -377,11 +377,6 @@ public static String formatJavaThrowableMessage(Throwable t) {
 
     @TruffleBoundary
     public static void printInternalError(RubyContext context, Throwable throwable, String from) {
-        if (context.getEnv().isHostException(throwable)) {
-            // rethrow host exceptions to get the interleaved host and guest stacktrace of PolyglotException
-            throw ExceptionOperations.rethrow(throwable);
-        }
-
         final PrintStream stream = context.getEnvErrStream();
         final BacktraceFormatter formatter = context.getDefaultBacktraceFormatter();
         stream.println();