Use RARRAY_PTR() in util_spec_rb_scan_args()

* That way this does not force `argv` to be native and on the stack.
* Also more representative of how (VALUE *argv) is set for
  `rb_define_method(..., -1)` functions, at least on TruffleRuby
  (i.e., it uses RARRAY_PTR()).

Author: eregon

spec/nativeconversion.mspec

@@ -1,4 +1,3 @@
-
 class NativeHandleChecker
   EXPECTED_FAILURES = {
     "C-API Debug function rb_debug_inspector_open creates a debug context and calls the given callback" => 2,
@@ -26,9 +25,6 @@ class NativeHandleChecker
     "C-API String function rb_string_value_cstr returns a non-null pointer for a UTF-16 string" => 1,
     "C-API String function rb_string_value_cstr raises an error if a string contains a null" => 1,
     "C-API String function rb_string_value_cstr raises an error if a UTF-16 string contains a null" => 1,
-    "C-API Util function rb_scan_args assigns Hash arguments" => 1,
-    "C-API Util function rb_scan_args assigns required and Hash arguments" => 1,
-    "C-API Util function rb_scan_args assigns required, optional, splat, post-splat, Hash and block arguments" => 1,
     "C-API Util function rb_get_kwargs extracts required arguments in the order requested" => 2,
     "C-API Util function rb_get_kwargs extracts required and optional arguments in the order requested" => 1,
     "C-API Util function rb_get_kwargs raises an error if a required argument is not in the hash" => 1,
@@ -50,7 +46,11 @@ class NativeHandleChecker
   end
 
   def passed(state, example)
-    (Truffle::Debug.cexts_to_native_count - @start_count).should == (EXPECTED_FAILURES[state.description] || 0)
+    expected = EXPECTED_FAILURES[state.description] || 0
+    actual = Truffle::Debug.cexts_to_native_count - @start_count
+    unless actual == expected
+      raise SpecExpectationNotMetError, "Expected #{expected} conversions to native but was #{actual}"
+    end
   end
 end
 

spec/ruby/optional/capi/ext/util_spec.c

@@ -7,15 +7,18 @@ extern "C" {
 #endif
 
 VALUE util_spec_rb_scan_args(VALUE self, VALUE argv, VALUE fmt, VALUE expected, VALUE acc) {
-  int i, result, argc = (int)RARRAY_LEN(argv);
-  VALUE args[6], failed, a1, a2, a3, a4, a5, a6;
-
-  failed = rb_intern("failed");
-  a1 = a2 = a3 = a4 = a5 = a6 = failed;
-
-  for(i = 0; i < argc; i++) {
-    args[i] = rb_ary_entry(argv, i);
-  }
+  int result, argc;
+  VALUE a1, a2, a3, a4, a5, a6;
+
+  argc = (int) RARRAY_LEN(argv);
+  VALUE* args = RARRAY_PTR(argv);
+  /* the line above can be replaced with this for Ruby implementations which do not support RARRAY_PTR() yet
+    VALUE args[6];
+    for(int i = 0; i < argc; i++) {
+      args[i] = rb_ary_entry(argv, i);
+    } */
+
+  a1 = a2 = a3 = a4 = a5 = a6 = INT2FIX(-1);
 
 #ifdef RB_SCAN_ARGS_KEYWORDS
   if (*RSTRING_PTR(fmt) == 'k') {

spec/ruby/optional/capi/util_spec.rb

@@ -15,8 +15,9 @@
     end
 
     it "assigns the required arguments scanned" do
-      @o.rb_scan_args([1, 2], "2", 2, @acc).should == 2
-      ScratchPad.recorded.should == [1, 2]
+      obj = Object.new
+      @o.rb_scan_args([obj, 2], "2", 2, @acc).should == 2
+      ScratchPad.recorded.should == [obj, 2]
     end
 
     it "raises an ArgumentError if there are insufficient arguments" do