[GR-36892] Ensure cext initialisation objects are in separate handle blocks.

PullRequest: truffleruby/3168

Author: aardvark179

CHANGELOG.md

@@ -34,6 +34,7 @@ Performance:
 * Switch to `Arrays.mismatch()` in string comparison for better performance (@aardvark179).
 * Removed extra array allocations for method calls in the interpreter to improve warmup performance (@aardvark179).
 * Optimize `Dir[]` by sorting entries as they are found and grouping syscalls (#2092, @aardvark179).
+* Reduce memory footprint by tracking `VALUE`s created during C extension init separately (@aardvark179).
 
 Changes:
 

lib/cext/ABI_version.txt

@@ -1 +1 @@
-10
+11

src/main/c/cext/ruby.c

@@ -41,7 +41,9 @@ void rb_tr_init(void *ruby_cext) {
   rb_tr_longwrap = polyglot_invoke(rb_tr_cext, "rb_tr_wrap_function");
   rb_tr_force_native = polyglot_invoke(rb_tr_cext, "rb_tr_force_native_function");
 
+  polyglot_invoke(rb_tr_cext, "cext_start_new_handle_block");
   rb_tr_init_exception();
   rb_tr_init_global_constants();
   rb_argv0 = rb_gv_get("$0");
+  polyglot_invoke(rb_tr_cext, "cext_start_new_handle_block");
 }

src/main/java/org/truffleruby/cext/CExtNodes.java

@@ -252,6 +252,15 @@ protected Object publicSendWithoutLock(
         }
     }
 
+    @CoreMethod(names = "cext_start_new_handle_block", onSingleton = true)
+    public abstract static class StartNewHandleBlockNode extends CoreMethodArrayArgumentsNode {
+        @Specialization
+        protected boolean isCExtLockOwned() {
+            ValueWrapperManager.allocateNewBlock(getContext(), getLanguage());
+            return true;
+        }
+    }
+
     @CoreMethod(names = "cext_lock_owned?", onSingleton = true)
     public abstract static class IsCExtLockOwnedNode extends CoreMethodArrayArgumentsNode {
         @Specialization

src/main/java/org/truffleruby/cext/ValueWrapperManager.java

@@ -346,6 +346,19 @@ public static AllocateHandleNode create() {
         }
     }
 
+    public static HandleBlock allocateNewBlock(RubyContext context, RubyLanguage language) {
+        HandleBlockHolder holder = getBlockHolder(context, language);
+        HandleBlock block = holder.handleBlock;
+
+        if (block != null) {
+            context.getMarkingService().queueForMarking(block);
+        }
+        block = (holder.handleBlock = new HandleBlock(context, language.handleBlockAllocator));
+        context.getValueWrapperManager().addToBlockMap(block, context, language);
+
+        return block;
+    }
+
     public static boolean isTaggedLong(long handle) {
         return (handle & LONG_TAG) == LONG_TAG;
     }

src/main/java/org/truffleruby/language/loader/RequireNode.java

@@ -23,6 +23,7 @@
 import com.oracle.truffle.api.source.Source;
 import org.graalvm.collections.Pair;
 import org.truffleruby.RubyLanguage;
+import org.truffleruby.cext.ValueWrapperManager;
 import org.truffleruby.core.array.ArrayUtils;
 import org.truffleruby.core.cast.BooleanCastNode;
 import org.truffleruby.core.rope.Rope;
@@ -282,13 +283,15 @@ private void requireCExtension(String feature, String expandedPath, Node current
 
         requireMetric("before-execute-" + feature);
         try {
+            ValueWrapperManager.allocateNewBlock(getContext(), getLanguage());
             InteropNodes
                     .execute(
                             initFunction,
                             ArrayUtils.EMPTY_ARRAY,
                             initFunctionInteropLibrary,
                             TranslateInteropExceptionNode.getUncached());
         } finally {
+            ValueWrapperManager.allocateNewBlock(getContext(), getLanguage());
             requireMetric("after-execute-" + feature);
         }
     }