[GR-17457] Use the NATIVE_PLATFORM option consistently over isNativeAccessAllowed()

PullRequest: truffleruby/3635

Author: eregon

src/main/.checkstyle_checks.xml

@@ -255,6 +255,10 @@
       <property name="format" value='serialVersionUID'/>
       <property name="message" value='Use @SuppressWarnings("serial") instead.'/>
     </module>
+    <module name="RegexpSinglelineJava">
+      <property name="format" value='isNativeAccessAllowed\(\)'/>
+      <property name="message" value='Use context.getOptions().NATIVE_PLATFORM instead.'/>
+    </module>
     <module name="IllegalType">
       <!-- Use PrintStream instead of PrintWriter, PrintWriter does not consistently flush, even when writing \n.-->
       <property name="illegalClassNames" value="TruffleObject,DynamicObject,PrintWriter"/>

src/main/java/org/truffleruby/core/thread/ThreadManager.java

@@ -408,7 +408,7 @@ public void startForeignThread(RubyThread rubyThread, Thread javaThread) {
 
     public void start(RubyThread thread, Thread javaThread) {
         thread.thread = javaThread;
-        thread.ioBuffer = context.getEnv().isNativeAccessAllowed() ? Pointer.getNullBuffer(context) : null;
+        thread.ioBuffer = context.getOptions().NATIVE_PLATFORM ? Pointer.getNullBuffer(context) : null;
         registerThread(thread);
 
         final RubyFiber rootFiber = thread.getRootFiber();

src/main/java/org/truffleruby/core/time/GetTimeZoneNode.java

@@ -71,7 +71,7 @@ protected TimeZoneAndName getTimeZone(
 
     @NeverDefault
     protected Object getTZ() {
-        if (getContext().getEnv().isNativeAccessAllowed()) {
+        if (getContext().getOptions().NATIVE_PLATFORM) {
             return lookupEnvNode.call(coreLibrary().getENV(), "[]", FrozenStrings.TZ);
         } else {
             return nil;

src/main/java/org/truffleruby/extra/ffi/Pointer.java

@@ -39,7 +39,7 @@ public final class Pointer implements AutoCloseable, TruffleObject {
     public static final Pointer[] EMPTY_ARRAY = new Pointer[0];
 
     public static void checkNativeAccess(RubyContext context) {
-        if (!context.getEnv().isNativeAccessAllowed()) {
+        if (!context.getOptions().NATIVE_PLATFORM) {
             CompilerDirectives.transferToInterpreterAndInvalidate();
             throw new RaiseException(
                     context,

src/main/java/org/truffleruby/options/LanguageOptions.java

@@ -20,6 +20,7 @@
 import com.oracle.truffle.api.TruffleLanguage.Env;
 
 // @formatter:off
+// Checkstyle: stop
 public class LanguageOptions {
 
     /** --no-home-provided=false */
@@ -732,4 +733,5 @@ public static boolean areOptionsCompatibleOrLog(TruffleLogger logger, LanguageOp
         return true;
     }
 }
+// Checkstyle: resume
 // @formatter:on

src/main/java/org/truffleruby/options/Options.java

@@ -22,6 +22,7 @@
 import com.oracle.truffle.api.TruffleLanguage.Env;
 
 // @formatter:off
+// Checkstyle: stop
 public class Options {
 
     /** --load-paths=StringArrayOptionType.EMPTY_STRING_ARRAY */
@@ -491,4 +492,5 @@ public Object fromDescriptor(OptionDescriptor descriptor) {
     }
 
 }
+// Checkstyle: resume
 // @formatter:on

tool/generate-options.rb

@@ -163,6 +163,7 @@ def parse_reference_defaults(default)
 import com.oracle.truffle.api.TruffleLanguage.Env;
 
 // @formatter:off
+// Checkstyle: stop
 public class <%= class_prefix %>Options {
 <% options.each do |o| %>
     /** --<%= o.name %>=<%= o.env_condition %><%= o.default %> */
@@ -209,6 +210,7 @@ def parse_reference_defaults(default)
     }
 <% end -%>
 }
+// Checkstyle: resume
 // @formatter:on
 JAVA