Address "useless neverDefault" warnings

Author: eregon

src/main/java/org/truffleruby/core/hash/library/PackedHashStoreLibrary.java

@@ -406,9 +406,8 @@ public abstract static class LookupPackedEntryNode extends RubyBaseNode {
         protected Object getConstantIndexPackedArray(
                 RubyHash hash, Object key, int hashed, PEBiFunction defaultValueNode,
                 @Cached ReferenceEqualNode refEqual,
-                @Cached(value = "isCompareByIdentity(hash)", neverDefault = false) boolean cachedByIdentity,
-                @Cached(value = "index(refEqual, hash, key, hashed, cachedByIdentity)",
-                        neverDefault = false) int cachedIndex) {
+                @Cached("isCompareByIdentity(hash)") boolean cachedByIdentity,
+                @Cached("index(refEqual, hash, key, hashed, cachedByIdentity)") int cachedIndex) {
 
             final Object[] store = (Object[]) hash.store;
             return getValue(store, cachedIndex);

src/main/java/org/truffleruby/core/kernel/TruffleKernelNodes.java

@@ -222,8 +222,8 @@ public static GetSpecialVariableStorage create() {
 
         @Specialization(guards = "frame.getFrameDescriptor() == descriptor", limit = "1")
         protected SpecialVariableStorage getFromKnownFrameDescriptor(Frame frame,
-                @Cached(value = "frame.getFrameDescriptor()", neverDefault = true) FrameDescriptor descriptor,
-                @Cached(value = "declarationDepth(frame)", neverDefault = false) int declarationFrameDepth) {
+                @Cached("frame.getFrameDescriptor()") FrameDescriptor descriptor,
+                @Cached("declarationDepth(frame)") int declarationFrameDepth) {
             Object variables;
             if (declarationFrameDepth == 0) {
                 variables = SpecialVariableStorage.get(frame);
@@ -347,8 +347,8 @@ public abstract static class ShareSpecialVariableStorage extends PrimitiveArrayA
 
         @Specialization(guards = "frame.getFrameDescriptor() == descriptor", limit = "1")
         protected Object shareSpecialVariable(VirtualFrame frame, SpecialVariableStorage storage,
-                @Cached(value = "frame.getFrameDescriptor()", neverDefault = true) FrameDescriptor descriptor,
-                @Cached(value = "declarationDepth(frame)", neverDefault = false) int declarationFrameDepth) {
+                @Cached("frame.getFrameDescriptor()") FrameDescriptor descriptor,
+                @Cached("declarationDepth(frame)") int declarationFrameDepth) {
             final Frame storageFrame = RubyArguments.getDeclarationFrame(frame, declarationFrameDepth);
             SpecialVariableStorage.set(storageFrame, storage);
             return nil;

src/main/java/org/truffleruby/language/arguments/ProfileArgumentNode.java

@@ -36,13 +36,13 @@ public abstract class ProfileArgumentNode extends RubyContextSourceNode {
 
     @Specialization(guards = "value == cachedValue", limit = "1")
     protected boolean cacheBoolean(boolean value,
-            @Cached(value = "value", neverDefault = false) boolean cachedValue) {
+            @Cached("value") boolean cachedValue) {
         return cachedValue;
     }
 
     @Specialization(guards = "value == cachedValue", limit = "1")
     protected int cacheInt(int value,
-            @Cached(value = "value", neverDefault = false) int cachedValue) {
+            @Cached("value") int cachedValue) {
         return cachedValue;
     }
 

src/main/java/org/truffleruby/language/globals/WriteSimpleGlobalVariableNode.java

@@ -43,7 +43,7 @@ public WriteSimpleGlobalVariableNode(String name) {
                     "getLanguage().getGlobalVariableNeverAliasedAssumption(index)" },
             limit = "1")
     protected Object writeTryToKeepConstant(Object value,
-            @Cached(value = "getLanguage().getGlobalVariableIndex(name)", neverDefault = false) int index,
+            @Cached("getLanguage().getGlobalVariableIndex(name)") int index,
             @Cached("getContext().getGlobalVariableStorage(index)") GlobalVariableStorage storage,
             @Cached("storage.getValue()") Object previousValue) {
         // NOTE: we still do the volatile write to get the proper memory barrier,

src/main/java/org/truffleruby/language/methods/CallForeignMethodNode.java

@@ -74,14 +74,14 @@ public abstract static class ForeignInvokeNode extends RubyBaseNode {
                 guards = { "name == cachedName", "!isOperatorMethod(cachedName)", "!isAssignmentMethod(cachedName)" },
                 limit = "1")
         protected Object invokeOrRead(Object receiver, String name, Object[] args,
-                @Cached(value = "name", neverDefault = true) String cachedName,
+                @Cached("name") String cachedName,
                 @Cached InvokeOrReadMemberNode invokeOrReadMemberNode) {
             return invokeOrReadMemberNode.execute(receiver, name, args);
         }
 
         @Specialization(guards = { "name == cachedName", "isOperatorMethod(cachedName)" }, limit = "1")
         protected Object operatorMethod(Object receiver, String name, Object[] args,
-                @Cached(value = "name", neverDefault = true) String cachedName,
+                @Cached("name") String cachedName,
                 @Cached ConvertForOperatorAndReDispatchNode operatorNode) {
             return operatorNode.execute(receiver, name, args);
         }