Reuse translateArgumentsAndBlock() in visitYieldNode()

* Removes duplication to handle the various call site argument variants.

Author: eregon

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -690,7 +690,7 @@ protected ArgumentsAndBlockTranslation translateArgumentsAndBlock(SourceIndexLen
             isSplatted = true;
             arguments = new ParseNode[]{ argsNode };
         } else {
-            throw new UnsupportedOperationException("Unknown argument node type: " + argsNode.getClass());
+            throw CompilerDirectives.shouldNotReachHere("Unknown argument node type: " + argsNode.getClass());
         }
 
         ArgumentsDescriptor keywordDescriptor = getKeywordArgumentsDescriptor(language, arguments);
@@ -3020,37 +3020,18 @@ public RubyNode visitXStrNode(XStrParseNode node) {
     @Override
     public RubyNode visitYieldNode(YieldParseNode node) {
         final ParseNode argsNode = node.getArgsNode();
-        boolean unsplat = false;
 
-        final ParseNode[] arguments;
-        if (argsNode == null) {
-            // No arguments
-            arguments = EMPTY_ARGUMENTS;
-        } else if (argsNode instanceof ArrayParseNode) {
-            // Multiple arguments
-            arguments = ((ArrayParseNode) argsNode).children();
-        } else if (argsNode instanceof SplatParseNode || argsNode instanceof ArgsCatParseNode ||
-                argsNode instanceof ArgsPushParseNode) {
-            unsplat = true;
-            arguments = new ParseNode[]{ argsNode };
-        } else {
-            arguments = new ParseNode[]{ node.getArgsNode() };
-        }
-
-        ArgumentsDescriptor keywordDescriptor = getKeywordArgumentsDescriptor(language, arguments);
+        final ArgumentsAndBlockTranslation argumentsAndBlock = translateArgumentsAndBlock(
+                node.getPosition(), null, argsNode, "<yield>");
 
-        final RubyNode[] argumentsTranslated = createArray(arguments.length);
-
-        for (int i = 0; i < arguments.length; i++) {
-            argumentsTranslated[i] = arguments[i].accept(this);
-        }
+        final RubyNode[] argumentsTranslated = argumentsAndBlock.getArguments();
 
         RubyNode readBlock = environment
                 .findLocalVarOrNilNode(TranslatorEnvironment.METHOD_BLOCK_NAME, node.getPosition());
 
         final RubyNode ret = new YieldExpressionNode(
-                unsplat,
-                keywordDescriptor,
+                argumentsAndBlock.isSplatted(),
+                argumentsAndBlock.getArgumentsDescriptor(),
                 argumentsTranslated,
                 readBlock,
                 environment.shouldWarnYieldInModuleBody());