[GR-18163] Update Math.sqrt to raise a Math::DomainError for negative numbers

PullRequest: truffleruby/3226

Author: eregon

CHANGELOG.md

@@ -47,6 +47,7 @@ Compatibility:
 * Update `File.utime` to return the number of file names in the arguments (#2616, @bjfish).
 * Update `Dir.foreach` to accept an `encoding` parameter (#2627, @bjfish).
 * Update `IO.readlines` to ignore negative limit parameters (#2625 , @bjfish).
+* Update `Math.sqrt` to raise a `Math::DomainError` for negative numbers (#2621, @bjfish).
 
 Performance:
 

spec/ruby/core/math/sqrt_spec.rb

@@ -27,6 +27,10 @@
   it "accepts any argument that can be coerced with Float()" do
     Math.sqrt(MathSpecs::Float.new).should be_close(1.0, TOLERANCE)
   end
+
+  it "raises a Math::DomainError when given a negative number" do
+    -> { Math.sqrt(-1) }.should raise_error(Math::DomainError)
+  end
 end
 
 describe "Math#sqrt" do

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -141,6 +141,7 @@ public class CoreLibrary {
     public final RubyClass loadErrorClass;
     public final RubyClass localJumpErrorClass;
     public final RubyClass matchDataClass;
+    public final RubyClass mathDomainErrorClass;
     public final RubyClass moduleClass;
     public final RubyClass nameErrorClass;
     public final RubyClass nilClass;
@@ -444,7 +445,8 @@ public CoreLibrary(RubyContext context, RubyLanguage language) {
         enumerableModule = defineModule("Enumerable");
         defineModule("GC");
         kernelModule = defineModule("Kernel");
-        defineModule("Math");
+        var mathModule = defineModule("Math");
+        mathDomainErrorClass = defineClass(mathModule, standardErrorClass, "DomainError");
         objectSpaceModule = defineModule("ObjectSpace");
 
         weakMapClass = defineClass(objectSpaceModule, objectClass, "WeakMap");

src/main/java/org/truffleruby/core/MathNodes.java

@@ -592,6 +592,10 @@ public abstract static class SqrtNode extends SimpleMonadicMathNode {
 
         @Override
         protected double doFunction(double a) {
+            if (a < 0.0) {
+                exceptionProfile.enter();
+                throw new RaiseException(getContext(), coreExceptions().mathDomainError("sqrt", this));
+            }
             return Math.sqrt(a);
         }
 

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -423,7 +423,7 @@ public RubyException mathDomainErrorLog(Node currentNode) {
 
     @TruffleBoundary
     public RubyException mathDomainError(String method, Node currentNode) {
-        RubyClass exceptionClass = context.getCoreLibrary().getErrnoClass("EDOM");
+        RubyClass exceptionClass = context.getCoreLibrary().mathDomainErrorClass;
         Rope rope = StringOperations.encodeRope(
                 StringUtils.format("Numerical argument is out of domain - \"%s\"", method),
                 UTF8Encoding.INSTANCE);

src/main/ruby/truffleruby/core/math.rb

@@ -13,8 +13,6 @@ module Math
   PI = 3.14159265358979323846
   E = 2.7182818284590452354
 
-  DomainError = Errno::EDOM
-
   module_function
 
   def hypot(a, b)