[GR-18163] Disable thread pool for Fibers as it causes correctness issues

PullRequest: truffleruby/3381

Author: eregon

CHANGELOG.md

@@ -1,3 +1,20 @@
+# 22.3.0
+
+New features:
+
+
+Bug fixes:
+
+
+Compatibility:
+
+
+Performance:
+
+
+Changes:
+
+
 # 22.2.0
 
 New features:
@@ -51,6 +68,7 @@ Performance:
 Changes:
 
 * `-Werror=implicit-function-declaration` is now used for compiling C extensions to fail more clearly and earlier if a function is missing, like CRuby 3.2 (#2618, @eregon).
+* Disable thread pool for Fibers as it causes correctness issues (#2551, @eregon).
 
 # 22.1.0
 

src/main/java/org/truffleruby/options/Options.java

@@ -72,7 +72,7 @@ public class Options {
     public final boolean PATCHING;
     /** --hashing-deterministic=false */
     public final boolean HASHING_DETERMINISTIC;
-    /** --fiber-pool=true */
+    /** --fiber-pool=false */
     public final boolean FIBER_POOL;
     /** --log-subprocess=false */
     public final boolean LOG_SUBPROCESS;

src/options.yml

@@ -102,7 +102,7 @@ EXPERT:
     LAZY_TRANSLATION_USER: [lazy-translation-user, boolean, LAZY_CALLTARGETS, 'Lazily translation of stdlib, gem and user source files']
     PATCHING: [patching, boolean, true, Use patching]
     HASHING_DETERMINISTIC: [hashing-deterministic, boolean, false, Produce deterministic hash values]
-    FIBER_POOL: [fiber-pool, boolean, true, 'Use a thread pool to speed up creating Fibers']
+    FIBER_POOL: [fiber-pool, boolean, false, 'Use a thread pool to speed up creating Fibers']
     LOG_SUBPROCESS: [log-subprocess, boolean, false, 'Log whenever a subprocess is created'] # Also see --log-process-args
     WARN_LOCALE: [warn-locale, boolean, true, 'Warn when the system locale is not set properly']
 

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -53,7 +53,7 @@ public class OptionsCatalog {
     public static final OptionKey<Boolean> LAZY_TRANSLATION_USER_KEY = new OptionKey<>(LAZY_CALLTARGETS_KEY.getDefaultValue());
     public static final OptionKey<Boolean> PATCHING_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> HASHING_DETERMINISTIC_KEY = new OptionKey<>(false);
-    public static final OptionKey<Boolean> FIBER_POOL_KEY = new OptionKey<>(true);
+    public static final OptionKey<Boolean> FIBER_POOL_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> LOG_SUBPROCESS_KEY = new OptionKey<>(false);
     public static final OptionKey<Boolean> WARN_LOCALE_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> EXCEPTIONS_STORE_JAVA_KEY = new OptionKey<>(false);