[GR-37597] Avoid an extra copy of a Ruby array and add more profiles for splat calls

PullRequest: truffleruby/3256

Author: eregon

bench/micro/dispatch/dispatch-mono-splat.rb

@@ -1,5 +1,5 @@
 class Callee
-  def call(arg1 = nil, arg2 = nil, arg3 = nil, arg4 = nil)
+  def call(arg1 = nil, arg2 = nil, arg3 = nil)
     :foo
   end
 end

src/main/java/org/truffleruby/language/dispatch/LiteralCallNode.java

@@ -27,7 +27,8 @@ public abstract class LiteralCallNode extends RubyContextSourceNode {
     @Child private CopyHashAndSetRuby2KeywordsNode copyHashAndSetRuby2KeywordsNode;
 
     protected final boolean isSplatted;
-    @CompilationFinal private boolean notRuby2KeywordsHashProfile, emptyKeywordsProfile, notEmptyKeywordsProfile;
+    @CompilationFinal private boolean lastArgIsNotHashProfile, notRuby2KeywordsHashProfile, emptyKeywordsProfile,
+            notEmptyKeywordsProfile;
 
     protected LiteralCallNode(boolean isSplatted, ArgumentsDescriptor descriptor) {
         this.isSplatted = isSplatted;
@@ -42,7 +43,17 @@ protected ArgumentsDescriptor getArgumentsDescriptorAndCheckRuby2KeywordsHash(Ob
             if (userArgsCount > 0) {
                 final Object lastArgument = ArrayUtils.getLast(args);
                 assert lastArgument != null;
-                if (isRuby2KeywordsHash(lastArgument)) { // both branches profiled
+
+                if (!(lastArgument instanceof RubyHash)) {
+                    if (!lastArgIsNotHashProfile) {
+                        CompilerDirectives.transferToInterpreterAndInvalidate();
+                        lastArgIsNotHashProfile = true;
+                    }
+
+                    return descriptor;
+                }
+
+                if (((RubyHash) lastArgument).ruby2_keywords) { // both branches profiled
                     if (copyHashAndSetRuby2KeywordsNode == null) {
                         CompilerDirectives.transferToInterpreterAndInvalidate();
                         copyHashAndSetRuby2KeywordsNode = insert(CopyHashAndSetRuby2KeywordsNode.create());
@@ -63,12 +74,10 @@ protected ArgumentsDescriptor getArgumentsDescriptorAndCheckRuby2KeywordsHash(Ob
         return descriptor;
     }
 
-    private boolean isRuby2KeywordsHash(Object lastArgument) {
-        return lastArgument instanceof RubyHash && ((RubyHash) lastArgument).ruby2_keywords;
-    }
-
     // NOTE: args is either frame args or user args
     protected boolean emptyKeywordArguments(Object[] args) {
+        assert isSplatted || descriptor instanceof KeywordArgumentsDescriptor;
+
         if (((RubyHash) ArrayUtils.getLast(args)).empty()) {
             if (!emptyKeywordsProfile) {
                 CompilerDirectives.transferToInterpreterAndInvalidate();

src/main/java/org/truffleruby/language/exceptions/RescueSplatNode.java

@@ -35,6 +35,7 @@ public RescueSplatNode(RubyLanguage language, RubyNode handlingClassesArray, Rub
                 SplatCastNode.NilBehavior.EMPTY_ARRAY,
                 false,
                 handlingClassesArray);
+        this.splatCastNode.doNotCopy();
         this.stores = ArrayStoreLibrary.getFactory().createDispatched(ArrayGuards.storageStrategyLimit());
     }
 

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -700,6 +700,14 @@ protected ArgumentsAndBlockTranslation translateArgumentsAndBlock(SourceIndexLen
             argumentsTranslated[i] = arguments[i].accept(this);
         }
 
+        if (isSplatted) {
+            assert argumentsTranslated.length == 1;
+            // No need to copy the array for call(*splat), the elements will be copied to the frame arguments
+            if (argumentsTranslated[0] instanceof SplatCastNode) {
+                ((SplatCastNode) argumentsTranslated[0]).doNotCopy();
+            }
+        }
+
         ParseNode blockPassNode = null;
         if (iterNode instanceof BlockPassParseNode) {
             blockPassNode = ((BlockPassParseNode) iterNode).getBodyNode();