Clean up sharing nodes now finalizer check is no longer needed.

Author: aardvark179

src/main/java/org/truffleruby/language/objects/shared/ShareInternalFieldsNode.java

@@ -10,7 +10,6 @@
 package org.truffleruby.language.objects.shared;
 
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
-import org.truffleruby.Layouts;
 import org.truffleruby.collections.BoundaryIterable;
 import org.truffleruby.core.array.ArrayGuards;
 import org.truffleruby.core.array.ArrayOperations;
@@ -29,7 +28,6 @@
 import com.oracle.truffle.api.dsl.ImportStatic;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.library.CachedLibrary;
-import com.oracle.truffle.api.object.Shape;
 import com.oracle.truffle.api.profiles.ConditionProfile;
 
 /** Share the internal fields of an object, accessible by its Layout */
@@ -85,13 +83,8 @@ protected void shareCachedQueue(RubyQueue object,
         }
     }
 
-    @Specialization(
-            guards = { "object.getShape() == cachedShape", "!hasFinalizerRef" },
-            assumptions = "cachedShape.getValidAssumption()",
-            limit = "CACHE_LIMIT")
-    protected void shareCachedBasicObject(RubyBasicObject object,
-            @Cached("object.getShape()") Shape cachedShape,
-            @Cached("hasFinalizerRefProperty(cachedShape)") boolean hasFinalizerRef) {
+    @Specialization
+    protected void shareCachedBasicObject(RubyBasicObject object) {
         /* No internal fields for RubyBasicObject */
     }
 
@@ -111,10 +104,6 @@ protected static boolean isDelegatedObjectArray(RubyArray array) {
         return store instanceof DelegatedArrayStorage && ((DelegatedArrayStorage) store).hasObjectArrayStorage();
     }
 
-    protected static boolean hasFinalizerRefProperty(Shape shape) {
-        return shape.hasProperty(Layouts.FINALIZER_REF_IDENTIFIER);
-    }
-
     protected WriteBarrierNode createWriteBarrierNode() {
         return WriteBarrierNodeGen.create(depth);
     }

src/main/java/org/truffleruby/language/objects/shared/ShareObjectNode.java

@@ -98,7 +98,6 @@ protected void shareUncached(RubyDynamicObject object) {
 
     protected static List<Property> getObjectProperties(Shape shape) {
         final List<Property> objectProperties = new ArrayList<>();
-        // User properties only, ShareInternalFieldsNode do the rest
         for (Property property : shape.getPropertyListInternal(false)) {
             if (property.getLocation() instanceof ObjectLocation) {
                 objectProperties.add(property);