Fix Array and Enumerable methods to warn when passed block argument not used

Author: andrykonchin

spec/ruby/core/array/all_spec.rb

@@ -4,4 +4,10 @@
 describe "Array#all?" do
   @value_to_return = -> (_) { true }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :all?
+
+  it "ignores the block if there is an argument" do
+    -> {
+      ['bar', 'foobar'].all?(/bar/) { false }.should == true
+    }.should complain(/given block not used/)
+  end
 end

spec/ruby/core/array/any_spec.rb

@@ -38,4 +38,12 @@
       array_with_members.any? {|v| v == 42 }.should == false
     end
   end
+
+  describe 'when given a pattern argument' do
+    it "ignores the block if there is an argument" do
+      -> {
+        ['bar', 'foobar'].any?(/bar/) { false }.should == true
+      }.should complain(/given block not used/)
+    end
+  end
 end

spec/ruby/core/array/count_spec.rb

@@ -14,6 +14,12 @@
     [:a, :b, :c].count { |s| s != :b }.should == 2
   end
 
+  it "ignores the block if there is an argument" do
+    -> {
+      [:a, :b, :b, :c].count(:b) { |e| e.size > 10 }.should == 2
+    }.should complain(/given block not used/)
+  end
+
   context "when a block argument given" do
     it_behaves_like :array_iterable_and_tolerating_size_increasing, :count
   end

spec/ruby/core/array/initialize_spec.rb

@@ -53,7 +53,9 @@
   end
 
   it "does not use the given block" do
-    ->{ [1, 2, 3].send(:initialize) { raise } }.should_not raise_error
+    -> {
+      -> { [1, 2, 3].send(:initialize) { raise } }.should_not raise_error
+    }.should complain(/#{__FILE__}:#{__LINE__-1}: warning: given block not used/, verbose: true)
   end
 end
 

spec/ruby/core/array/new_spec.rb

@@ -26,7 +26,9 @@
   end
 
   it "does not use the given block" do
-    ->{ Array.new { raise } }.should_not raise_error
+    -> {
+      -> { Array.new { raise } }.should_not raise_error
+    }.should complain(/warning: given block not used/, verbose: true)
   end
 end
 

spec/ruby/core/array/none_spec.rb

@@ -4,4 +4,10 @@
 describe "Array#none?" do
   @value_to_return = -> (_) { false }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :none?
+
+  it "ignores the block if there is an argument" do
+    -> {
+      ['bar', 'foobar'].none?(/baz/) { true }.should == true
+    }.should complain(/given block not used/)
+  end
 end

spec/ruby/core/array/one_spec.rb

@@ -4,4 +4,10 @@
 describe "Array#one?" do
   @value_to_return = -> (_) { false }
   it_behaves_like :array_iterable_and_tolerating_size_increasing, :one?
+
+  it "ignores the block if there is an argument" do
+    -> {
+      ['bar', 'foobar'].one?(/foo/) { false }.should == true
+    }.should complain(/given block not used/)
+  end
 end

spec/ruby/core/enumerable/all_spec.rb

@@ -177,5 +177,11 @@
       multi.all?(pattern).should == true
       pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
     end
+
+    it "ignores the block if there is an argument" do
+      -> {
+        EnumerableSpecs::Numerous.new(1, 2, 3, 4, 5).all?(String) { true }.should == false
+      }.should complain(/given block not used/)
+    end
   end
 end

spec/ruby/core/enumerable/any_spec.rb

@@ -190,5 +190,11 @@
       multi.any?(pattern).should == false
       pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
     end
+
+    it "ignores the block if there is an argument" do
+      -> {
+        EnumerableSpecs::Numerous.new(1, 2, 3, 4, 5).any?(String) { true }.should == false
+      }.should complain(/given block not used/)
+    end
   end
 end

spec/ruby/core/enumerable/none_spec.rb

@@ -143,5 +143,11 @@
       multi.none?(pattern).should == true
       pattern.yielded.should == [[[1, 2]], [[3, 4, 5]], [[6, 7, 8, 9]]]
     end
+
+    it "ignores the block if there is an argument" do
+      -> {
+        EnumerableSpecs::Numerous.new(1, 2, 3, 4, 5).none?(String) { true }.should == true
+      }.should complain(/given block not used/)
+    end
   end
 end