Support Time.new with :in keyword argument

Author: andrykonchin

spec/ruby/core/time/new_spec.rb

@@ -431,6 +431,10 @@ def zone.local_to_utc(t)
         time.zone.should == nil
       end
 
+      it "returns a Time with UTC offset specified as a single letter military timezone" do
+        Time.new(2000, 1, 1, 0, 0, 0, in: "W").utc_offset.should == 3600 * -10
+      end
+
       it "could be a timezone object" do
         zone = TimeSpecs::TimezoneWithName.new(name: "Asia/Colombo")
         time = Time.new(2000, 1, 1, 12, 0, 0, in: zone)
@@ -445,13 +449,29 @@ def zone.local_to_utc(t)
         time.zone.should == zone
       end
 
+      it "allows omitting minor arguments" do
+        Time.new(2000, 1, 1, 12, 1, 1, in: "+05:00").should == Time.new(2000, 1, 1, 12, 1, 1, "+05:00")
+        Time.new(2000, 1, 1, 12, 1, in: "+05:00").should == Time.new(2000, 1, 1, 12, 1, 0, "+05:00")
+        Time.new(2000, 1, 1, 12, in: "+05:00").should == Time.new(2000, 1, 1, 12, 0, 0, "+05:00")
+        Time.new(2000, 1, 1, in: "+05:00").should == Time.new(2000, 1, 1, 0, 0, 0, "+05:00")
+        Time.new(2000, 1, in: "+05:00").should == Time.new(2000, 1, 1, 0, 0, 0, "+05:00")
+        Time.new(2000, in: "+05:00").should == Time.new(2000, 1, 1, 0, 0, 0, "+05:00")
+        Time.new(in: "+05:00").round(0).should == Time.now.getlocal("+05:00").round(0)
+      end
+
+      it "converts to a provided timezone if all the positional arguments are omitted" do
+        Time.new(in: "+05:00").utc_offset.should == 5*3600
+      end
+
       it "raises ArgumentError if format is invalid" do
         -> { Time.new(2000, 1, 1, 12, 0, 0, in: "+09:99") }.should raise_error(ArgumentError)
         -> { Time.new(2000, 1, 1, 12, 0, 0, in: "ABC") }.should raise_error(ArgumentError)
       end
 
       it "raises ArgumentError if two offset arguments are given" do
-        -> { Time.new(2000, 1, 1, 12, 0, 0, "+05:00", in: "+05:00") }.should raise_error(ArgumentError)
+        -> {
+          Time.new(2000, 1, 1, 12, 0, 0, "+05:00", in: "+05:00")
+        }.should raise_error(ArgumentError, "timezone argument given as positional and keyword arguments")
       end
     end
   end

spec/tags/core/time/new_tags.txt

@@ -20,7 +20,4 @@ fails:Time.new with a timezone argument subject's class implements .find_timezon
 fails:Time.new with a timezone argument subject's class implements .find_timezone method calls .find_timezone to build a time object if passed zone name as a timezone argument
 fails:Time.new with a timezone argument subject's class implements .find_timezone method does not call .find_timezone if passed any not string/numeric/timezone timezone argument
 fails:Time.new has at least microsecond precision
-fails:Time.new with a timezone argument :in keyword argument could be UTC offset as a String in '+HH:MM or '-HH:MM' format
-fails:Time.new with a timezone argument :in keyword argument could be UTC offset as a number of seconds
 fails:Time.new with a timezone argument :in keyword argument could be a timezone object
-fails:Time.new with a timezone argument :in keyword argument raises ArgumentError if format is invalid

src/main/ruby/truffleruby/core/time.rb

@@ -464,9 +464,15 @@ def compose(offset, p1, p2=nil, p3=nil, p4=nil, p5=nil, p6=nil, p7=nil,
     end
     private :compose
 
-    def new(year=undefined, month=nil, day=nil, hour=nil, minute=nil, second=nil, utc_offset=nil)
+    def new(year=undefined, month=nil, day=nil, hour=nil, minute=nil, second=nil, utc_offset=nil, **options)
+      if utc_offset && options[:in]
+        raise ArgumentError, 'timezone argument given as positional and keyword arguments'
+      end
+
+      utc_offset ||= options[:in]
+
       if Primitive.undefined?(year)
-        self.now
+        utc_offset ? self.now.getlocal(utc_offset) : self.now
       elsif Primitive.nil? utc_offset
         compose(:local, year, month, day, hour, minute, second)
       elsif utc_offset.instance_of?(String) && !utc_offset.encoding.ascii_compatible?