[GR-18163] Use -Werror=implicit-function-declaration for all C extensions

PullRequest: truffleruby/3244

Author: eregon

CHANGELOG.md

@@ -1,3 +1,21 @@
+# 22.2.0
+
+New features:
+
+
+Bug fixes:
+
+
+Compatibility:
+
+
+Performance:
+
+
+Changes:
+
+* `-Werror=implicit-function-declaration` is now used for compiling C extensions to fail more clearly and earlier if a function is missing, like CRuby 3.2 (#2618, @eregon).
+
 # 22.1.0
 
 New features:

ci.jsonnet

@@ -507,7 +507,7 @@ local composition_environment = utils.add_inclusion_tracking(part_definitions, "
       "ruby-test-mri-linux":         $.platform.linux  + $.jdk.v11 + $.env.jvm + gate + $.run.test_mri + { timelimit: "01:10:00" },
       "ruby-test-mri-darwin":        $.platform.darwin + $.jdk.v11 + $.env.jvm + gate + $.run.test_mri + { timelimit: "01:30:00" },
       "ruby-test-integration-linux": $.platform.linux  + $.jdk.v11 + $.env.jvm + gate + $.run.test_integration,
-      "ruby-test-cexts-linux":       $.platform.linux  + $.jdk.v11 + $.env.jvm + gate + $.use.gem_test_pack + $.run.test_cexts,
+      "ruby-test-cexts-linux":       $.platform.linux  + $.jdk.v11 + $.env.jvm + gate + $.use.gem_test_pack + $.use.sqlite331 + $.run.test_cexts,
       "ruby-test-cexts-darwin":      $.platform.darwin + $.jdk.v11 + $.env.jvm + gate + $.use.gem_test_pack + $.run.test_cexts + { timelimit: "01:20:00" },
       "ruby-test-gems-linux":        $.platform.linux  + $.jdk.v11 + $.env.jvm + gate + $.use.gem_test_pack + $.run.test_gems,
       "ruby-test-gems-darwin":       $.platform.darwin + $.jdk.v11 + $.env.jvm + gate + $.use.gem_test_pack + $.run.test_gems,

lib/cext/ABI_check.txt

@@ -1 +1 @@
-6
+7

lib/cext/ABI_version.txt

@@ -1 +1 @@
-14
+15

lib/cext/include/stubs/internal/file.h

@@ -1 +1,10 @@
+#ifndef INTERNAL_FILE_H                                  /*-*-C-*-vi:se ft=c:*/
+#define INTERNAL_FILE_H
+
 #include "ruby.h"
+
+#ifdef __APPLE__
+VALUE rb_str_normalize_ospath(const char *ptr, long len);
+#endif
+
+#endif /* INTERNAL_FILE_H */

lib/cext/include/stubs/internal/time.h

@@ -1 +1,8 @@
+#ifndef INTERNAL_TIME_H                                  /*-*-C-*-vi:se ft=c:*/
+#define INTERNAL_TIME_H
+
 #include "ruby.h"
+
+void ruby_reset_leap_second_info(void);
+
+#endif /* INTERNAL_TIME_H */

lib/truffle/rbconfig.rb

@@ -72,7 +72,7 @@ module RbConfig
   optflags = ''
   debugflags = ''
   warnflags = [
-    '-Wimplicit-function-declaration', # To make missing C ext functions clear
+    '-Werror=implicit-function-declaration', # https://bugs.ruby-lang.org/issues/18615
     '-Wno-int-conversion',             # MRI has VALUE defined as long while we have it as void*
     '-Wno-int-to-pointer-cast',        # Same as above
     '-Wno-incompatible-pointer-types', # Fix byebug 8.2.1 compile (st_data_t error)

test/mri/failing.exclude

@@ -32,7 +32,6 @@ ruby/test_pattern_matching.rb #  syntax error, unexpected modifier_if (SyntaxErr
 ruby/test_memory_view.rb # rb_memory_view_register not found
 
 # Too slow
-
 racc/test_racc_command.rb
 
 # Other issues